Commit Graph

2149 Commits

Author SHA1 Message Date
jdlrobson 6300923601 Storybook should include UserLinks
Merge UserMenu into UserLinks for legacy and modern
Add a story for the UserLinks menu

Fixes: rendering of Skin (legacy) personal tools (the user icon
no longer overlaps)

Change-Id: I491ebb3962780bf2cf7f1dfb4dd09d576c294366
2021-05-27 19:27:27 +00:00
jdlrobson e1d0f1e61c Storybook: Consistent styling
- Make sure common styles are loaded for all components
- Add icon in user menu

Fixes renders of:
- Language button (no top margin and button styles)
- MenuPortal (no left margins)


Change-Id: I98b4820b6d91d46fd27a1d433d5bacd187a7cbb0
2021-05-27 19:27:21 +00:00
jenkins-bot e111ead970 Merge "Storybook: Move helperMakeMenuData into utils" 2021-05-27 18:28:22 +00:00
jdlrobson e305d720d4 Storybook: Move helperMakeMenuData into utils
In preparation for using for the UserLinks component.

Change-Id: Ifd3d1cc5513cd1477d1cb2e5d6e4db800fee12f7
2021-05-27 18:06:05 +00:00
Translation updater bot 838f72a484 Localisation updates from https://translatewiki.net.
Change-Id: If26220738c2d51dc55cc27fcd16715a2a0752716
2021-05-27 13:47:34 +02:00
Translation updater bot b445847998 Localisation updates from https://translatewiki.net.
Change-Id: I9272166db48f6549cbaf468974a2606e89d8c295
2021-05-27 13:12:17 +02:00
Translation updater bot 329a0dac56 Localisation updates from https://translatewiki.net.
Change-Id: Ia5be2abd9780a55f5a84f6aa75ac0dcb9a1d7367
2021-05-27 10:39:23 +02:00
Translation updater bot 64d03c85ac Localisation updates from https://translatewiki.net.
Change-Id: Ibb742b86acbfcdaba1ef88f3ebd6370b4a7efd4d
2021-05-26 09:08:20 +02:00
jenkins-bot 1c3a214b24 Merge "Refactor: Create UserLinks component" 2021-05-25 18:49:47 +00:00
jdlrobson 96bf1e8276 Refactor: Create UserLinks component
Have a single template for the UserLinks component, with a single
element wrapping all its subcomponents as discussed.

Change-Id: I35936a6fa1ba335639ca3f47fd439a3662268fca
2021-05-25 16:57:35 +00:00
jenkins-bot d7e22f7f20 Merge "Use escaped() instead of parse() in SkinVector::createULSLanguageButton" 2021-05-24 16:02:39 +00:00
jenkins-bot a9215e49a6 Merge "Introduce the vector-body class" 2021-05-24 14:51:07 +00:00
Jan Drewniak 7258a7cb86 Use escaped() instead of parse() in SkinVector::createULSLanguageButton
Bug: T282540
Change-Id: Ie8f0fe262f34e669d49f98efc27c179b257786dc
2021-05-24 14:07:25 +02:00
Translation updater bot 2f854e0b9e Localisation updates from https://translatewiki.net.
Change-Id: Ib1f8652d7a435177de767c2012d90d57391f1c29
2021-05-24 09:59:46 +02:00
jdlrobson 3306124038 Introduce the vector-body class
This follows up I4c1b15d90bacbc9b13782a1d8f52e838ce8ecd83
In that change, a new class for Vector specific styles should have
been added and the existing CSS referenced. I could have sworn I did
this, but obviously not (perhaps a git rebase or unstage change problem).
We did it for the other skins e.g. Monobook (I90d85c21f4a62e6697f24e3ce388445a0a53c2b0)
but evidently not Vector.

We also have to worry about cached HTML now, the #bodyContent is
the most reliable selector to use for before and after
I4c1b15d90bacbc9b13782a1d8f52e838ce8ecd83

Additional:
Remove the mixin-clearfix rule on bodyContent - this is now
redundant with the changes in T279388 and should have been
removed.

Bug: T283206
Change-Id: I15103cea72c793589a03ab1a3e7f3b377acb287f
2021-05-21 13:50:31 -07:00
James D. Forrester eb5d58a9f5 composer: Point IRC presence to Libera and better git source
Change-Id: I92aabc5091b04d9744de2d845934871801fab7cd
2021-05-21 10:11:50 -07:00
Translation updater bot ea85248088 Localisation updates from https://translatewiki.net.
Change-Id: I21be576c91ea7b576b00ee74bcdfcda0bb834342
2021-05-21 08:36:19 +02:00
Translation updater bot 96b383df0d Localisation updates from https://translatewiki.net.
Change-Id: Ie6316de4329bfad84dfc600ca4849d1123cde447
2021-05-20 09:13:44 +02:00
Translation updater bot cc982d3bae Localisation updates from https://translatewiki.net.
Change-Id: Iad6e288d13dd12ef301ce0ec6ca6c0320fa52e92
2021-05-19 08:47:00 +02:00
Translation updater bot ea6a4a0889 Localisation updates from https://translatewiki.net.
Change-Id: Ia6ade96fddf83f7ebb08e1f3900a06dc142be119
2021-05-18 08:49:38 +02:00
Thiemo Kreuz 9213c514e6 Remove not needed $this->equalTo() from tests
This is the default anyway. I believe the tests are much more
readable without this.

Change-Id: I9f6c0d777ae5cd184acf40b1ef5b7b171dc3e675
2021-05-17 10:05:10 +02:00
Translation updater bot 9b4c0e39ae Localisation updates from https://translatewiki.net.
Change-Id: I4331005d26acef68b01a97b966443b2abdac9930
2021-05-17 08:48:02 +02:00
libraryupgrader dd6cdd7149 build: Updating jsdoc to 3.6.7
* https://npmjs.com/advisories/1674 (CVE-2021-23358)

Change-Id: Iaa01d3c4f3becdbc8f45368e9877211b434b7fa6
2021-05-15 18:15:54 +00:00
jenkins-bot 81947cbd67 Merge "Remove unused $contentNavigation from `getTemplateData` method" 2021-05-14 20:20:54 +00:00
Nicholas Ray 7ab2edb2fa Remove unused $contentNavigation from `getTemplateData` method
This is not used in the method and, from the surface, appears to be
extraneous.

Change-Id: I63b1eba54f8ce11296c187b292010e415a2915af
2021-05-14 12:13:14 -06:00
jdlrobson 6998c536d4 Both UserMenu stylesheets should be shipped in modern
Since we have feature flagged the new user menu feature, it is
imperative we load both sets of styles until the feature has
shipped. This allows us to switch seamlessly between the two
without worrying about cached HTML being served with updated CSS.

To do this, we add a new class to both user menu's distinguishing
the legacy version from the modern version. The styles are then
scoped to these new selectors.

This also fixes some regressions with the legacy user menu in
modern Vector when wgVectorConsolidateUserLinks is disabled.

Notes:
* No caching selector is needed for #pt-userpage given it can only
ever be output for logged in users.
* ID selectors in general are bad, so scoping to mw-portlet-personal-user-menu-legacy
isolates the legacy component allowing it to be rendered alongside the modern UserMenu

Bug: T276561
Change-Id: I068c5233bb25a7b141e66a6726b5761841f83eb2
2021-05-14 10:13:09 -07:00
Jdlrobson efaf3aadf3 Remove mw-body-content from HTML that is not the article body
The `mw-body-content` class is currently decorating various things,
however should be limited to the body of the article. This allows
us to identify the wrapping element without resorting to a selector
that makes use of an identifier and to separate styling concerns of
UI (indicators and site notice) from article content.

Bug: T279388
Change-Id: I4c1b15d90bacbc9b13782a1d8f52e838ce8ecd83
2021-05-14 00:01:52 +00:00
Clare Ming 63f9dd81e3 Cleanup styles for personal user dropdown menu.
Remove redundant styles. Update personal menu dropdown to more closely reflect design of OOUI dropdown elements. Extract legcay-specific, modern-specific styles for UserMenu into separate partials. Create new shared UserMenu component.

Bug: T276561
Change-Id: I1e56cd5b3b24ac1b5cae684301b8e3a84ea33a5c
2021-05-13 23:19:54 +00:00
jenkins-bot 234659e3e3 Merge "Allow `languageinheader` query param to fully control treatment of languages" 2021-05-13 20:04:15 +00:00
Nicholas Ray de5a640c0b Allow `languageinheader` query param to fully control treatment of languages
Before this commit the `languageinheader` query param would only take
effect if the A/B test was enabled AND the query param was set. Per
T282543, we want the query param to take effect regardless of the state
of the language/AB test config.

To see new treatment, set `languageinheader=1`.
To see old treatment, set `languageinheader=0`.

Bug: T282543
Change-Id: I6a06e90b6e46a6fd7506a5ddeaf071b893ebfe8e
2021-05-13 12:04:12 -06:00
jenkins-bot 13e45adb28 Merge "search: Wire up submit event handler" 2021-05-13 15:39:12 +00:00
Sam Smith 7f780961a6 search: Wire up submit event handler
Bug: T274869
Change-Id: I5fab22564fa2fe140858cc214aac017d7bd6c68e
2021-05-13 15:29:18 +01:00
Translation updater bot 25ee080773 Localisation updates from https://translatewiki.net.
Change-Id: I98f8bafd0769dc34953b1d1221075a0d9bc295e2
2021-05-12 09:26:57 +02:00
Translation updater bot 87058d8caa Localisation updates from https://translatewiki.net.
Change-Id: I627f494ab9ec1dfe6a0448ecec98efc1a02c887e
2021-05-11 09:10:51 +02:00
jenkins-bot 50430ea06a Merge "search: Update styling for the search loading state" 2021-05-10 20:55:31 +00:00
jenkins-bot b41e224ec6 Merge "Refactor: Renaming mustache variable `page-isarticle` to `is-article`" 2021-05-10 09:38:08 +00:00
Jan Drewniak c22dc8d95b Refactor: Renaming mustache variable `page-isarticle` to `is-article`
Modifies this variable name to use proper hyphen-case and
prioritizes the type of variable rather than it's source.

This prioritization makes sense in Mustache templates because the
variable is a boolean and is used exclusively in if statements,
e.g. {{#is-article}} ... {{/is-article}}

Change-Id: I72e9baf0a979d922b8217aabe8cf0c40699f891b
2021-05-10 08:55:06 +00:00
Translation updater bot 18e74b2292 Localisation updates from https://translatewiki.net.
Change-Id: I54821846ebfced651cde76b622ac74f2a9eb5e96
2021-05-10 08:59:33 +02:00
bwang 964e214e87 search: Update styling for the search loading state
Bug: T273093
Change-Id: Ifd7f07411597be844cb7de79e416975261069506
2021-05-07 17:04:42 -05:00
Jan Drewniak 9027d57804 Fix: update to 80d734b4, hide language dropdown when ULS loads
Bug: T276140
Change-Id: I70997fbc54554b8d1b9c271a5ca93f2a47f1ee92
2021-05-07 12:24:30 +02:00
Translation updater bot 865cc4a566 Localisation updates from https://translatewiki.net.
Change-Id: I1858001c141885236e191c94abb78ea29f7d51ac
2021-05-07 08:47:06 +02:00
jdlrobson e7a4ecf9db Refactor: Clarify functions that return booleans and template booleans
We prefix templates that are booleans with "is-" and tend to prefix
functions that return booleans with "if" or "should"

This renames the new "shouldConsolidateLinks" method.

Follow up to I1c305d89bece147a6f1b478441119c3169abfbdd

Change-Id: I6a5908b8b35ca6bceec8b864e3ac651fc7e8ced8
2021-05-06 23:51:56 +00:00
jenkins-bot 840bc5b0cd Merge "Consolidate user links into personal dropdown menu for logged users." 2021-05-06 20:17:33 +00:00
Clare Ming dc0b679bfa Consolidate user links into personal dropdown menu for logged users.
Pull personal menu items except for user page link into a consolidated dropdown menu based on feature flag using Vector hooks. Add consolidate user links feature flag for logged in/out users. Update styles for personal toolbar. Add logic to template to show legacy toolbar or consolidated toolbar based on feature flag variables.

Bug: T276561
Depends-On: If4e143aada711d210ae45d33b97a6be0685b6a41
Change-Id: I1c305d89bece147a6f1b478441119c3169abfbdd
2021-05-06 12:49:39 -07:00
jenkins-bot 545eb7fb2b Merge "LanguageButton story should load mediawiki ui button styles" 2021-05-06 09:10:29 +00:00
Translation updater bot ca113fd066 Localisation updates from https://translatewiki.net.
Change-Id: Ic6433b90bd8143042dc322da59c6cacb5d1d5a2a
2021-05-06 08:56:58 +02:00
Nicholas Ray 8eba1da250 Silence eslint compat/compat for search performance instrumentation
Eslint is throwing compat warnings on every commit in Vector. This
commit silences those warnings.

Change-Id: I0e914c6179745415e916fadd382d86baa72e3e63
2021-05-05 14:37:35 -06:00
jenkins-bot bea00bc290 Merge "Create A/B test harness for Language in header feature" 2021-05-05 17:33:38 +00:00
jenkins-bot 888e17bd47 Merge "Place language button near bottom of Main page." 2021-05-05 17:08:18 +00:00
Jdlrobson d2c7805fa8 LanguageButton story should load mediawiki ui button styles
Discovered while testing I97bf0c11d0321752d472ac4988618a1db92b7271

Change-Id: I8634717ea58544b2d226fbb114bea43639a6542d
2021-05-05 09:41:10 -07:00