golem
/
VectorGOLEM
9
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity

Remove not needed $this->equalTo() from tests 

This is the default anyway. I believe the tests are much more
readable without this.

Change-Id: I9f6c0d777ae5cd184acf40b1ef5b7b171dc3e675
This commit is contained in:
Thiemo Kreuz 2021-05-17 10:04:07 +02:00
parent 9b4c0e39ae
commit 9213c514e6
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/phpunit/integration/SkinVersionLookupTest.php
View File

@ -34,7 +34,7 @@ class SkinVersionLookupTest extends \MediaWikiTestCase {
$request = $this->getMockBuilder( \WebRequest::class )->getMock();
$request
->method( 'getVal' )
->with( $this->anything(), $this->equalTo( 'beta' ) )
->with( $this->anything(), 'beta' )
->willReturn( 'alpha' );
$user = $this->createMock( \User::class );
@ -43,7 +43,7 @@ class SkinVersionLookupTest extends \MediaWikiTestCase {
->willReturn( false );
$user
->method( 'getOption' )
->with( $this->anything(), $this->equalTo( '2' ) )
->with( $this->anything(), '2' )
->willReturn( 'beta' );
$config = new HashConfig( [
@ -73,7 +73,7 @@ class SkinVersionLookupTest extends \MediaWikiTestCase {
$request = $this->getMockBuilder( \WebRequest::class )->getMock();
$request
->method( 'getVal' )
->with( $this->anything(), $this->equalTo( 'beta' ) )
->with( $this->anything(), 'beta' )
->willReturn( 'beta' );
$user = $this->createMock( \User::class );
@ -82,7 +82,7 @@ class SkinVersionLookupTest extends \MediaWikiTestCase {
->willReturn( false );
$user
->method( 'getOption' )
->with( $this->anything(), $this->equalTo( '2' ) )
->with( $this->anything(), '2' )
->willReturn( 'beta' );
$config = new HashConfig( [
@ -112,7 +112,7 @@ class SkinVersionLookupTest extends \MediaWikiTestCase {
$request = $this->getMockBuilder( \WebRequest::class )->getMock();
$request
->method( 'getVal' )
->with( $this->anything(), $this->equalTo( '1' ) )
->with( $this->anything(), '1' )
->willReturn( '1' );
$user = $this->createMock( \User::class );
@ -121,7 +121,7 @@ class SkinVersionLookupTest extends \MediaWikiTestCase {
->willReturn( true );
$user
->method( 'getOption' )
->with( $this->anything(), $this->equalTo( '1' ) )
->with( $this->anything(), '1' )
->willReturn( '1' );
$config = new HashConfig( [
@ -151,7 +151,7 @@ class SkinVersionLookupTest extends \MediaWikiTestCase {
$request = $this->getMockBuilder( \WebRequest::class )->getMock();
$request
->method( 'getVal' )
->with( $this->anything(), $this->equalTo( '2' ) )
->with( $this->anything(), '2' )
->willReturn( '2' );
$user = $this->createMock( \User::class );
@ -160,7 +160,7 @@ class SkinVersionLookupTest extends \MediaWikiTestCase {
->willReturn( false );
$user
->method( 'getOption' )
->with( $this->anything(), $this->equalTo( '2' ) )
->with( $this->anything(), '2' )
->willReturn( '2' );
$config = new HashConfig( [