Commit Graph

88 Commits

Author SHA1 Message Date
jdlrobson b478393e5e Hygiene: The main page check is not necessary
The main page in the Minerva skin is not editable so this code is
just cruft. T89559 no longer applies.

Change-Id: Ifcd30be0d4e328b056cc7fcfb714c9783b62c913
2017-08-03 15:58:18 -07:00
Translation updater bot 05734ca433 Localisation updates from https://translatewiki.net.
Change-Id: Ib3d3c173d674fb3bf43f12c11f38906d90ac9c25
2017-08-02 23:06:12 +02:00
jdlrobson 7e7e532bfb Relax navbox hack
Per discussion in T172078 let's relax these rules so navbox shows
up in the desktop mode of the site.

Note: this will not impact the mobile site as navboxes are stripped
from the HTML.

Bug: T172078
Change-Id: I59d229d75dbcb790eb75dc4b838b2afafd2f3980
2017-08-02 15:14:59 +00:00
jenkins-bot 9a6770ee18 Merge "Use lead section when editing page without section marks" 2017-08-02 14:49:18 +00:00
jdlrobson a93cd66026 Style Parsoid generated references
Bug: T171727
Change-Id: I34838562360ec7d4fc55e1f3a7dad8a926e4da52
2017-08-02 14:43:36 +00:00
Baha 975d632d12 Use lead section when editing page without section marks
The config variable `MFNamespacesWithoutCollapsibleSections` controls
namespaces where section collapsing is disabled. In those namespaces
page is not divided into sections marked with `.mf-section-X` classes.
If that's the case the edit button edits the first section, which is
the whole page.

Bug: T157995
Change-Id: I3ec353575529c1fb11a33fc35c9886cf232e327f
2017-08-01 19:01:20 -04:00
jenkins-bot 61f26498a1 Merge "QA: Make sure toast is not empty before checking text value" 2017-08-01 20:59:12 +00:00
Translation updater bot e9f5596ae1 Localisation updates from https://translatewiki.net.
Change-Id: I6e5b1704ff000e4a68eeec7fc6934d882a688c74
2017-08-01 22:10:55 +02:00
jdlrobson ebef44d0fe QA: Make sure toast is not empty before checking text value
Copies approach for the text of the first heading should be
accounting for the fact that the toast can have an empty
message "" at any given time.

Bug: T170890
Change-Id: Iba8a503a2aea30cb46fba27f000843183e9c46f1
2017-08-01 12:59:54 -07:00
jenkins-bot 8803101c52 Merge "Blank parsoid styles, update thumbnail selectors for Parsoid content" 2017-08-01 00:22:04 +00:00
jdlrobson 0f93115725 QA: Minor tweaks to how we check toast notifications
A toast autohides within 5 seconds and its display properties are
inherited from #mw-notification-area. This slight tweak waits for
mw-notification-area to be visible before verifying toast and its
contents

Change-Id: I89beaf9d131155e958cc9aae84a9e30ffd8e9e4f
2017-07-31 15:13:00 -07:00
jenkins-bot 9243513749 Merge "Show cursor:text when pointing over search input" 2017-07-31 21:36:54 +00:00
jenkins-bot 7ca52b012c Merge "Make sure lead section exists before accessing its method" 2017-07-31 21:30:47 +00:00
Translation updater bot 5b6349f8ae Localisation updates from https://translatewiki.net.
Change-Id: Ia0fec489e5d5b70c0aa2e1dc112fa08c2c613ac1
2017-07-31 22:12:06 +02:00
jenkins-bot ebb0ef89b7 Merge "Show title on the page named '0'" 2017-07-31 19:44:19 +00:00
Baha 6f8b3d040c Make sure lead section exists before accessing its method
The `getLeadSectionElement` method of `Page` may return a `null`. Do
not try to access the `text` method of the returned object if it's
`null`.

Bug: T157995
Change-Id: Ia752fa52d1b09a307dc4b803a6b7e1bdcfe7f867
2017-07-31 15:21:06 -04:00
Piotr Miazga a0e390a9e5 Show cursor:text when pointing over search input
Changes:
 -  added styles pointer:text for #searchInput element

Bug: T161763
Change-Id: I39050a3e81c6b2e014f8955df188629a025ef2c1
2017-07-31 20:26:25 +02:00
Antoine Musso 061019ddb2 Define npm peer dependency explicitly
npm 3 requires dependencies to be explicitly defined.

Bug: T172094
Change-Id: Ic640ccf0f577e47036d473892522ea758014fab4
2017-07-31 12:22:45 +00:00
Translation updater bot 9d39e445a1 Localisation updates from https://translatewiki.net.
Change-Id: I4200d7b41804d7ee18d0eac22994113a46340ac0
2017-07-30 22:14:06 +02:00
Eddie Greiner-Petter b0384c4314 Show title on the page named '0'
The string '0' evals to false in the if( $pageTitle ) condition, hence
the title was not shown for the page named '0'.

Bug: T163084
Change-Id: I27ab379bf67634c484c4cf5e12e391d69702f464
2017-07-30 19:50:34 +02:00
Translation updater bot 481bafcdc9 Localisation updates from https://translatewiki.net.
Change-Id: I0205c5600c1545348630bb4b5f7d5c217864d436
2017-07-29 22:14:37 +02:00
Translation updater bot 1be831129a Localisation updates from https://translatewiki.net.
Change-Id: I8db0b5d406cc057e807c14274396458248d4a4fc
2017-07-28 22:02:24 +02:00
jenkins-bot d746b6d970 Merge "Browser tests: Use generic toast step" 2017-07-27 21:33:19 +00:00
jdlrobson a6a093faab Blank parsoid styles, update thumbnail selectors for Parsoid content
This brings Parsoid styles when viewed in Minerva consistent with
MediaWiki parser output styles.

You can verify this with:
https://gerrit.wikimedia.org/r/#/c/368287/

Bug: T171727
Change-Id: If4bd7671a99aefdf074061dd1d5b0bac93620e9e
2017-07-27 14:27:47 -07:00
jdlrobson d5a60fdd43 Browser tests: Use generic toast step
Introduces a new generic
"I should see a toast with message ".*""
step reducing toast steps to two generic ones.

Change-Id: Ic8b91c78f6df088244f15223ee4ed658847a05b5
2017-07-27 13:41:54 -07:00
Translation updater bot 5046bb075b Localisation updates from https://translatewiki.net.
Change-Id: Ic9711e9404dd028bc471ff5895f95a698372c380
2017-07-27 22:32:25 +02:00
jenkins-bot ed427dd427 Merge "Don't show ImageOverlay in desktop mode - delegate to multimedia viewer" 2017-07-27 15:30:57 +00:00
jdlrobson 9500297090 Don't show ImageOverlay in desktop mode - delegate to multimedia viewer
Bug: T169622
Change-Id: Ie34297a56f8571b161802ea8a708a8bed37c9173
2017-07-27 15:26:31 +00:00
Fomafix 13bdb53845 chmod a-x resources/*/*.{less,svg}
Change-Id: Ic4a2c91c8282a30ae069cc33deffada1df66ff22
2017-07-26 22:14:13 +00:00
Translation updater bot 97f87921b6 Localisation updates from https://translatewiki.net.
Change-Id: Ia7783e37cecf767e0d89975784e39d77a1913141
2017-07-26 22:01:30 +02:00
jenkins-bot 78daa06cc1 Merge "Hygiene: Drop MFAllowNonJavaScriptEditing and Special:MobileEditor" 2017-07-26 18:40:09 +00:00
jenkins-bot 112587b227 Merge "Remove a full stop from the end of the tooltip" 2017-07-25 21:17:18 +00:00
Translation updater bot f31b3bf9df Localisation updates from https://translatewiki.net.
Change-Id: I46cb65a7b894ab607484bab82dd83efd496add5b
2017-07-25 22:01:48 +02:00
jdlrobson 3ad9c4e3c6 Hygiene: Drop MFAllowNonJavaScriptEditing and Special:MobileEditor
Bug: T125174
Change-Id: Ifc0efcb87605e5cd678343d1ac91a2ce53b33664
2017-07-25 11:07:03 -07:00
Translation updater bot e81e5cd11d Localisation updates from https://translatewiki.net.
Change-Id: Iaeefb43cbf364545db4b426d44f5bf99cb993802
2017-07-24 22:29:00 +02:00
Umherirrender 2aacf47c8d build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
Change-Id: Icba559465885af1169a1912f501bed56eea23ad9
2017-07-24 18:53:04 +02:00
Piotr Miazga 6819b6e163 Hygiene: Use ExtensionRegistry to manage skin dependencies
Changes:
 - removed MobileFrontend existence check from MinervaHooks
 - added MobileFrontend as a requirement inside skin.json

Additional benefit: Skin will work only with MobileFrontend v2.0.0
and higher.

Change-Id: I1f2f5de3dbc0cf5159a06bc8f47e1cf401a2fcdb
2017-07-24 15:58:21 +00:00
Translation updater bot af2210fb87 Localisation updates from https://translatewiki.net.
Change-Id: Ic41bf09bdcf77a14ecdacc03fb050ff3cc3f8da5
2017-07-23 22:05:29 +02:00
Translation updater bot b716f70ced Localisation updates from https://translatewiki.net.
Change-Id: I4ce49b8b5fb44df5d367ee906186353fdbe03905
2017-07-22 22:06:11 +02:00
Amire80 8dcbf26815 Remove a full stop from the end of the tooltip
There are no full stops on other tooltips.

Change-Id: I807b20eeeccc343baffb42e57f6e97ad03ea3d55
2017-07-22 10:28:15 +03:00
Translation updater bot 07828dcdae Localisation updates from https://translatewiki.net.
Change-Id: I8f0d5240a7acab01724730cd24c45d8a312f2e20
2017-07-21 22:05:53 +02:00
jenkins-bot bd898e2be4 Merge "Minerva should use mediawiki.hlist" 2017-07-21 18:47:35 +00:00
jenkins-bot 7d0501127f Merge "Hygiene: Remove and update references to MobileFrontend" 2017-07-21 18:47:12 +00:00
jenkins-bot 27504d67c0 Merge "Add tooling for documentation" 2017-07-20 22:37:59 +00:00
jdlrobson efc84d2f25 Add tooling for documentation
* Add global View and Page
* Remove inheritdoc statements for globals - docs
  cannot be inherited from a class defined in another repo

Note:
you'll need to `gem install jsduck` for this to work

Bug: T170639
Change-Id: Idb3a6e9edbd45889047e7904561b84033569a689
2017-07-20 22:34:41 +00:00
jdlrobson fe8654adff Hygiene: Copy across bits of README.md from MobileFrontend
See:
Ia042ce3db5f4fed20913b54a6c0c80fe52762711

Change-Id: Idc05fa0854b113b0daaca54054cf4acaef50f157
2017-07-20 09:13:36 -07:00
jdlrobson 47546207ad Hygiene: Remove and update references to MobileFrontend
Changes:
* Update docs
* Update browser test artifacts
* Update comments
* Update phpunit test groups
* Update phpunit test namespace
* Update `die` when MobileFrontend not installed
* Remove the migrate script which is no longer needed

Change-Id: I83432b3f7f0bcd07ed08259972b8ff89147104b6
2017-07-19 14:21:50 -07:00
jdlrobson 747b712509 Minerva should use mediawiki.hlist
Override provided styles

Bug: T42062
Depends-On: I9305af5d30c8c24b44f4a0c6a466581c45fa3028
Change-Id: I7adda8ef99e5eee3df5bd7dc4da5081c1225f815
2017-07-19 13:52:09 -07:00
Umherirrender 211a54b568 Update and run existing stylelint
stylelint is part of config, but not run by default
Also update to 0.4.1, it is the current default in many wmf extensions

Change-Id: I55f81489182628c088e362e081417514e252e6d6
2017-07-19 20:31:24 +00:00
Piotr Miazga f86cfc6fc4 Do not show warning box when LoginForm was posted
Because there is no easy way to detect failed user login/account
creation, do not show warning box during POST request. This should
do the trick as there shouldn't be possible to display valid
login/usercreate form during POST request.

Bug: T149413
Change-Id: Ieb7a34068aaad99616ad6c43de48f70a6775882e
Depends-On: I6ba28ddaeb0f9af17fa875bd9d1265509db4b927
2017-07-19 17:21:09 +00:00