golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Hygiene: Use ExtensionRegistry to manage skin dependencies 

Changes:
 - removed MobileFrontend existence check from MinervaHooks
 - added MobileFrontend as a requirement inside skin.json

Additional benefit: Skin will work only with MobileFrontend v2.0.0
and higher.

Change-Id: I1f2f5de3dbc0cf5159a06bc8f47e1cf401a2fcdb
This commit is contained in:
Piotr Miazga 2017-07-24 16:29:58 +02:00 committed by Jdlrobson
parent af2210fb87
commit 6819b6e163
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
includes/Minerva.hooks.php
View File

@ -35,9 +35,6 @@ class MinervaHooks {
global $wgResourceLoaderLESSImportPaths;
$wgResourceLoaderLESSImportPaths[] = dirname( __DIR__ ) . "/minerva.less/";
if ( !ExtensionRegistry::getInstance()->isLoaded( 'MobileFrontend' ) ) {
die( 'This version of the Minerva skin requires MobileFrontend' );
}
// Setup alias for compatibility with SkinMinervaNeue.
if ( !class_exists( 'SkinMinervaNeue' ) ) {
class_alias( 'SkinMinerva', 'SkinMinervaNeue', true );

5
skin.json
View File

@ -544,7 +544,10 @@
"name": "MinervaNeue",
"namemsg": "skinname-minerva",
"requires": {
"MediaWiki": ">= 1.25.0"
"MediaWiki": ">= 1.25.0",
"extensions": {
"MobileFrontend": ">= 2.0.0"
}
},
"type": "skin",
"url": "https://www.mediawiki.org/wiki/Skin:MinervaNeue",