Commit Graph

759 Commits

Author SHA1 Message Date
Moriel Schottlender bf698128f2 Move the 'rcfilters overlay' rule to the RCFilters stylesheet
Depends-On: I8357ef2ff0fe4f46b9ee665ef068624de0afd2e5
Change-Id: Ie36eeddc46c8ea3d154a006fed2fe578be1cd05c
2017-12-22 10:04:15 -08:00
petarpetkovic b0f65a08df Fix detached RCFilters menu
In attempts to fix RCFilters menu overlap with other UI elements when
opening upwards, I1fe6b8b2c9 adds `z-index` rule to overlay element.
But as part of the same rule, `position: relative` is added which
cascades the absolute positioned overlay, causing it to appear in
natural flow of document, which causes menu positioning parameters
to render the menu detached from RCFilters.

Bug: T183442
Change-Id: I3f7db005730d045b2278753cfd655169a96c60a9
2017-12-22 14:07:22 +01:00
jenkins-bot 7c1caddf8f Merge "Inline lists in new print styles should not have a smaller font size than surrounding content" 2017-12-21 02:20:47 +00:00
Rafid Aslam 43b1ed9e18 Add minus-x to "composer test"
Add minus-x to "composer test" and "composer fix"

Bug: T175794
Change-Id: I0a8b67e15f691aa1dad78d28e220cf9d5bcd8b0f
2017-12-20 21:46:11 +07:00
Yifei He 5847c798dd Inline lists in new print styles should not have a smaller font size than surrounding content
Bug: T178667
Change-Id: I2a9bc621db5a09cb5a5653488e0f9dd6c236a773
2017-12-20 02:43:18 +00:00
Translation updater bot e13d71bef3 Localisation updates from https://translatewiki.net.
Change-Id: I205d931db4acc253df813112d7cd0c4367f93e0b
2017-12-18 22:23:18 +01:00
Bartosz Dziewoński d4eabd9d10 Fix z-index for RCFilters' overlay
Currently the personal bar displays on top of it. This wasn't
visible until some popups started opening upwards rather than
downwards. We should fix this better some time...

Bug: T182711
Change-Id: I1fe6b8b2c9c1e4d12a9a4d2d1edd1ead269780cf
2017-12-12 23:53:09 +01:00
Translation updater bot bfdd168413 Localisation updates from https://translatewiki.net.
Change-Id: I1a5cd5feb9421a0f87ee9794c06e226a51f3a60b
2017-12-12 22:25:25 +01:00
jenkins-bot 5268f8edb9 Merge "Fix incorrect indentation of TOC on print preview" 2017-12-12 13:41:23 +00:00
Albert221 4ee212adc4 Fix incorrect indentation of TOC on print preview
Also add the white space that was taken by hiding
.tocnubmer to .toctext

Bug: T179363
Change-Id: I06c502f3d4bee687ed7f300246687aff978ed1d6
2017-12-11 22:26:24 +01:00
Translation updater bot a9bcea2971 Localisation updates from https://translatewiki.net.
Change-Id: I51bb0f8f98c6e4099e08fd009e3e06c8c91bd813
2017-12-10 22:07:12 +01:00
Umherirrender 1c0725da94 Rename file Hooks.php to match class
Change-Id: I59058d580d6b4ced5b7744c46baf074042467df7
2017-12-09 21:32:56 +01:00
Translation updater bot c08bd1fb7a Localisation updates from https://translatewiki.net.
Change-Id: I6226d2ded99db569aa9a9e27ee310966460c54c1
2017-12-05 08:51:48 +01:00
Translation updater bot 6d5f9c0cb1 Localisation updates from https://translatewiki.net.
Change-Id: I94d5d8c0ac604c94afd266961163d344188e908f
2017-11-30 22:47:06 +01:00
Thiemo Mättig d46cb97aeb Fix dysfunctional collapseCondition when right-most tab is the star
The issue I'm fixing here is described at
https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Hard_to_read_titles

The code I'm touching here is from 2014. I believe the issue is not new, but
pops up extremely rarely. Multiple conditions must met:
1. The user must use an extreme zoom (or an extreme font size), or a
   super-narrow browser window. This is also how you should reproduce
   this: make your browser window very narrow, and then start zooming in
   extremely.
2. The issue only appears in namespaces where you can not move pages! This
   is the case for the vast majority of pages on Wikidata and the reason why
   it appears to be a Wikidata-only issue (which it is not). If you can move
   a page, the right-most button is "Move", which is wide enough to be worth
   collapsing, or is already collapsed.

If the right-most (":last") button is the watch star, the code believes it is
not worth collapsing it because the "More" button would consume more space.
This is true, but does not consider the other buttons that can also be
collapsed.

My code considers all collapsible buttons.

Change-Id: I6e94750b3b80940005f4d655e5e9b426d44b2ffb
2017-11-30 18:53:02 +00:00
Translation updater bot 2c29439b30 Localisation updates from https://translatewiki.net.
Change-Id: Ib0720214c9f0104be4ecc5ddb3d107b6b5432424
2017-11-29 22:10:47 +01:00
Ed Sanders e3effd4201 mw.notify: Remove rules duplicated from core
Change-Id: Ibaebea290b2a912fdc9914cfc12d7916a0fe1d18
Depends-On: I157e41631c4a09842b869215b0d6dbb99c1a4d36
2017-11-29 16:01:50 +00:00
Translation updater bot 0db35388d0 Localisation updates from https://translatewiki.net.
Change-Id: I8f737c6a9b2481abb580ed30cbee9480d125c4a0
2017-11-28 22:01:44 +01:00
Translation updater bot e0b37470bb Localisation updates from https://translatewiki.net.
Change-Id: I46cc4784e66cc32bb5bd6b806633433741626e2c
2017-11-27 22:11:40 +01:00
Translation updater bot 4ff9644a70 Localisation updates from https://translatewiki.net.
Change-Id: Ia50ea41772522fcd9111119816a11e177a2b2d79
2017-11-25 22:08:16 +01:00
Translation updater bot af5d639ec1 Localisation updates from https://translatewiki.net.
Change-Id: Ia854c733234d211858dd6e59e364cd8578b1a4ea
2017-11-24 22:30:07 +01:00
Translation updater bot 3283181def Localisation updates from https://translatewiki.net.
Change-Id: I7db354fdc6a2e65b7ba0ac0443867c6927f5c64c
2017-11-23 22:36:11 +01:00
Translation updater bot 19596fc9f5 Localisation updates from https://translatewiki.net.
Change-Id: Iac40afffc4a99ea976f540c6ba66fbf73d5b9227
2017-11-22 22:00:00 +01:00
Fomafix fb79cd46b3 Restore indicator for menuForceShow of tab menus
The previous indicator was removed in 7a42af066b because of a position
transition. The new indicator has no animation.

An indicator is useful to distinguish between the hover and the click
actions.

Change-Id: Icf765d4985aea36e4f4f6653e769aafaf3c30d07
2017-11-19 19:34:15 +01:00
jenkins-bot 56e314ca0c Merge "New VectorAfterToolbox and VectorBeforeFooter hooks" 2017-11-17 21:16:26 +00:00
Translation updater bot cf241dea2a Localisation updates from https://translatewiki.net.
Change-Id: I7037dd754161c0c6684cc90ba1b3bdd94ce005ba
2017-11-16 22:37:05 +01:00
Timo Tijhof 6e8a52a8d2 VectorTemplate: Restore 'id' for siteNotice wrapper
Follows-up bc47b4f.

Change-Id: I4220077679ac6d33650ed82a59696f22f1715485
2017-11-13 21:19:36 -08:00
jenkins-bot 94f8a55767 Merge "VectorTemplate: Refactor literal HTML by using Html methods instead" 2017-11-13 17:37:25 +00:00
jenkins-bot 4e990c081f Merge "Use mw-parser-output for content styles, instead of mw-body-content" 2017-11-13 12:44:04 +00:00
jenkins-bot 068a68bffa Merge "VectorTemplate: Some consistency in mixed PHP/HTML formatting" 2017-11-13 07:35:49 +00:00
Translation updater bot f53efa37eb Localisation updates from https://translatewiki.net.
Change-Id: I0738bcf226617b1719f8ccd49ee64452761f5925
2017-11-12 22:01:44 +01:00
Translation updater bot 3a6ed3e300 Localisation updates from https://translatewiki.net.
Change-Id: Ibbaa491b4f3cffeb3fe72869343088c544b36fa7
2017-11-11 22:00:22 +01:00
Timo Tijhof bc47b4fb3e VectorTemplate: Refactor literal HTML by using Html methods instead
To some degree the literal HTML was (maybe) useful and self-documenting
at some point when the template was really simple, but until and unless
we really use an Html template for this, it's probably a lot easier to
maintain, understand and review (incl. from security perspective) if
we consistently use the Html class abstraction.

For now, I'm only focussing on cases where there is mixed literal HTML
with embedded PHP statements. The cases where HTML is created plain without
embedded PHP I'm leaving untouched for now.

Any case where attribute or content comes from PHP, use the Html class
instead to clearly indicate which values are escaped, and which are not.

Change-Id: Ib2d6425994918b0c17ef29c1b5d0f9893f61a889
2017-11-10 19:37:38 +00:00
Timo Tijhof ae0d9f9f72 VectorTemplate: Some consistency in mixed PHP/HTML formatting
Consistently do the following in this file:
* Consider '<?php' the start of a block indented level, like other code blocks.
* Don't increase indentation between the opening of '<?php' and the top scope
  within, consistent with other PHP files and most of this file.
* Don't manually create tabs or new lines to try to align with the HTML,
  this is a pointless excercise that already doesn't line up anyway. It just
  creates more arbitrary whitespace. Most portlet, personal, sidebar stuff
  is already not doing any indentation, this removes some of the remainder,
  at least in places where it was manually being emulated. The natural stuff
  stays for now.
* Remove some arbitrary line breaks.

Change-Id: I42627ac8473604c7c1309db370302f5ee5f1df0e
2017-11-10 19:27:49 +00:00
Bartosz Dziewoński e4b05ae836 Revert "Fix reversed nav elements when viewing cached HTML"
No longer needed for Wikimedia wikis after the HTML caches expired.
This reverts commit e951a09913.

Change-Id: I5eda153e3368f6a7f9d2f88e336e02b65d01f2b5
2017-11-10 19:17:57 +01:00
Ed Sanders f582645407 Use mw-parser-output for content styles, instead of mw-body-content
Change-Id: Idf0f5f12724d6ce7558102cd4eedc4004e045054
2017-11-10 15:48:18 +00:00
Bartosz Dziewoński ff2f37bc7c Use 'color' to change lightness of "More" menu label rather than 'opacity'
Changing 'opacity' from 1 to other values can cause the browser to use
a different text rendering method, producing unpleasant effects.

We still have to use 'opacity' to change the lightness of the arrow
icon, so move it into an :after pseudoelement.

Bug: T179988
Change-Id: I19c5eafb9ab7e652f2661144abc1e03b381f5ff4
2017-11-07 23:37:46 +01:00
Volker E 29c515ae3f Align VectorMenu items and unify `padding` with tabs
Aligning VectorMenu items horizontally with menu handle and
set `padding` consistently to `8px` – taking into account
different `font-size`.
Also removing unnecessary duplication of `margin-top` as `margin`
is set in same rule.

Bug: T179782
Change-Id: I30e9b4e50589ef09a0e5dcb0e6c4486e7779a39d
2017-11-07 20:46:33 +00:00
Translation updater bot 0677fc17d4 Localisation updates from https://translatewiki.net.
Change-Id: If769a8bb0cac8db88ed406bd02304e1759fe64c7
2017-11-04 22:07:46 +01:00
jenkins-bot 1582f981ec Merge "Print styles in Vector are no longer feature flagged" 2017-11-03 23:36:02 +00:00
Translation updater bot cc2a9c8870 Localisation updates from https://translatewiki.net.
Change-Id: I17d7753a682f9216e4d1352be0513fd3bd6cbe5c
2017-11-03 21:58:51 +01:00
jdlrobson c863b94302 Print styles in Vector are no longer feature flagged
Remove feature flagging of print styles

Changes:
* Merge experimental module into skins.vector.styles
* Update skins.vector.styles RL class to support LESS variable
* Remove feature flag class in HTML and LESS (update indents in
LESS file)

Bug: T178028
Change-Id: I8d5c59c5c9f415ffbd7fa41a512cbea87887e9e7
2017-11-02 11:04:58 -07:00
Translation updater bot 1ed289f520 Localisation updates from https://translatewiki.net.
Change-Id: Ib6655db681bfa6aa34d66bc2715d5dde74be1f9f
2017-10-31 21:59:35 +01:00
Volker E f769c088b9 Optimize SVGs and align to WikimediaUI color palette
Optimize and unify markup of SVGs and align to
WikimediaUI color palette where easily applicable.
Also removing three unused image files.

Bug: T153043
Bug: T178867
Change-Id: Ied457ef84357374e66db9e1936ce1b754d53cfdb
2017-10-24 01:18:07 -07:00
Translation updater bot 3717ca9a6c Localisation updates from https://translatewiki.net.
Change-Id: I2e582de41e1f0b1cd1628cf4778494316bc81f8b
2017-10-23 22:27:20 +02:00
Translation updater bot adcac3ad70 Localisation updates from https://translatewiki.net.
Change-Id: I3786591774ddf31c76dc9f8f7ece5fa2c7c4c362
2017-10-22 00:16:53 +02:00
libraryupgrader 0317d33fb4 build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I234f4396d7ab0408179b2cf873749b5aabb88a28
2017-10-21 04:35:15 +00:00
jdlrobson 65b6ba3fbf Clear any floats before the print footer
Bug: T178656
Change-Id: I6291e8ac53240e4e2f1899213a516d27dba95bd5
2017-10-20 13:21:58 -07:00
Translation updater bot c3e8b0ea4d Localisation updates from https://translatewiki.net.
Change-Id: I13aa4a491054fccdb7f7fde67129cc91dbd8ff16
2017-10-20 22:01:51 +02:00
Volker E e2c9a585e4 Bring menu tab appearance closer to standard widgets
Bringing appearance and behaviour closer to standard widget like
DropdownWidget:
- Amending color to be (closest) aligned to WikimediaUI color
  palette, but switch normal and `:hover`/`:focus` state in order not
  to be too disruptive of a change and align with rest of Vector tabs,
- removing obsolete JS functionality as IE 6 as only major browser
  affected does receive the menu items as tabs nonetheless and replacing
  with simple CSS selector,
- removing unnecessary and obsolete images and
- Lessifying selector

Bug: T153043
Change-Id: Ia15480162bb8f923d0e9b6e42ca90c2c880978de
2017-10-19 23:24:15 +00:00