Commit Graph

36 Commits

Author SHA1 Message Date
Volker E f29a1eba0a Unify LESS variable naming scheme for `@border-*` variables
Unifying variable naming to property-identifier-modifier scheme and
use already existing variables out of mediawiki.ui variables file,
which gets imported by Vector and its variables (like
`@border-width-base`) are already in use in a few places.

Change-Id: Ic25b1517bf180a9bce437215c1309bb9f4dd15be
2019-09-28 00:35:16 -07:00
Volker E 62560debb9 Unify LESS variable naming scheme for `@margin-*`/`@padding-*` variables
Unifying variable naming to property-identifier-modifier scheme.
Also removing `@padding` variable with only one single usage, instead of
extracting it from its place of application enable simpler readability.

Change-Id: I602fe645b233000bcecaeee6cf19d20e49a64c78
2019-09-27 23:24:34 -07:00
Volker E 0a2aa9f683 Unify heading font size variable naming
Follow-up to I378e8a2af91fe079

Change-Id: Ib1affae440f23e7d9b648ce4b8b85cf2d3a2e1d2
2019-09-27 22:45:01 -07:00
Volker E 83fbe68b5f Unify LESS variable naming scheme for `@line-height-*` variables
Unifying variable naming to property-identifier-modifier scheme.
Settling on non-em-based `line-height` values with one exception
of Vector tabs, where removing `em` would lead to different
calculation.
Also removing unneeded `inherit` assignment on content paragraphs
that has been part since Ic5ba836364.

Bug: T4013
Change-Id: I514467e4065d27de8d0ea82cdd3d23ccef6cffe3
2019-09-27 21:41:23 -07:00
Timo Tijhof 9cf7901ec9 Remove @embed page load delays (and misc optimisations)
* page-fade:
  Remove redundant 'background-image' PNG fallback for
  IE6-8 in '#mw-page-base' because the vertical-gradient() already
  creates a solid fallback color which seems good enough for IE6-8.

  Remove the 'background-color' rule which was only there to fill
  the gap above the the IE6-8 PNG image fallback, which in turn
  overrode the background-color rule from vertical-gradient.
  The background-repeat rule is also redundant with background-image
  gone.

* watch-icon-loading:
  This is only used when the JS code is active and the user
  clicks the watch star. It does not need a PNG fallback, as it
  is only needed in Grade A browsers where the JS executes,
  which are expected to support SVG.
  Also removed the embedding as the rendering of article text
  on page load should not be delayed by an icon that might
  be used if and when the user clicks on the watchstar (and
  irrelevant to logged-out users).

Bug: T121730
Change-Id: Ief4b80432fbe2ce7ebddf429f02c161048ed61d1
2019-09-27 18:03:25 +01:00
Volker E 9055676640 Unify LESS variable naming scheme for `@font-size-*` variables
Unifying variable naming to property-identifier-modifier scheme, while
also collecting all non-print values variables in corresponding file.
We will amend the `em` based values to calculations that will enable
rendered full pixel values and also fix some connected
usability issues in the future.

Change-Id: I378e8a2af91fe0790708e6fb2d2e7a5718ce93c5
2019-09-26 18:53:00 -07:00
Volker E 258fdde8bf Update LESS variable naming scheme for `@font-family*` variables
Reyling only on base font family variables. It's debatable if
something like `@font-family-base` would make sense, but with only
3 variables the abstraction would seem over-engineered for the time being.

Change-Id: I294ef8753dd3c73f4ed3fd89d43978dfaf6e0f06
2019-09-26 15:54:46 -07:00
Volker E 66aaf36bf6 Align LESS color variables to naming scheme, combine and cleanup
Merging similar value applications in generalized variables,
and aligning to property-identifier-modifier scheme.

Change-Id: I274ef24140a36e285c67b33a41ab6afe7c98676b
2019-09-26 15:39:25 -07:00
Volker E 484077de01 Increase distance of button to container
Increasing the distance of the button slightly changes the position
from end, putting the icon in a more appropriate place (harmonized
whitespace of input value and icon).
Also simplifying `font-size` calculations readability and equalling
their values in search input and button.

Bug: T225331
Change-Id: I57f7efc61f3b770d7470d820402e2ea533364238
2019-09-26 12:15:38 -07:00
Isarra 411a015ec5 Move DataAfterContent outside of main content block
Bug: T226199
Change-Id: Ie04d8d2bb1d44ec8a1c03fcc6f807668bab0377c
2019-06-20 17:55:55 +00:00
Volker E 835bfa785f Update list bullet icon
Removing IE 6-8 fallback treatment and only provide SVG as
`list-style-image`. Also updating SVG fill color to use
text color.

Bug: T220327
Bug: T220328
Change-Id: I50ed85e420d6158e9ace5d879b6cf218a6a591b9
2019-04-07 23:08:38 -07:00
Volker E ec6b201456 Remove re-definition of default `list-style-type` value
Bug: T220317
Change-Id: I5bc0668011ee0ae553391888de35208acb8105b3
2019-04-07 17:42:39 -07:00
Volker E 0e089a0d4c build: Update 'stylelint-config-wikimedia' and make pass
Change-Id: I147ea18307c58c5091c5ad79585b5acec9d46235
2018-12-02 14:40:28 -08:00
Volker E 186db29808 Don't crop Burmese language headers
Burmese (Myanmar) language headers get cropped with currently applied
`line-height` setting. Resetting it fixes this.

Bug: T193270
Change-Id: I81c6c1ac9148c122432506be0c1b35f648214d6c
2018-05-24 13:01:05 +02:00
Volker E 0f7a56e95c Remove IE 6 specific code
Removing further CSS for Internet Explorer 6.
Follow-up to I0f98c61cf9108c0a91769e9b7044023b01f974ed.

Change-Id: I85a7570c97f9b618a7946dc20367b54e72d31b3e
2018-05-24 02:17:30 +02:00
Volker E 8e79fee078 Replace `#toc` selector by `.toc`
Replacing id CSS selector by lower specific class selector.

Bug: T187808
Depends-on: I7f3a9df7f9fd1178986112b5265b1ae7c991d5b7
Change-Id: If8768278750d49e70a29d993e759f246082fefb0
2018-03-29 00:40:36 +00:00
Jack Phoenix d575e3878a Optimization: move styles specific to redirect pages out of common.less
HT MatmaRex

Change-Id: I6169692547378379dbc935976ad83cf4f366eeeb
2017-06-15 16:13:42 +03:00
Arlo Breault dcd01fc1e2 Separate some shared layout with Parsoid
* This is in service of T116508.  See
   Id41c1d2840f441eddb14ca66ba545ee7b160088e where .mw-body is being
   removed from Parsoid content.

 * This is only possible since T155863

Change-Id: I60e3cb3e838fa19d321c4eac0a6828bcfddb6f3e
2017-04-17 14:14:36 -04:00
Ed Sanders d183c39d06 Allow edit sections outside of mw-body-content
Bug: T160269
Change-Id: Ib4830cde634b6ca0c3ceb0ba06831c3b4ccedfbd
2017-03-12 11:14:37 +00:00
Ed Sanders 24802a3aaf Move heading, paragraph and editsection styles into mw-body-content
Bug: T155863
Bug: T155774
Change-Id: I4c907bd48d472c970b79a7a234c2079254567a7e
2017-03-07 17:52:23 +00:00
Ed Sanders f7d8d036ac build: stylelint more files
Change-Id: If62fa6ff9810de253b65feb1f7e312d22e33bfa8
2017-01-23 15:04:05 +00:00
nirzar 211660e6b0 Allow an alternate, generic header font to be specified for certain languages
Introducing variable `@content-heading-font-family-generic`, that may be
used to specify an alternate font for `h1` and `h2` for languages which
render poorly using the standard heading font stack.
Set it for now on JA, HE and KO languages, based on reported issues.

Bug: T73240
Change-Id: I5217a7947427055f4cb61185d9d7d79848605dd3
2016-07-06 12:30:04 +02:00
Derk-Jan Hartman 3ca33440f4 .redirectMsg needs to be 0 height
It wasn't because ".mw-body p" introduces a margin, causing an
undesired extra spacing on redirect pages.

Change-Id: I53f63703b086ff6b28c1fb5325ee6693e3322390
2016-01-26 20:12:40 +01:00
Volker E 171fbc1512 Removing obsolete `-moz-inline-block` property
Bug: T103605
Change-Id: I97787abc8683f34db3f2063434578ecfdb019ecb
2015-06-24 21:16:53 +01:00
Erwin Dokter 35ca341ed4 Minor header fixes for Typography Refresh
This fixes top-margin for H1 inside .mw-body-content, and increase
font-size for H3 from 1.17em to 1.2em (bumping to 17px default).

Final patch for this bug.

Bug: T66653
Change-Id: I1e75bc4fc3e04ca6c9238d4ce116136e9bafacd1
2015-05-23 12:07:14 +00:00
paladox eea9966d5c Add SVG version of bullet-icon and use .list-style-image-svg()
* Adds bullet-image.svg

* Depends on I09319e9188878c in MediaWiki core

Edokter idea.

Bug: T37338
Change-Id: If380fcca663859d1bb688bb621c267b815b3e21a
2015-02-12 23:00:10 +00:00
Bartosz Dziewoński 32eaf1b209 Revert "Add svg image of bullet"
Turns out this doesn't actually work well. Who'd have thunk?

This reverts commit a6235ceb88.

Bug: T37338
Change-Id: I3dcb8e8453a110d2b631711057712ac858dc42c1
2015-01-19 09:51:27 +00:00
paladox a6235ceb88 Add svg image of bullet
* Adds svg version of bullet.
* It has a hack in css so that png will be targeted at ie 8 or lower.
* There was no way around it since list-style-image carnt be used twice. The hack adds \9 to end of png file.

Edokter suggested to use \9

Note this has been tested

Bug: T37338
Change-Id: I795c31a68c383b8fc4557ee00312a5b1aecd09a3
2015-01-11 17:27:13 +00:00
Fomafix df10f03a7a Give .mw-body-content its own stacking context (z-index: 0)
This avoids that elements in the content can overlap elements
outside the content area (e.g. software and skin interface components),
such as the page action menu.

Bug: T40848
Change-Id: Ia986434c51d8db738726f3a4e918bce373bd3d6b
2014-12-07 20:26:54 +00:00
jenkins-bot 8437d301e8 Merge "Add support for page status indicators" 2014-10-27 20:23:28 +00:00
Bartosz Dziewoński cb1eb7ab2d common.less: Remove dead code
This does nothing since 7dc4b5861589f2cef472195273c41a86083f69d4 in core.

Change-Id: I879d96fe8d4034b6365c6b6af3d9e3615dd1c506
2014-09-30 14:40:49 +02:00
Bartosz Dziewoński deac602863 Add support for page status indicators
Corresponding patch in core: I2389ff9a5332a2b1d033eb75f0946e5241cfaaf4.

Bug: 23796
Change-Id: I90a8ae15ac8275d084ea5f47b6b2684d5e6c7412
2014-09-30 14:37:35 +02:00
Bartosz Dziewoński c85c4ee1ae Revert "Add svg version of bullet-icon"
The generated CSS is invalid, as you can't have multiple
list-style-images (unlike background-images). Browsers
either ignore the invalid properties with linear-gradient
and use non-embedded PNG fallback (Chrome, Firefox, modern
IE), or accept the properties but ignore everything after
the comma, using the fully transparent gradient (Opera). 

This reverts commit 32e65050a6.

Change-Id: I46abf1502c1e4e3dfe03f0c17c553b9fe7fe007d
2014-09-13 13:10:56 +00:00
paladox 32e65050a6 Add svg version of bullet-icon
* This add support for bullet in svg.

Note: This requires Iffff2bc52e1572e661930242ad15937bc83abace to be
approved

Note: This has been tested by me.

Change-Id: I5196952088e584d3121600e9e829647e8c195bbb
2014-09-12 23:27:55 +00:00
Arlo Breault b1c2dd38ba Use .mw-body instead of div#content
* Part of https://gerrit.wikimedia.org/r/#/c/151395/

Change-Id: Iae873906abcd8b2a986e5f728f0ce207256de770
2014-08-13 03:52:51 -07:00
Bartosz Dziewoński d28f09df31 Move Vector skin from core
This is the final step of the process described at
<https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>.

Corresponding core change: Idfc38503.

Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 13:38:34 +02:00