golem
/
VectorGOLEM
9
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity

Unify LESS variable naming scheme for `@margin-*`/`@padding-*` variables 

Unifying variable naming to property-identifier-modifier scheme.
Also removing `@padding` variable with only one single usage, instead of
extracting it from its place of application enable simpler readability.

Change-Id: I602fe645b233000bcecaeee6cf19d20e49a64c78
This commit is contained in:
Volker E 2019-09-27 23:24:34 -07:00
parent 0a2aa9f683
commit 62560debb9
3 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
components/common.less
View File

@ -27,7 +27,7 @@ body {
.parsoid-body {
background-color: @background-color-base;
color: @color-base;
padding: @content-padding;
padding: @padding-content;
direction: ltr;
}

8
components/navigation.less
View File

@ -84,7 +84,7 @@
h3 {
color: @menu-main-heading-color;
font-weight: normal;
margin: 0.5em 0 0 ( @menu-main-body-margin-left / @font-size-menu-main-heading );
margin: 0.5em 0 0 ( @margin-left-menu-main-body / @font-size-menu-main-heading );
padding: 0.25em 0;
cursor: default;
border: 0;
@ -92,7 +92,7 @@
}
.body {
margin-left: @menu-main-body-margin-left;
margin-left: @margin-left-menu-main-body;
padding-top: 0;
background-image: url( images/portal-break.png );
background-repeat: no-repeat;
@ -100,7 +100,7 @@
ul {
list-style: none none;
margin: 0;
padding: @menu-main-body-padding;
padding-top: 0.3em;
}
li {
@ -132,7 +132,7 @@
.body {
background-image: none;
margin-left: @menu-main-body-margin-left;
margin-left: @margin-left-menu-main-body;
}
}
}

5
variables.less
View File

@ -31,7 +31,7 @@
// FIXME: Use global variable since Echo and CentralNotice use this variable
@content-border-color: #a7d7f9;
@content-line-height: 1.6;
@content-padding: 1em;
@padding-content: 1em;
// Navigation
@background-color-secondary: #f6f6f6;
@ -45,8 +45,7 @@
@menu-main-heading-color: #444;
@font-size-menu-main-body: unit( 12 / @font-size-browser, em );
@menu-main-body-margin-left: 0.5em;
@menu-main-body-padding: 0.3em 0 0 0;
@margin-left-menu-main-body: 0.5em;
// Personal menu
@background-position-menu-personal-icon: left ( 4 / @font-size-browser / @font-size-menu-personal );