golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix notifications always appearing as unseen 

After Ie92b223a48 removed $flags parameter from EchoSeenTime::getTime(),
we got 0 as $format passed to the method, which caused mismatch in
timestamp string formats when comparing to $notifLastUnreadTime timestamp,
which caused notifications to appear always as unseen (although that's
unpredictable, because of wrong format used).

Bug: T183076
Change-Id: Ia4ff0bc4c3b7ed80b5a22a9ca0052f1909469180
This commit is contained in:
petarpetkovic 2018-01-03 18:07:25 +01:00
parent 8466feb591
commit c8195e37ef
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
includes/skins/SkinMinerva.php
View File

@ -351,7 +351,7 @@ class SkinMinerva extends SkinTemplate implements ICustomizableSkin {
* @return string|bool Timestamp in TS_ISO_8601 format, or false if no stored time
*/
protected function getEchoSeenTime( User $user ) {
return EchoSeenTime::newFromUser( $user )->getTime( 'all', /*flags*/ 0, TS_ISO_8601 );
return EchoSeenTime::newFromUser( $user )->getTime( 'all', TS_ISO_8601 );
}
/**