From c8195e37ef2495e853cd5ff2a0665cc99af12d7a Mon Sep 17 00:00:00 2001 From: petarpetkovic Date: Wed, 3 Jan 2018 18:07:25 +0100 Subject: [PATCH] Fix notifications always appearing as unseen After Ie92b223a48 removed $flags parameter from EchoSeenTime::getTime(), we got 0 as $format passed to the method, which caused mismatch in timestamp string formats when comparing to $notifLastUnreadTime timestamp, which caused notifications to appear always as unseen (although that's unpredictable, because of wrong format used). Bug: T183076 Change-Id: Ia4ff0bc4c3b7ed80b5a22a9ca0052f1909469180 --- includes/skins/SkinMinerva.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 439d47c..b0fc312 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -351,7 +351,7 @@ class SkinMinerva extends SkinTemplate implements ICustomizableSkin { * @return string|bool Timestamp in TS_ISO_8601 format, or false if no stored time */ protected function getEchoSeenTime( User $user ) { - return EchoSeenTime::newFromUser( $user )->getTime( 'all', /*flags*/ 0, TS_ISO_8601 ); + return EchoSeenTime::newFromUser( $user )->getTime( 'all', TS_ISO_8601 ); } /**