golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "QA: Remove hacks introduced for T170890"

This commit is contained in:
jenkins-bot 2018-11-23 19:08:05 +00:00 committed by Gerrit Code Review
parent dd3d603e54 0638296fb3
commit bce934c54d
3 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/browser/features/pageactions_protected.feature
View File

@ -1,4 +1,4 @@
@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @adminuser
@chrome @en.m.wikipedia.beta.wmflabs.org @adminuser
Feature: Page actions menu when anonymous
Background:

8
tests/browser/features/step_definitions/common_article_steps.rb
View File

@ -27,13 +27,7 @@ When(/^I click the watch star$/) do
end
Then(/^I should see a toast notification$/) do
# To avoid flakey tests check the notification area element first (T170890)
on(ArticlePage) do |page|
# Minerva loads mediawiki.notify at startup which defers the loading of this module
# We must wait until the lazy loading has happened before checking for the toast (T170890)
page.wait_until_rl_module_ready('mediawiki.notification')
expect(page.notification_area_element.when_present).to be_visible
end
expect(on(ArticlePage).notification_area_element.when_present).to be_visible
end
Then(/^I should see a toast with message "(.+)"$/) do |msg|

2
tests/browser/features/watchstar.feature
View File

@ -1,4 +1,4 @@
@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @integration @smoke @test2.m.wikipedia.org @login @vagrant
@chrome @en.m.wikipedia.beta.wmflabs.org @integration @smoke @test2.m.wikipedia.org @login @vagrant
Feature: Manage Watchlist
Background: