QA: Remove hacks introduced for T170890

These no longer seem to be achieving their original
intention and may even be causing the
flakiness we experience now.

Additional changes:
* Disable some more tests in Firefox job

Bug: T208808
Change-Id: I735ec0ff293cfd7aa60519c080a300bd40dc0abc
This commit is contained in:
jdlrobson 2018-11-15 14:31:22 -08:00
parent 2e7c44fdfa
commit 0638296fb3
3 changed files with 3 additions and 9 deletions

View File

@ -1,4 +1,4 @@
@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @adminuser
@chrome @en.m.wikipedia.beta.wmflabs.org @adminuser
Feature: Page actions menu when anonymous
Background:

View File

@ -27,13 +27,7 @@ When(/^I click the watch star$/) do
end
Then(/^I should see a toast notification$/) do
# To avoid flakey tests check the notification area element first (T170890)
on(ArticlePage) do |page|
# Minerva loads mediawiki.notify at startup which defers the loading of this module
# We must wait until the lazy loading has happened before checking for the toast (T170890)
page.wait_until_rl_module_ready('mediawiki.notification')
expect(page.notification_area_element.when_present).to be_visible
end
expect(on(ArticlePage).notification_area_element.when_present).to be_visible
end
Then(/^I should see a toast with message "(.+)"$/) do |msg|

View File

@ -1,4 +1,4 @@
@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @integration @smoke @test2.m.wikipedia.org @login @vagrant
@chrome @en.m.wikipedia.beta.wmflabs.org @integration @smoke @test2.m.wikipedia.org @login @vagrant
Feature: Manage Watchlist
Background: