golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use getSingleton in OverlayManager tests 

Simplifies the tests by making sure they don't need to know
about how OverlayManagers are created.
Change-Id: I38174d1c2d32290d2b1fde4340a85e362e5c102b
This commit is contained in:
jdlrobson 2019-03-18 15:04:54 -07:00 committed by Jdlrobson
parent 88dd2530e7
commit 71f6e5519a
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/qunit/skins.minerva.notifications.badge/NotificationBadge.test.js
View File

@ -4,8 +4,7 @@
QUnit.module( 'Minerva NotificationBadge', {
beforeEach: function () {
this.router = require( 'mediawiki.router' );
this.OverlayManager = new OverlayManager( this.router );
this.OverlayManager = OverlayManager.getSingleton();
}
} );

2
tests/qunit/skins.minerva.scripts/pageIssues.test.js
View File

@ -5,7 +5,7 @@
insertBannersOrNotice = pageIssues.test.insertBannersOrNotice,
OverlayManager = mobile.OverlayManager,
Page = mobile.Page,
overlayManager = new OverlayManager( require( 'mediawiki.router' ) ),
overlayManager = OverlayManager.getSingleton(),
$mockContainer = $(
'<div id=\'bodyContent\'>' +
'<table class=\'ambox ambox-content\'>' +