From 71f6e5519ab374e896b7ad4e7b51c6cbb4caf560 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Mon, 18 Mar 2019 15:04:54 -0700 Subject: [PATCH] Use getSingleton in OverlayManager tests Simplifies the tests by making sure they don't need to know about how OverlayManagers are created. Change-Id: I38174d1c2d32290d2b1fde4340a85e362e5c102b --- .../NotificationBadge.test.js | 3 +-- tests/qunit/skins.minerva.scripts/pageIssues.test.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/qunit/skins.minerva.notifications.badge/NotificationBadge.test.js b/tests/qunit/skins.minerva.notifications.badge/NotificationBadge.test.js index bcc067a..e9fbd52 100644 --- a/tests/qunit/skins.minerva.notifications.badge/NotificationBadge.test.js +++ b/tests/qunit/skins.minerva.notifications.badge/NotificationBadge.test.js @@ -4,8 +4,7 @@ QUnit.module( 'Minerva NotificationBadge', { beforeEach: function () { - this.router = require( 'mediawiki.router' ); - this.OverlayManager = new OverlayManager( this.router ); + this.OverlayManager = OverlayManager.getSingleton(); } } ); diff --git a/tests/qunit/skins.minerva.scripts/pageIssues.test.js b/tests/qunit/skins.minerva.scripts/pageIssues.test.js index 0622715..34f0ffb 100644 --- a/tests/qunit/skins.minerva.scripts/pageIssues.test.js +++ b/tests/qunit/skins.minerva.scripts/pageIssues.test.js @@ -5,7 +5,7 @@ insertBannersOrNotice = pageIssues.test.insertBannersOrNotice, OverlayManager = mobile.OverlayManager, Page = mobile.Page, - overlayManager = new OverlayManager( require( 'mediawiki.router' ) ), + overlayManager = OverlayManager.getSingleton(), $mockContainer = $( '
' + '' +