golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Force type Language for $lang of doEditSectionLink 

Also make the parameter $tooltip mandatory to ensure that a mandatory
parameter does follow an optional parameter. ParserOutput always fill
all parameters of doEditSectionLink.

Bug: T207413
Depends-On: Ic49d76c7d9357f99b462471696f7e1eb86e70e3d
Change-Id: I49c1e3fb7bf72002c7f498d4afe14a06caf411f8
This commit is contained in:
Fomafix 2018-07-23 22:12:42 +02:00
parent 11d6b26093
commit 133e806865
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
includes/skins/SkinMinerva.php
View File

@ -266,10 +266,10 @@ class SkinMinerva extends SkinTemplate {
* @param Title $nt * @param Title $nt
* @param string $section * @param string $section
* @param string|null $tooltip * @param string|null $tooltip
* @param string|bool $lang * @param Language $lang
* @return string * @return string
*/ */
public function doEditSectionLink( Title $nt, $section, $tooltip = null, $lang = false ) { public function doEditSectionLink( Title $nt, $section, $tooltip, Language $lang ) {
if ( $this->isAllowedPageAction( 'edit' ) ) { if ( $this->isAllowedPageAction( 'edit' ) ) {
$message = $this->msg( 'mobile-frontend-editor-edit' )->inLanguage( $lang )->text(); $message = $this->msg( 'mobile-frontend-editor-edit' )->inLanguage( $lang )->text();
$html = Html::openElement( 'span', [ 'class' => 'mw-editsection' ] ); $html = Html::openElement( 'span', [ 'class' => 'mw-editsection' ] );