From 133e806865f0d0254589b1141965928aca519b08 Mon Sep 17 00:00:00 2001 From: Fomafix Date: Mon, 23 Jul 2018 22:12:42 +0200 Subject: [PATCH] Force type Language for $lang of doEditSectionLink Also make the parameter $tooltip mandatory to ensure that a mandatory parameter does follow an optional parameter. ParserOutput always fill all parameters of doEditSectionLink. Bug: T207413 Depends-On: Ic49d76c7d9357f99b462471696f7e1eb86e70e3d Change-Id: I49c1e3fb7bf72002c7f498d4afe14a06caf411f8 --- includes/skins/SkinMinerva.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 207ac24..9f21c02 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -266,10 +266,10 @@ class SkinMinerva extends SkinTemplate { * @param Title $nt * @param string $section * @param string|null $tooltip - * @param string|bool $lang + * @param Language $lang * @return string */ - public function doEditSectionLink( Title $nt, $section, $tooltip = null, $lang = false ) { + public function doEditSectionLink( Title $nt, $section, $tooltip, Language $lang ) { if ( $this->isAllowedPageAction( 'edit' ) ) { $message = $this->msg( 'mobile-frontend-editor-edit' )->inLanguage( $lang )->text(); $html = Html::openElement( 'span', [ 'class' => 'mw-editsection' ] );