giomba/opensc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
7,826 Commits 1 Branch 30 Tags 20 MiB
9f2c112ecb
Commit Graph

7826 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Raul Metsma
4ba086bfd4 Use strdup and fix all casts 
Signed-off-by: Raul Metsma <raul@metsma.ee>
 2019-04-01 12:53:33 +02:00
Martin Paljak
ea74308512 iso7816_read_binary: do not assume that 6282 is returned with data 
Instead of a double check_sw call in case there is no data, assume
that a SW is properly sent by the card and do not expose
SC_ERROR_FILE_END_REACHED outside of the function
(like sc_pkcs15_read_file)

This is to facilitate Estonian eID 2018+ that instead of properly returning
6282 with trunkated data, 9000 is returned and next READ BINARY returns
6b00 (invalid p1/p2). The change should be generally harmless for well-behaving
cards.

Change-Id: I7511ab4841d3bcdf8d6f4a37a9315ea4ac569b10
 2019-04-01 12:51:00 +02:00
Peter Popovec
f070c99b65 opensc-tool: do not use card driver to read ATR 
If card driver fails to connect to card, 'opensc-tool -a' may fail to print
ATR even if ATR is available from card reader.  Before use of card driver,
do only card reader connect, then print ATR.  Only if it is neccesary, use
card driver for the rest of opensc-tool functions.
 2019-03-25 14:34:26 +01:00
Frank Morgner
b389b19ca5
Merge pull request #1633 from metsma/esteid 
Only EstEID 3.5 has EC 384 keys
 2019-03-25 14:31:02 +01:00
Frank Morgner
2f4df1b93e tools: unified handling of gengetopt 2019-03-25 14:30:09 +01:00
Frank Morgner
fc9277b778 use compat_getopt_long if getopt_long is not available 
uses the autoconf way for replacing getopt.h

fixes https://github.com/OpenSC/OpenSC/issues/1527
 2019-03-25 14:30:09 +01:00
Raul Metsma
7ae54f490d Remove dead code (#1638) 2019-03-25 14:28:53 +01:00
Frank Morgner
8dea0a9028 fix overlapping memcpy 
Fixes https://github.com/OpenSC/OpenSC/issues/1631
 2019-03-18 23:33:24 +01:00
Frank Morgner
6aa5410e73 goid-tool: live with short length APDUs 2019-03-18 13:59:11 +01:00
Raul Metsma
4d2254a092 Only EstEID 3.5 has EC 384 keys 
Signed-off-by: Raul Metsma <raul@metsma.ee>
 2019-03-13 23:01:07 +02:00
Frank Morgner
2e87e4cfed fixed issues from review 2019-03-13 21:22:19 +01:00
Frank Morgner
b7ec7f95b1 pkcs11: fixed token label 2019-03-13 21:22:19 +01:00
Frank Morgner
0079d836f3 pkcs11: truncate oversized labels with '...' 2019-03-13 21:22:19 +01:00
Raul Metsma
1e6d3df201 Remove un-lincenced header file 
Signed-off-by: Raul Metsma <raul@metsma.ee>
 2019-03-13 21:19:26 +01:00
Frank Morgner
71b85d15e4 opensc.conf: Configure handling of private_certificate 
possible choices: ignore, protect, declassify

fixes https://github.com/OpenSC/OpenSC/issues/1430
 2019-03-13 21:18:57 +01:00
Frank Morgner
1e0743b29f removed untested use of SC_SEC_OPERATION_AUTHENTICATE 
fixes https://github.com/OpenSC/OpenSC/issues/1271
 2019-03-13 21:17:54 +01:00
Frank Morgner
106b3a28b1 acos5: removed incomplete driver 
fixes https://github.com/OpenSC/OpenSC/issues/1204
 2019-03-13 21:17:54 +01:00
Frank Morgner
9fa1722f73 sc_bin_to_hex returns a Nul terminated string 2019-03-13 21:17:00 +01:00
Frank Morgner
eb8f28db20 fixed error handling 2019-03-13 21:17:00 +01:00
Frank Morgner
d4f1decd15 Make sure card's strings are Nul terminated 
Avoids out of bounds reads when using internal operations with the given string
 2019-03-13 21:17:00 +01:00
Frank Morgner
d953998aa3 npa-tool: force default card driver 2019-03-13 12:01:09 +01:00
alegon01
31831c300b Remove the call to OPENSSL_init_crypto() which is not needed. I have a segmentation fault when the process exits. 2019-03-12 08:52:06 +01:00
Raul Metsma
f341b758e6 Add installer option to deselect tokend 
Signed-off-by: Raul Metsma <raul@metsma.ee>
 2019-03-11 23:22:11 +01:00
Frank Morgner
6472027848 tools: release context when card connection fails 2019-03-07 22:18:54 +02:00
Pierre Ossman
bc4eeda573 Remove readers when smart card service stops 
The code already removes all active cards when the service goes
away, but it doesn't remove the reader. This can be a bit confusing
since they will still be polled and listed.
 2019-03-07 21:51:02 +02:00
Pierre Ossman
9ed5f63c17 Fix smart card removal handling for older PC/SC 
Older PC/SC doesn't have the code SCARD_E_NO_READERS_AVAILABLE, so fix
the code to handle such systems as well.
 2019-03-07 21:51:02 +02:00
Pierre Ossman
9e9bdac2f1 Handle reader going missing 
It might just be this specific reader going missing, and not all
of them.
 2019-03-07 21:51:02 +02:00
Raul Metsma
b227fb8b9f Cleanup EstEID 1.0/1.1 lefovers 
Signed-off-by: Raul Metsma <raul@metsma.ee>
 2019-03-07 21:31:08 +02:00
Scott Gayou
0d79675497 Small memory leak fix (CVE-2019-6502 in #1586) 
CVE-2019-6502 was assigned to what appears to be a very minor
memory leak that only occurs on an error-case in a CLI tool.
If util_connect_card fails, we still need to release the sc
context previously allocated by sc_context_create else memory
will leak.
 2019-03-06 19:51:43 +01:00
alegon01
728d099a53 FIX typo OpenSSL vs OpenSsl. 2019-03-06 11:35:11 +01:00
alegon01
b327b76134 FIX use pseudo_randomize() for a proper initialization of orig_data in encrypt_decrypt(). 2019-03-06 10:26:05 +01:00
Frank Morgner
19c5ab315d fixed uninitialized use of variable 2019-03-06 08:53:47 +01:00
Frank Morgner
070370895f fixed 333707 Dereference before null check 2019-03-06 00:42:38 +01:00
Frank Morgner
8fbd0b3ee1 fixed 333708 Dereference after null check 2019-03-06 00:42:38 +01:00
Frank Morgner
ba185954c5 fixed 333709 Unchecked return value 2019-03-06 00:42:38 +01:00
Frank Morgner
e8f8f0bfbb fixed 333714 Uninitialized scalar variable 2019-03-06 00:42:38 +01:00
Frank Morgner
9abe44f03c fixed 333715 Dereference after null check 2019-03-06 00:42:38 +01:00
Frank Morgner
e876cf62eb fixed 333711 Dereference before null check 2019-03-06 00:42:38 +01:00
Frank Morgner
b1a58c7925 removed dead code 2019-03-06 00:42:38 +01:00
Frank Morgner
27526de021 implemented sc_format_apdu_ex 2019-03-05 13:54:13 +01:00
Frank Morgner
155b197932 sc-hsm: require T=1 connection 2019-03-05 13:47:45 +01:00
Frank Morgner
f3e6639de6 added GoID CVCA 2019-03-05 13:17:15 +01:00
alegon01
7271fe610b Add support for the OpenSsl signature format for the signature verification. 2019-02-18 16:03:41 +01:00
Frank Morgner
20daced605 fixed special case of deletion in gnuk_write_certificate 2019-02-14 09:22:23 +01:00
Frank Morgner
1a61ae849f fixed Null pointer argument in call to memcpy 2019-02-14 09:22:23 +01:00
Frank Morgner
b6fadb469f fixed sc_decompress_zlib_alloc return code 2019-02-14 09:22:23 +01:00
Frank Morgner
6e48de83c7 avoid allocation of 0 bytes 2019-02-14 09:22:23 +01:00
Frank Morgner
f4fccfd94e fixed undefined bitshift 2019-02-14 09:22:23 +01:00
Frank Morgner
c858d4b3d1 fixed argument checking 2019-02-14 09:22:23 +01:00
Frank Morgner
6fdb29a470 fixed use of uninitialized values 2019-02-14 09:22:23 +01:00