fixed 333707 Dereference before null check

src/tools/cardos-tool.c

@@ -1132,7 +1132,6 @@ int main(int argc, char *argv[])
 		sc_unlock(card);
 		sc_disconnect_card(card);
 	}
-	if (ctx)
-		sc_release_context(ctx);
+	sc_release_context(ctx);
 	return err;
 }

src/tools/cryptoflex-tool.c

@@ -1117,7 +1117,6 @@ end:
 		sc_unlock(card);
 		sc_disconnect_card(card);
 	}
-	if (ctx)
-		sc_release_context(ctx);
+	sc_release_context(ctx);
 	return err;
 }

src/tools/dnie-tool.c

@@ -232,8 +232,7 @@ dnie_tool_end:
 		sc_unlock(card);
 		sc_disconnect_card(card);
 	}
-	if (ctx)
-		sc_release_context(ctx);
+	sc_release_context(ctx);
 	return err;
 }
 

src/tools/iasecc-tool.c

@@ -288,8 +288,7 @@ end:
 		sc_unlock(card);
 		sc_disconnect_card(card);
 	}
-	if (ctx)
-		sc_release_context(ctx);
+	sc_release_context(ctx);
 
 	return err;
 }

src/tools/opensc-tool.c

@@ -909,10 +909,7 @@ int main(int argc, char *argv[])
 		action_count--;
 	}
 end:
-	if (card) {
-		sc_disconnect_card(card);
-	}
-	if (ctx)
-		sc_release_context(ctx);
+	sc_disconnect_card(card);
+	sc_release_context(ctx);
 	return err;
 }

src/tools/piv-tool.c

@@ -662,8 +662,7 @@ end:
 		sc_unlock(card);
 		sc_disconnect_card(card);
 	}
-	if (ctx)
-		sc_release_context(ctx);
+	sc_release_context(ctx);
 
 	ERR_print_errors_fp(stderr);
 	return err;

src/tools/pkcs15-tool.c

@@ -2427,11 +2427,8 @@ int main(int argc, char *argv[])
 		action_count--;
 	}
 end:
-	if (p15card)
-		sc_pkcs15_unbind(p15card);
-	if (card)
-		sc_disconnect_card(card);
-	if (ctx)
-		sc_release_context(ctx);
+	sc_pkcs15_unbind(p15card);
+	sc_disconnect_card(card);
+	sc_release_context(ctx);
 	return err;
 }

src/tools/sc-hsm-tool.c

@@ -1844,11 +1844,8 @@ int main(int argc, char *argv[])
 fail:
 	err = 1;
 end:
-	if (card) {
-		sc_disconnect_card(card);
-	}
-	if (ctx)
-		sc_release_context(ctx);
+	sc_disconnect_card(card);
+	sc_release_context(ctx);
 
 	ERR_print_errors_fp(stderr);
 	return err;