added fall through comment

This commit is contained in:
Frank Morgner 2015-10-09 11:09:57 +02:00
parent 7af89d0f91
commit b96ba14aae
5 changed files with 12 additions and 0 deletions

View File

@ -355,6 +355,7 @@ static int tcos_select_file(sc_card_t *card,
switch (in_path->type) { switch (in_path->type) {
case SC_PATH_TYPE_FILE_ID: case SC_PATH_TYPE_FILE_ID:
if (pathlen != 2) return SC_ERROR_INVALID_ARGUMENTS; if (pathlen != 2) return SC_ERROR_INVALID_ARGUMENTS;
/* fall through */
case SC_PATH_TYPE_FROM_CURRENT: case SC_PATH_TYPE_FROM_CURRENT:
apdu.p1 = 9; apdu.p1 = 9;
break; break;

View File

@ -535,6 +535,7 @@ static int westcos_create_file(sc_card_t *card, struct sc_file *file)
break; break;
case SC_FILE_TYPE_INTERNAL_EF: case SC_FILE_TYPE_INTERNAL_EF:
buf[0] |= 0x80; buf[0] |= 0x80;
/* fall through */
case SC_FILE_TYPE_WORKING_EF: case SC_FILE_TYPE_WORKING_EF:
switch (file->ef_structure) { switch (file->ef_structure) {
case SC_FILE_EF_TRANSPARENT: case SC_FILE_EF_TRANSPARENT:

View File

@ -252,6 +252,8 @@ static int cwa_compose_tlv(sc_card_t * card,
* NOTICE that iso7816 sect 5.2.2 states that Tag length may be 1 to n bytes * NOTICE that iso7816 sect 5.2.2 states that Tag length may be 1 to n bytes
* length. In this code we'll assume allways tag lenght = 1 byte * length. In this code we'll assume allways tag lenght = 1 byte
* *
* FIXME use `sc_asn1_read_tag` or similar instead
*
* @param card card info structure * @param card card info structure
* @param data Buffer to look for tlv into * @param data Buffer to look for tlv into
* @param datalen Buffer len * @param datalen Buffer len
@ -305,12 +307,15 @@ static int cwa_parse_tlv(sc_card_t * card,
switch (0xff & *(buffer + n + 1)) { switch (0xff & *(buffer + n + 1)) {
case 0x84: case 0x84:
tlv->len = (0xff & *(buffer + n + j++)); tlv->len = (0xff & *(buffer + n + j++));
/* fall through */
case 0x83: case 0x83:
tlv->len = tlv->len =
(tlv->len << 8) + (0xff & *(buffer + n + j++)); (tlv->len << 8) + (0xff & *(buffer + n + j++));
/* fall through */
case 0x82: case 0x82:
tlv->len = tlv->len =
(tlv->len << 8) + (0xff & *(buffer + n + j++)); (tlv->len << 8) + (0xff & *(buffer + n + j++));
/* fall through */
case 0x81: case 0x81:
tlv->len = tlv->len =
(tlv->len << 8) + (0xff & *(buffer + n + j++)); (tlv->len << 8) + (0xff & *(buffer + n + j++));

View File

@ -645,6 +645,7 @@ iso7816_construct_fci(struct sc_card *card, const sc_file_t *file,
switch (file->type) { switch (file->type) {
case SC_FILE_TYPE_INTERNAL_EF: case SC_FILE_TYPE_INTERNAL_EF:
buf[0] |= 0x08; buf[0] |= 0x08;
/* fall through */
case SC_FILE_TYPE_WORKING_EF: case SC_FILE_TYPE_WORKING_EF:
buf[0] |= file->ef_structure & 7; buf[0] |= file->ef_structure & 7;
break; break;

View File

@ -2380,13 +2380,17 @@ expr_eval(struct num_exp_ctx *ctx, unsigned int *vp, unsigned int pri)
case '*': case '*':
case '/': case '/':
new_pri++; new_pri++;
/* fall through */
case '+': case '+':
case '-': case '-':
new_pri++; new_pri++;
/* fall through */
case '&': case '&':
new_pri++; new_pri++;
/* fall through */
case '|': case '|':
new_pri++; new_pri++;
/* fall through */
case ')': case ')':
break; break;
default: default: