From b96ba14aae3218b2152b7634de2f643632ce93ad Mon Sep 17 00:00:00 2001
From: Frank Morgner <morgner@informatik.hu-berlin.de>
Date: Fri, 9 Oct 2015 11:09:57 +0200
Subject: [PATCH] added fall through comment

---
 src/libopensc/card-tcos.c    | 1 +
 src/libopensc/card-westcos.c | 1 +
 src/libopensc/cwa14890.c     | 5 +++++
 src/libopensc/iso7816.c      | 1 +
 src/pkcs15init/profile.c     | 4 ++++
 5 files changed, 12 insertions(+)

diff --git a/src/libopensc/card-tcos.c b/src/libopensc/card-tcos.c
index 29c89012..a1545232 100644
--- a/src/libopensc/card-tcos.c
+++ b/src/libopensc/card-tcos.c
@@ -355,6 +355,7 @@ static int tcos_select_file(sc_card_t *card,
 	switch (in_path->type) {
 	case SC_PATH_TYPE_FILE_ID:
 		if (pathlen != 2) return SC_ERROR_INVALID_ARGUMENTS;
+		/* fall through */
 	case SC_PATH_TYPE_FROM_CURRENT:
 		apdu.p1 = 9;
 		break;
diff --git a/src/libopensc/card-westcos.c b/src/libopensc/card-westcos.c
index c560e6c8..5c2e2cf0 100644
--- a/src/libopensc/card-westcos.c
+++ b/src/libopensc/card-westcos.c
@@ -535,6 +535,7 @@ static int westcos_create_file(sc_card_t *card, struct sc_file *file)
 		break;
 	case SC_FILE_TYPE_INTERNAL_EF:
 		buf[0] |= 0x80;
+		/* fall through */
 	case SC_FILE_TYPE_WORKING_EF:
 		switch (file->ef_structure) {
 		case SC_FILE_EF_TRANSPARENT:
diff --git a/src/libopensc/cwa14890.c b/src/libopensc/cwa14890.c
index 9266869d..48107074 100644
--- a/src/libopensc/cwa14890.c
+++ b/src/libopensc/cwa14890.c
@@ -252,6 +252,8 @@ static int cwa_compose_tlv(sc_card_t * card,
  * NOTICE that iso7816 sect 5.2.2 states that Tag length may be 1 to n bytes
  * length. In this code we'll assume allways tag lenght = 1 byte
  *
+ * FIXME use `sc_asn1_read_tag` or similar instead
+ *
  * @param card card info structure
  * @param data Buffer to look for tlv into
  * @param datalen Buffer len
@@ -305,12 +307,15 @@ static int cwa_parse_tlv(sc_card_t * card,
 		switch (0xff & *(buffer + n + 1)) {
 		case 0x84:
 			tlv->len = (0xff & *(buffer + n + j++));
+			/* fall through */
 		case 0x83:
 			tlv->len =
 			    (tlv->len << 8) + (0xff & *(buffer + n + j++));
+			/* fall through */
 		case 0x82:
 			tlv->len =
 			    (tlv->len << 8) + (0xff & *(buffer + n + j++));
+			/* fall through */
 		case 0x81:
 			tlv->len =
 			    (tlv->len << 8) + (0xff & *(buffer + n + j++));
diff --git a/src/libopensc/iso7816.c b/src/libopensc/iso7816.c
index 11e553b8..2ea08fb1 100644
--- a/src/libopensc/iso7816.c
+++ b/src/libopensc/iso7816.c
@@ -645,6 +645,7 @@ iso7816_construct_fci(struct sc_card *card, const sc_file_t *file,
 		switch (file->type) {
 		case SC_FILE_TYPE_INTERNAL_EF:
 			buf[0] |= 0x08;
+			/* fall through */
 		case SC_FILE_TYPE_WORKING_EF:
 			buf[0] |= file->ef_structure & 7;
 			break;
diff --git a/src/pkcs15init/profile.c b/src/pkcs15init/profile.c
index 377b0e3f..71ebce6b 100644
--- a/src/pkcs15init/profile.c
+++ b/src/pkcs15init/profile.c
@@ -2380,13 +2380,17 @@ expr_eval(struct num_exp_ctx *ctx, unsigned int *vp, unsigned int pri)
 		case '*':
 		case '/':
 			new_pri++;
+			/* fall through */
 		case '+':
 		case '-':
 			new_pri++;
+			/* fall through */
 		case '&':
 			new_pri++;
+			/* fall through */
 		case '|':
 			new_pri++;
+			/* fall through */
 		case ')':
 			break;
 		default: