giomba
/
opensc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cac: Avoid assigning local variable to function arguments 

Reported by cppcheck. The argument is not used after
returning from this function, but better make it explicit.
This commit is contained in:
Jakub Jelen 2020-11-13 17:24:26 +01:00 committed by Frank Morgner
parent 8a6708c163
commit af2fb6938c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/libopensc/card-cac.c
View File

@ -1872,6 +1872,7 @@ static int cac_pin_cmd(sc_card_t *card, struct sc_pin_cmd_data *data, int *tries
sc_apdu_t apdu;
u8 sbuf[SC_MAX_APDU_BUFFER_SIZE];
struct sc_card_driver *iso_drv = sc_get_iso7816_driver();
int rv;
if (data->cmd == SC_PIN_CMD_CHANGE) {
int i = 0;
@ -1897,7 +1898,10 @@ static int cac_pin_cmd(sc_card_t *card, struct sc_pin_cmd_data *data, int *tries
}
}
return iso_drv->ops->pin_cmd(card, data, tries_left);
rv = iso_drv->ops->pin_cmd(card, data, tries_left);
data->apdu = NULL;
return rv;
}
static struct sc_card_operations cac_ops;