From af2fb6938cbb78ac92ab61d25b6dc0200dda24c4 Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Fri, 13 Nov 2020 17:24:26 +0100 Subject: [PATCH] cac: Avoid assigning local variable to function arguments Reported by cppcheck. The argument is not used after returning from this function, but better make it explicit. --- src/libopensc/card-cac.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libopensc/card-cac.c b/src/libopensc/card-cac.c index 61e69c88..1d1b616c 100644 --- a/src/libopensc/card-cac.c +++ b/src/libopensc/card-cac.c @@ -1872,6 +1872,7 @@ static int cac_pin_cmd(sc_card_t *card, struct sc_pin_cmd_data *data, int *tries sc_apdu_t apdu; u8 sbuf[SC_MAX_APDU_BUFFER_SIZE]; struct sc_card_driver *iso_drv = sc_get_iso7816_driver(); + int rv; if (data->cmd == SC_PIN_CMD_CHANGE) { int i = 0; @@ -1897,7 +1898,10 @@ static int cac_pin_cmd(sc_card_t *card, struct sc_pin_cmd_data *data, int *tries } } - return iso_drv->ops->pin_cmd(card, data, tries_left); + rv = iso_drv->ops->pin_cmd(card, data, tries_left); + + data->apdu = NULL; + return rv; } static struct sc_card_operations cac_ops;