Commit Graph

4 Commits

Author SHA1 Message Date
nacin 836354fd7a Twenty Eleven:
* Use add_option(), rather than get_option() with defaults, to prevent notoption queries.
 * Add twentyeleven_theme_options_validate filter, that way one doesn't need to add a filter to sanitize_option_\$option to allow more options in.
 * Some inline doc modifications and additions.
see #17198.



git-svn-id: http://svn.automattic.com/wordpress/trunk@17734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 08:52:37 +00:00
nacin 9db8f895a0 Rewrite of Twenty Eleven theme-options.php. Including:
* Full inline documentation.
 * Enqueue scripts/styles on admin_enqueue_scripts and use hook_suffix rather than GET[page]
 * Add filters to twentyeleven_color_schemes(), twentyeleven_layouts(), which necessitates adding a thumbnail URL value here, rather than generating them in the form.
 * Add a twentyeleven_default_theme_options filter.
 * Remove manual check for REQUEST[settings-updated], instead using settings_errors(), since we're using options.php.
 * Abstract out the default link color, rather than hardcoding it in certain places.
 * Use checked().
 * Rename some variables and functions for clarity.
 * Remove unnecessary functions twentyeleven_current_layout() and twentyeleven_current_color_scheme(), as we already have twentyeleven_get_theme_options().
 * Add a twentyeleven_color_schemes action to allow for enqueueing custom color schemes.
 * Add a twentyeleven_layout_classes filter, to allow filtering what gets sent back to body_class().
 * Hook into wp_enqueue_scripts rather than wp_print_styles for enqueueing the color stylesheet.
 * Rewrite the register_setting() callback to start from scratch with an empty array. Improve the link_color logic.
 * Use submit_button().
 * Use esc_attr() rather than esc_attr_e() for non-translations.

TODO:
 * Implement settings sections/fields logic to allow extension of the options page.
 * Consider re-doing this in a class. It'll be cleaner.
 * Store a DB version so we can do an add_option(), rather than calling get_option() with defaults.

see #17198.



git-svn-id: http://svn.automattic.com/wordpress/trunk@17733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 08:06:57 +00:00
lancewillett e5425ba17a Twenty Eleven: theme options - see #17198
* First pass at Link Color CSS rules
 * Add new function to return default values
 * Implement better validation for hex color value
 * Fix missing esc_attr()

git-svn-id: http://svn.automattic.com/wordpress/trunk@17732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-27 23:03:27 +00:00
iandstewart 90451d9052 Twenty Eleven: functions.php cleanup and introduction of theme options; see #17198
* Cleanup functions.php, adding comments and function_exists() checks following Twenty Ten's example
* Theme option for choosing an alternate (dark) color scheme. It currently only loads a placeholder CSS file with dark styles to follow.
* Theme option for selecting a link color that loads an internal style block for resetting link colors. An updated style.css will follow to take advantage of this.
* Theme options for selecting an alternate layout. Adds a class to the body element. An updated style.css will follow to take advantage of this.


git-svn-id: http://svn.automattic.com/wordpress/trunk@17721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-26 22:52:18 +00:00