From f2ecf78e882992d9c73da1432a5171a0890074bb Mon Sep 17 00:00:00 2001
From: koopersmith <koopersmith@1a063a9b-81f0-0310-95a4-ce76da25c4cd>
Date: Tue, 15 May 2012 22:01:36 +0000
Subject: [PATCH] Theme Customizer: Make wp.customize.Values.when return a
 jQuery.Deferred.promise() object, to add additional flexibility. see #19910.

git-svn-id: http://core.svn.wordpress.org/trunk@20797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
---
 wp-includes/js/customize-base.dev.js | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/wp-includes/js/customize-base.dev.js b/wp-includes/js/customize-base.dev.js
index 4e79aa5c4..04fe2f2af 100644
--- a/wp-includes/js/customize-base.dev.js
+++ b/wp-includes/js/customize-base.dev.js
@@ -331,36 +331,46 @@ if ( typeof wp === 'undefined' )
 		/**
 		 * Runs a callback once all requested values exist.
 		 *
-		 * when( ids*, callback );
+		 * when( ids*, [callback] );
 		 *
 		 * For example:
 		 *     when( id1, id2, id3, function( value1, value2, value3 ) {} );
+		 *
+		 * @returns $.Deferred.promise();
 		 */
 		when: function() {
 			var self = this,
-				ids = slice.call( arguments ),
-				callback = ids.pop();
+				ids  = slice.call( arguments ),
+				dfd  = $.Deferred();
+
+			// If the last argument is a callback, bind it to .done()
+			if ( $.isFunction( ids[ ids.length - 1 ] ) )
+				dfd.done( ids.pop() );
 
 			$.when.apply( $, $.map( ids, function( id ) {
 				if ( self.has( id ) )
 					return;
 
-				return self._deferreds[ id ] || ( self._deferreds[ id ] = $.Deferred() );
+				return self._deferreds[ id ] = self._deferreds[ id ] || $.Deferred();
 			})).done( function() {
 				var values = $.map( ids, function( id ) {
 						return self( id );
 					});
 
 				// If a value is missing, we've used at least one expired deferred.
-				// Call Values.when again to update our master deferred.
+				// Call Values.when again to generate a new deferred.
 				if ( values.length !== ids.length ) {
-					ids.push( callback );
-					self.when.apply( self, ids );
+					// ids.push( callback );
+					self.when.apply( self, ids ).done( function() {
+						dfd.resolveWith( self, values );
+					});
 					return;
 				}
 
-				callback.apply( self, values );
+				dfd.resolveWith( self, values );
 			});
+
+			return dfd.promise();
 		}
 	});