From b5e9c9c703c960ff1ac8ec5b45dec8923a11987d Mon Sep 17 00:00:00 2001
From: nacin <nacin@1a063a9b-81f0-0310-95a4-ce76da25c4cd>
Date: Sat, 9 Oct 2010 08:59:57 +0000
Subject: [PATCH] Fix some notices. props mrmist, fixes #15079. Also some
 standards fixes.

git-svn-id: http://svn.automattic.com/wordpress/trunk@15761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
---
 wp-admin/themes.php | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/wp-admin/themes.php b/wp-admin/themes.php
index 031b77c46..697b0f0ec 100644
--- a/wp-admin/themes.php
+++ b/wp-admin/themes.php
@@ -136,41 +136,40 @@ if ( ! current_user_can( 'switch_themes' ) ) {
 <p class="search-box">
 	<label class="screen-reader-text" for="theme-search-input"><?php _e('Search Themes'); ?>:</label>
 	<input type="text" id="tag-search-input" name="s" value="<?php _admin_search_query(); ?>" />
-	<input type="submit" value="<?php esc_attr_e('Search Themes');  ?>" class="button" />
+	<input type="submit" value="<?php esc_attr_e('Search Themes'); ?>" class="button" />
 	<a id="filter-click" href="?filter=1"><?php _e( 'Feature Filter' ); ?></a>
 </p>
 
 <br class="clear"/>
 
-<div id="filters" <?php if ( $tpage != 'filter' ) echo ' style="display: none"' ?>>
+<div id="filters" <?php if ( ! isset( $tpage ) || $tpage != 'filter' ) echo ' style="display: none"' ?>>
 <?php $feature_list = get_theme_feature_list(); ?>
 	<div class="feature-filter">
 		<p class="install-help"><?php _e('Theme filters') ?></p>
 
-	<?php foreach ( $feature_list as $feature_name => $features ) : ?>
-		<?php	$feature_name = esc_html( $feature_name ); ?>
+	<?php foreach ( $feature_list as $feature_name => $features ) :
+			$feature_name = esc_html( $feature_name ); ?>
 		
 		<div class="feature-container">
 			<div class="feature-name"><?php echo $feature_name ?></div>
-		
+
 			<ol style="float: left; width: 725px;" class="feature-group">
-				<?php foreach ( $features as $key => $feature ) : ?>
-					<?php
+				<?php foreach ( $features as $key => $feature ) :
 						$feature_name = $feature;
 						$feature_name = esc_html( $feature_name );
 						$feature = esc_attr($feature);
 						?>
 				<li>
-					<input type="checkbox" name="features[<?php echo $key; ?>]" id="feature-id-<?php echo $key; ?>" value="<?php echo $key; ?>" <?php if ( in_array( $key, $checked_features ) ) echo ' checked="checked"' ?>/>
+					<input type="checkbox" name="features[<?php echo $key; ?>]" id="feature-id-<?php echo $key; ?>" value="<?php echo $key; ?>" <?php checked( isset( $checked_features ) && in_array( $key, $checked_features ) ); ?>/>
 					<label for="feature-id-<?php echo $key; ?>"><?php echo $feature_name; ?></label>
 				</li>
-				<?php	endforeach; ?>
+				<?php endforeach; ?>
 			</ol>
 		</div>
-	<?php	endforeach; ?>
+	<?php endforeach; ?>
 
 	<div class="feature-container">
-		<input style="margin-left: 120px" type="submit" class="button-secondary submitter" value="<?php _e( 'Apply Filters' ); ?>" />
+		<input style="margin-left: 120px" type="submit" class="button-secondary submitter" value="<?php esc_attr_e( 'Apply Filters' ); ?>" />
 		&nbsp;
 		<small><a id="mini-filter-click" href="<?php echo admin_url( 'themes.php' ); ?>"><?php _e( 'Close filters' )?></a></small>
 	</div>