golem
/
twentyGOLEM
9
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

When deleting plugins, check for uninstall hooks and warn of data deletion. Props cyberhobo. Pluralize some string(s). fixes #11850 

git-svn-id: http://svn.automattic.com/wordpress/trunk@13470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
nacin 2010-02-27 22:01:22 +00:00
parent 6df81f3d95
commit 9deb08bade
1 changed files with 31 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
wp-admin/plugins.php
View File

@ -222,14 +222,15 @@ if ( !empty($action) ) {
require_once('admin-header.php'); require_once('admin-header.php');
?> ?>
<div class="wrap"> <div class="wrap">
<h2><?php _e('Delete Plugin(s)'); ?></h2>
<?php <?php
$files_to_delete = $plugin_info = array(); $files_to_delete = $plugin_info = array();
foreach ( (array) $plugins as $plugin ) { foreach ( (array) $plugins as $plugin ) {
if ( '.' == dirname($plugin) ) { if ( '.' == dirname($plugin) ) {
$files_to_delete[] = WP_PLUGIN_DIR . '/' . $plugin; $files_to_delete[] = WP_PLUGIN_DIR . '/' . $plugin;
if ( $data = get_plugin_data(WP_PLUGIN_DIR . '/' . $plugin) ) if( $data = get_plugin_data(WP_PLUGIN_DIR . '/' . $plugin) ) {
$plugin_info[ $plugin ] = $data; $plugin_info[ $plugin ] = $data;
$plugin_info[ $plugin ]['is_uninstallable'] = is_uninstallable_plugin( $plugin );
}
} else { } else {
//Locate all the files in that folder: //Locate all the files in that folder:
$files = list_files( WP_PLUGIN_DIR . '/' . dirname($plugin) ); $files = list_files( WP_PLUGIN_DIR . '/' . dirname($plugin) );
@ -237,20 +238,40 @@ if ( !empty($action) ) {
$files_to_delete = array_merge($files_to_delete, $files); $files_to_delete = array_merge($files_to_delete, $files);
} }
//Get plugins list from that folder //Get plugins list from that folder
if ( $folder_plugins = get_plugins( '/' . dirname($plugin)) ) if ( $folder_plugins = get_plugins( '/' . dirname($plugin)) ) {
$plugin_info = array_merge($plugin_info, $folder_plugins); foreach( $folder_plugins as $plugin_file => $data ) {
$plugin_info[ $plugin_file ] = $data;
$plugin_info[ $plugin_file ]['is_uninstallable'] = is_uninstallable_plugin( $plugin );
}
}
} }
} }
screen_icon();
$plugins_to_delete = count( $plugin_info );
echo '<h2>' . _n( 'Delete Plugin', 'Delete Plugins', $plugins_to_delete ) . '</h2>';
?> ?>
<p><?php _e('Deleting the selected plugins will remove the following plugin(s) and their files:'); ?></p> <p><?php echo _n( 'Deleting the selected plugin will remove the following plugin and its files:', 'Deleting the selected plugins will remove the following plugins and their files:', $plugins_to_delete ); ?></p>
<ul class="ul-disc"> <ul class="ul-disc">
<?php <?php
foreach ( $plugin_info as $plugin ) $data_to_delete = false;
/* translators: 1: plugin name, 2: plugin author */ foreach ( $plugin_info as $plugin ) {
echo '<li>', sprintf(__('<strong>%1$s</strong> by <em>%2$s</em>'), $plugin['Name'], $plugin['Author']), '</li>'; if ( $plugin['is_uninstallable'] ) {
/* translators: 1: plugin name, 2: plugin author */
echo '<li>', sprintf( __( '<strong>%1$s</strong> by <em>%2$s</em> (will also <strong>delete its data</strong>)' ), $plugin['Name'], $plugin['Author'] ), '</li>';
$data_to_delete = true;
} else {
/* translators: 1: plugin name, 2: plugin author */
echo '<li>', sprintf( __('<strong>%1$s</strong> by <em>%2$s</em>' ), $plugin['Name'], $plugin['Author'] ), '</li>';
}
}
?> ?>
</ul> </ul>
<p><?php _e('Are you sure you wish to delete these files?') ?></p> <p><?php
if ( $data_to_delete )
_e('Are you sure you wish to delete these files and data?');
else
_e('Are you sure you wish to delete these files?');
?></p>
<form method="post" action="<?php echo esc_url($_SERVER['REQUEST_URI']); ?>" style="display:inline;"> <form method="post" action="<?php echo esc_url($_SERVER['REQUEST_URI']); ?>" style="display:inline;">
<input type="hidden" name="verify-delete" value="1" /> <input type="hidden" name="verify-delete" value="1" />
<input type="hidden" name="action" value="delete-selected" /> <input type="hidden" name="action" value="delete-selected" />
@ -259,7 +280,7 @@ if ( !empty($action) ) {
echo '<input type="hidden" name="checked[]" value="' . esc_attr($plugin) . '" />'; echo '<input type="hidden" name="checked[]" value="' . esc_attr($plugin) . '" />';
?> ?>
<?php wp_nonce_field('bulk-manage-plugins') ?> <?php wp_nonce_field('bulk-manage-plugins') ?>
<input type="submit" name="submit" value="<?php esc_attr_e('Yes, Delete these files') ?>" class="button" /> <input type="submit" name="submit" value="<?php $data_to_delete ? esc_attr_e('Yes, Delete these files and data') : esc_attr_e('Yes, Delete these files') ?>" class="button" />
</form> </form>
<form method="post" action="<?php echo esc_url(wp_get_referer()); ?>" style="display:inline;"> <form method="post" action="<?php echo esc_url(wp_get_referer()); ?>" style="display:inline;">
<input type="submit" name="submit" value="<?php esc_attr_e('No, Return me to the plugin list') ?>" class="button" /> <input type="submit" name="submit" value="<?php esc_attr_e('No, Return me to the plugin list') ?>" class="button" />