From 4d2d65549003b702e1a48caa5d26c1540b04e0f8 Mon Sep 17 00:00:00 2001
From: markjaquith <markjaquith@1a063a9b-81f0-0310-95a4-ce76da25c4cd>
Date: Fri, 17 Oct 2008 20:06:22 +0000
Subject: [PATCH] Covering our XSS bases

git-svn-id: http://svn.automattic.com/wordpress/trunk@9233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
---
 wp-admin/categories.php           | 2 +-
 wp-admin/edit-comments.php        | 2 +-
 wp-admin/edit-form-advanced.php   | 2 +-
 wp-admin/edit-link-categories.php | 2 +-
 wp-admin/edit-link-form.php       | 2 +-
 wp-admin/edit-page-form.php       | 2 +-
 wp-admin/edit-pages.php           | 2 +-
 wp-admin/edit-tags.php            | 2 +-
 wp-admin/export.php               | 2 +-
 wp-admin/import.php               | 2 +-
 wp-admin/index.php                | 2 +-
 wp-admin/link-manager.php         | 2 +-
 wp-admin/media-upload.php         | 2 +-
 wp-admin/options-discussion.php   | 2 +-
 wp-admin/options-general.php      | 2 +-
 wp-admin/options-media.php        | 2 +-
 wp-admin/options-misc.php         | 2 +-
 wp-admin/options-permalink.php    | 2 +-
 wp-admin/options-privacy.php      | 2 +-
 wp-admin/options-reading.php      | 2 +-
 wp-admin/options-writing.php      | 2 +-
 wp-admin/plugin-editor.php        | 2 +-
 wp-admin/plugin-install.php       | 2 +-
 wp-admin/plugins.php              | 2 +-
 wp-admin/theme-editor.php         | 2 +-
 wp-admin/themes.php               | 2 +-
 wp-admin/turbo.php                | 2 +-
 wp-admin/upload.php               | 2 +-
 wp-admin/user-edit.php            | 2 +-
 wp-admin/users.php                | 2 +-
 wp-admin/widgets.php              | 2 +-
 31 files changed, 31 insertions(+), 31 deletions(-)

diff --git a/wp-admin/categories.php b/wp-admin/categories.php
index d304fd39a..0386f24e8 100644
--- a/wp-admin/categories.php
+++ b/wp-admin/categories.php
@@ -140,7 +140,7 @@ if ( isset($_GET['message']) && ( $msg = (int) $_GET['message'] ) ) : ?>
 endif; ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <ul class="subsubsub"><li class="current"><a class="current"><br /></a></li></ul>
 <form class="search-form" action="" method="get">
diff --git a/wp-admin/edit-comments.php b/wp-admin/edit-comments.php
index 9cb613f80..7bd73c976 100644
--- a/wp-admin/edit-comments.php
+++ b/wp-admin/edit-comments.php
@@ -121,7 +121,7 @@ if ( isset( $_GET['approved'] ) || isset( $_GET['deleted'] ) || isset( $_GET['sp
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <ul class="subsubsub">
 <?php
diff --git a/wp-admin/edit-form-advanced.php b/wp-admin/edit-form-advanced.php
index 647968954..8ac5f9fd9 100644
--- a/wp-admin/edit-form-advanced.php
+++ b/wp-admin/edit-form-advanced.php
@@ -457,7 +457,7 @@ endif;
 <?php endif; ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2>
+<h2><?php echo wp_specialchars( $title ); ?></h2>
 <form name="post" action="post.php" method="post" id="post">
 <?php
 
diff --git a/wp-admin/edit-link-categories.php b/wp-admin/edit-link-categories.php
index 02aaf38e5..a2c63e3c4 100644
--- a/wp-admin/edit-link-categories.php
+++ b/wp-admin/edit-link-categories.php
@@ -76,7 +76,7 @@ $messages[6] = __('Categories deleted.'); ?>
 endif; ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <ul class="subsubsub"><li><a class="current"><br /></a></li></ul>
 <form class="search-form" action="" method="get">
diff --git a/wp-admin/edit-link-form.php b/wp-admin/edit-link-form.php
index daf8778be..a999d2dbf 100644
--- a/wp-admin/edit-link-form.php
+++ b/wp-admin/edit-link-form.php
@@ -320,7 +320,7 @@ add_meta_box('linkadvanceddiv', __('Advanced'), 'link_advanced_meta_box', 'link'
 </div>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <!--
 <p id="big-add-button">
diff --git a/wp-admin/edit-page-form.php b/wp-admin/edit-page-form.php
index d51406508..1083892bc 100644
--- a/wp-admin/edit-page-form.php
+++ b/wp-admin/edit-page-form.php
@@ -358,7 +358,7 @@ endif;
 </div>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form name="post" action="page.php" method="post" id="post">
 <?php if ( $notice ) : ?>
diff --git a/wp-admin/edit-pages.php b/wp-admin/edit-pages.php
index 7651430b5..9437d78a2 100644
--- a/wp-admin/edit-pages.php
+++ b/wp-admin/edit-pages.php
@@ -135,7 +135,7 @@ if ( (int) $_GET['locked'] ) {
 endif; ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <ul class="subsubsub">
 <?php
diff --git a/wp-admin/edit-tags.php b/wp-admin/edit-tags.php
index fa5287930..5857d9605 100644
--- a/wp-admin/edit-tags.php
+++ b/wp-admin/edit-tags.php
@@ -143,7 +143,7 @@ $messages[6] = __('Tags deleted.'); ?>
 endif; ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <ul class="subsubsub"><li class="current"><a class="current"><br /></a></li></ul>
 <form class="search-form" action="" method="get">
diff --git a/wp-admin/export.php b/wp-admin/export.php
index a09d28ef7..4379dd1d4 100644
--- a/wp-admin/export.php
+++ b/wp-admin/export.php
@@ -22,7 +22,7 @@ require_once ('admin-header.php');
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <p><?php _e('When you click the button below WordPress will create an XML file for you to save to your computer.'); ?></p>
 <p><?php _e('This format, which we call WordPress eXtended RSS or WXR, will contain your posts, pages, comments, custom fields, categories, and tags.'); ?></p>
diff --git a/wp-admin/import.php b/wp-admin/import.php
index 928df7214..74a77995c 100644
--- a/wp-admin/import.php
+++ b/wp-admin/import.php
@@ -13,7 +13,7 @@ require_once ('admin-header.php');
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 <p><?php _e('If you have posts or comments in another system, WordPress can import those into this blog. To get started, choose a system to import from below:'); ?></p>
 
 <?php
diff --git a/wp-admin/index.php b/wp-admin/index.php
index bab573766..e3ff326ea 100644
--- a/wp-admin/index.php
+++ b/wp-admin/index.php
@@ -38,7 +38,7 @@ $today = current_time('mysql', 1);
 </div>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2>
+<h2><?php echo wp_specialchars( $title ); ?></h2>
 
 <div id="dashboard-widgets-wrap">
 
diff --git a/wp-admin/link-manager.php b/wp-admin/link-manager.php
index 21a4935ba..49b5852d7 100644
--- a/wp-admin/link-manager.php
+++ b/wp-admin/link-manager.php
@@ -95,7 +95,7 @@ if ( isset($_GET['deleted']) ) {
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <div class="filter">
 <form id="list-filter" action="" method="get">
diff --git a/wp-admin/media-upload.php b/wp-admin/media-upload.php
index 36aa690ee..68ed50368 100644
--- a/wp-admin/media-upload.php
+++ b/wp-admin/media-upload.php
@@ -56,7 +56,7 @@ if ( isset($_GET['inline']) ) {
 	$parent_file = 'edit.php';
 	require_once('admin-header.php'); ?>
 	<div class="wrap">
-	<h2><?php echo $title ?></h2> 
+	<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 	<form enctype="multipart/form-data" method="post" action="media-upload.php?inline=&amp;upload-page-form=" class="media-upload-form type-form validate" id="file-form">
 
diff --git a/wp-admin/options-discussion.php b/wp-admin/options-discussion.php
index 69e8412b7..2b97a1ffa 100644
--- a/wp-admin/options-discussion.php
+++ b/wp-admin/options-discussion.php
@@ -16,7 +16,7 @@ include('admin-header.php');
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form method="post" action="options.php">
 <input type='hidden' name='option_page' value='discussion' />
diff --git a/wp-admin/options-general.php b/wp-admin/options-general.php
index 1f4b4fbd0..c8aaafd0b 100644
--- a/wp-admin/options-general.php
+++ b/wp-admin/options-general.php
@@ -49,7 +49,7 @@ include('./admin-header.php');
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form method="post" action="options.php">
 <input type='hidden' name='option_page' value='general' />
diff --git a/wp-admin/options-media.php b/wp-admin/options-media.php
index 7948d6916..175ad5e93 100644
--- a/wp-admin/options-media.php
+++ b/wp-admin/options-media.php
@@ -17,7 +17,7 @@ include('admin-header.php');
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form action="options.php" method="post">
 <input type="hidden" name="action" value="update" />
diff --git a/wp-admin/options-misc.php b/wp-admin/options-misc.php
index e457bd4f3..12a73f72f 100644
--- a/wp-admin/options-misc.php
+++ b/wp-admin/options-misc.php
@@ -17,7 +17,7 @@ include('admin-header.php');
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form method="post" action="options.php">
 <input type='hidden' name='option_page' value='misc' />
diff --git a/wp-admin/options-permalink.php b/wp-admin/options-permalink.php
index ec3001f31..bd44b1fc0 100644
--- a/wp-admin/options-permalink.php
+++ b/wp-admin/options-permalink.php
@@ -123,7 +123,7 @@ else
 <?php endif; ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form name="form" action="options-permalink.php" method="post">
 <?php wp_nonce_field('update-permalink') ?>
diff --git a/wp-admin/options-privacy.php b/wp-admin/options-privacy.php
index cfe2c93c6..f9efc0927 100644
--- a/wp-admin/options-privacy.php
+++ b/wp-admin/options-privacy.php
@@ -16,7 +16,7 @@ include('./admin-header.php');
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form method="post" action="options.php">
 <?php wp_nonce_field('privacy-options') ?>
diff --git a/wp-admin/options-reading.php b/wp-admin/options-reading.php
index af90a088a..f516656af 100644
--- a/wp-admin/options-reading.php
+++ b/wp-admin/options-reading.php
@@ -16,7 +16,7 @@ include('admin-header.php');
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form name="form1" method="post" action="options.php">
 <?php wp_nonce_field('reading-options') ?>
diff --git a/wp-admin/options-writing.php b/wp-admin/options-writing.php
index 316328f44..15db411b3 100644
--- a/wp-admin/options-writing.php
+++ b/wp-admin/options-writing.php
@@ -16,7 +16,7 @@ include('admin-header.php');
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form method="post" action="options.php">
 <?php wp_nonce_field('writing-options') ?>
diff --git a/wp-admin/plugin-editor.php b/wp-admin/plugin-editor.php
index 1cabd3de1..b43f52e38 100644
--- a/wp-admin/plugin-editor.php
+++ b/wp-admin/plugin-editor.php
@@ -96,7 +96,7 @@ default:
 </div>
 <?php endif; ?>
 <div class="wrap">
-	<h2><?php echo $title ?></h2> 
+	<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <div class="tablenav">
 <div class="alignleft">
diff --git a/wp-admin/plugin-install.php b/wp-admin/plugin-install.php
index 2ab1fa58a..43f1e8ca9 100644
--- a/wp-admin/plugin-install.php
+++ b/wp-admin/plugin-install.php
@@ -52,7 +52,7 @@ do_action('install_plugins_pre_' . $tab); //Used to override the general interfa
 include('admin-header.php');
 ?>
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 	<ul class="subsubsub">
 <?php
diff --git a/wp-admin/plugins.php b/wp-admin/plugins.php
index 6947e1176..95e135dac 100644
--- a/wp-admin/plugins.php
+++ b/wp-admin/plugins.php
@@ -203,7 +203,7 @@ if( !empty($invalid) )
 <?php endif; ?>
 
 <div class="wrap">
-	<h2><?php echo $title ?></h2> 
+	<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <p><?php _e('Plugins extend and expand the functionality of WordPress. Once a plugin is installed, you may activate it or deactivate it here.'); ?></p>
 <?php
diff --git a/wp-admin/theme-editor.php b/wp-admin/theme-editor.php
index c5b2e7c81..1f114d3e3 100644
--- a/wp-admin/theme-editor.php
+++ b/wp-admin/theme-editor.php
@@ -99,7 +99,7 @@ $description = get_file_description($file);
 $desc_header = ( $description != $file_show ) ? "$description</strong> (%s)" : "%s";
 ?>
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 <div class="bordertitle">
 	<form id="themeselector" action="theme-editor.php" method="post">
 		<strong><label for="theme"><?php _e('Select theme to edit:'); ?> </label></strong>
diff --git a/wp-admin/themes.php b/wp-admin/themes.php
index 6c17a818e..8001472d0 100644
--- a/wp-admin/themes.php
+++ b/wp-admin/themes.php
@@ -98,7 +98,7 @@ function theme_update_available( $theme ) {
 ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <h2><?php _e('Current Theme'); ?></h2>
 <div id="current-theme">
diff --git a/wp-admin/turbo.php b/wp-admin/turbo.php
index 6599b1c72..2b292fb3f 100644
--- a/wp-admin/turbo.php
+++ b/wp-admin/turbo.php
@@ -17,7 +17,7 @@ require_once('admin-header.php');
 if ( ! $is_opera ) {
 ?>
 	<div id="gears-info-box" class="wrap">
-	<h2><?php echo $title ?></h2> 
+	<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 	<img src="images/gear.png" title="Gear" alt="" class="gears-img" />
 	<div id="gears-msg1">
diff --git a/wp-admin/upload.php b/wp-admin/upload.php
index 547674fe3..232ece172 100644
--- a/wp-admin/upload.php
+++ b/wp-admin/upload.php
@@ -183,7 +183,7 @@ if ( isset($message) ) { ?>
 <?php do_action('restrict_manage_posts'); ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <ul class="subsubsub">
 <?php
diff --git a/wp-admin/user-edit.php b/wp-admin/user-edit.php
index 30ffcd77c..852f4aba5 100644
--- a/wp-admin/user-edit.php
+++ b/wp-admin/user-edit.php
@@ -177,7 +177,7 @@ include ('admin-header.php');
 <?php endif; ?>
 
 <div class="wrap" id="profile-page">
-	<h2><?php echo $title ?></h2> 
+	<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form id="your-profile" action="" method="post">
 <?php wp_nonce_field('update-user_' . $user_id) ?>
diff --git a/wp-admin/users.php b/wp-admin/users.php
index a9b735c6b..f63308833 100644
--- a/wp-admin/users.php
+++ b/wp-admin/users.php
@@ -264,7 +264,7 @@ if ( ! empty($messages) ) {
 } ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 <form id="posts-filter" action="" method="get">
 	<?php if ( $wp_user_search->is_search() ) : ?>
diff --git a/wp-admin/widgets.php b/wp-admin/widgets.php
index e761c0bc9..00a84ab13 100644
--- a/wp-admin/widgets.php
+++ b/wp-admin/widgets.php
@@ -233,7 +233,7 @@ require_once( 'admin-header.php' ); ?>
 <?php endif; ?>
 
 <div class="wrap">
-<h2><?php echo $title ?></h2> 
+<h2><?php echo wp_specialchars( $title ); ?></h2> 
 
 	<form id="widgets-filter" action="" method="get">