From 3ca17b00aceb1d09456584739197ddeff59097ac Mon Sep 17 00:00:00 2001
From: nacin <nacin@1a063a9b-81f0-0310-95a4-ce76da25c4cd>
Date: Sun, 18 Apr 2010 14:51:55 +0000
Subject: [PATCH] Optimize the Authors drop-down in export.php. Makes it one
 query, also orders authors by display name. see #10317.

git-svn-id: http://svn.automattic.com/wordpress/trunk@14153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
---
 wp-admin/export.php | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/wp-admin/export.php b/wp-admin/export.php
index 8a7820121..a8c9c451c 100644
--- a/wp-admin/export.php
+++ b/wp-admin/export.php
@@ -87,11 +87,9 @@ for ( $i = 1; $i < 13; $i++ ) {
 <select name="author" id="author">
 <option value="all" selected="selected"><?php _e('All Authors'); ?></option>
 <?php
-$authors = $wpdb->get_col( "SELECT post_author FROM $wpdb->posts GROUP BY post_author" );
-foreach ( $authors as $id ) {
-	$o = get_userdata( $id );
-	echo "<option value='{$o->ID}'>{$o->display_name}</option>\n";
-}
+$authors = $wpdb->get_results( "SELECT DISTINCT u.id, u.display_name FROM $wpdb->users u INNER JOIN $wpdb->posts p ON u.id = p.post_author ORDER BY u.display_name" );
+foreach ( (array) $authors as $author )
+       echo "<option value='{$author->id}'>{$author->display_name}</option>\n";
 ?>
 </select>
 </td>