From 351b6ce13e98fe7644956ce08a492bafc477b1eb Mon Sep 17 00:00:00 2001 From: nacin Date: Thu, 12 May 2011 05:50:53 +0000 Subject: [PATCH] Move output buffering out of a loop, collapsing it into one buffer. props mitchoyoshitaka, fixes #17352. git-svn-id: http://svn.automattic.com/wordpress/trunk@17897 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-admin/admin-ajax.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/wp-admin/admin-ajax.php b/wp-admin/admin-ajax.php index 07be38829..2f20dc66d 100644 --- a/wp-admin/admin-ajax.php +++ b/wp-admin/admin-ajax.php @@ -609,15 +609,15 @@ case 'get-comments' : if ( !$wp_list_table->has_items() ) die('1'); - $comment_list_item = ''; $x = new WP_Ajax_Response(); + ob_start(); foreach ( $wp_list_table->items as $comment ) { get_comment( $comment ); - ob_start(); - $wp_list_table->single_row( $comment ); - $comment_list_item .= ob_get_contents(); - ob_end_clean(); + $wp_list_table->single_row( $comment ); } + $comment_list_item = ob_get_contents(); + ob_end_clean(); + $x->add( array( 'what' => 'comments', 'data' => $comment_list_item