Cleanups.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
nacin
parent
a57f8861e6
commit
332bac61a1
|
|
@ -229,10 +229,13 @@ add_action( 'save_post', '_save_post_hook', 5, 2 );
|
|||
add_action( 'transition_post_status', '_transition_post_status', 5, 3 );
|
||||
add_action( 'comment_form', 'wp_comment_form_unfiltered_html_nonce' );
|
||||
add_action( 'wp_scheduled_delete', 'wp_scheduled_delete' );
|
||||
|
||||
// Navigation menu actions
|
||||
add_action( 'trash_post', '_wp_trash_menu_item' );
|
||||
add_action( 'untrash_post', '_wp_untrash_menu_item' );
|
||||
add_action( 'delete_post', '_wp_delete_post_menu_item' );
|
||||
add_action( 'delete_term', '_wp_delete_tax_menu_item' );
|
||||
add_action( 'transition_post_status', '_wp_auto_add_pages_to_menu', 10, 3 );
|
||||
|
||||
// Post Thumbnail CSS class filtering
|
||||
add_action( 'begin_fetch_post_thumbnail_html', '_wp_post_thumbnail_class_filter_add' );
|
||||
|
|
|
|||
|
|
@ -16,7 +16,7 @@
|
|||
* @uses get_term_by
|
||||
*
|
||||
* @param string $menu Menu id, slug or name
|
||||
* @return mixed false if $menu param isn't supplied or term does not exist, menu object if successfull
|
||||
* @return mixed false if $menu param isn't supplied or term does not exist, menu object if successful.
|
||||
*/
|
||||
function wp_get_nav_menu_object( $menu ) {
|
||||
if ( ! $menu )
|
||||
|
|
@ -30,15 +30,14 @@ function wp_get_nav_menu_object( $menu ) {
|
|||
if ( ! $menu_obj )
|
||||
$menu_obj = get_term_by( 'name', $menu, 'nav_menu' );
|
||||
|
||||
if ( ! $menu_obj ) {
|
||||
if ( ! $menu_obj )
|
||||
$menu_obj = false;
|
||||
}
|
||||
|
||||
return $menu_obj;
|
||||
}
|
||||
|
||||
/**
|
||||
* Check if the given ID is a nav menu.
|
||||
* Check if the given ID is a navigation menu.
|
||||
*
|
||||
* Returns true if it is; false otherwise.
|
||||
*
|
||||
|
|
@ -65,7 +64,7 @@ function is_nav_menu( $menu ) {
|
|||
}
|
||||
|
||||
/**
|
||||
* Register nav menus for a theme.
|
||||
* Register navigation menus for a theme.
|
||||
*
|
||||
* @since 3.0.0
|
||||
*
|
||||
|
|
@ -80,7 +79,7 @@ function register_nav_menus( $locations = array() ) {
|
|||
}
|
||||
|
||||
/**
|
||||
* Register nav menu for a theme.
|
||||
* Register a navigation menu for a theme.
|
||||
*
|
||||
* @since 3.0.0
|
||||
*
|
||||
|
|
@ -91,7 +90,7 @@ function register_nav_menu( $location, $description ) {
|
|||
register_nav_menus( array( $location => $description ) );
|
||||
}
|
||||
/**
|
||||
* Returns an array of all registered nav menus in a theme
|
||||
* Returns an array of all registered navigation menus in a theme
|
||||
*
|
||||
* @since 3.0.0
|
||||
* @return array
|
||||
|
|
@ -104,7 +103,7 @@ function get_registered_nav_menus() {
|
|||
}
|
||||
|
||||
/**
|
||||
* Returns an array with the registered nav menu locations and the menu assigned to it
|
||||
* Returns an array with the registered navigation menu locations and the menu assigned to it
|
||||
*
|
||||
* @since 3.0.0
|
||||
* @return array
|
||||
|
|
@ -129,16 +128,12 @@ function is_nav_menu_item( $menu_item_id = 0 ) {
|
|||
/**
|
||||
* Create a Navigation Menu.
|
||||
*
|
||||
* Optional args:
|
||||
* slug - the url friendly version of the nav menu.
|
||||
*
|
||||
* @since 3.0.0
|
||||
*
|
||||
* @param string $menu_name Menu Name
|
||||
* @param string $args Optional.
|
||||
* @return mixed Menu object on sucess|WP_Error on failure
|
||||
* @return mixed Menu object on success|WP_Error on failure
|
||||
*/
|
||||
function wp_create_nav_menu( $menu_name, $args = array() ) {
|
||||
function wp_create_nav_menu( $menu_name ) {
|
||||
$menu_exists = get_term_by( 'name', $menu_name, 'nav_menu' );
|
||||
|
||||
if ( $menu_exists )
|
||||
|
|
@ -151,12 +146,10 @@ function wp_create_nav_menu( $menu_name, $args = array() ) {
|
|||
|
||||
$result = get_term( $menu['term_id'], 'nav_menu' );
|
||||
|
||||
if ( $result && !is_wp_error($result) ) {
|
||||
if ( $result && !is_wp_error($result) )
|
||||
do_action( 'wp_create_nav_menu', $menu['term_id'] );
|
||||
|
||||
return $result;
|
||||
} else {
|
||||
return $result;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
@ -165,7 +158,7 @@ function wp_create_nav_menu( $menu_name, $args = array() ) {
|
|||
* @since 3.0.0
|
||||
*
|
||||
* @param string $menu name|id|slug
|
||||
* @return mixed Menu object on sucess|WP_Error on failure
|
||||
* @return mixed Menu object on success|WP_Error on failure
|
||||
*/
|
||||
function wp_delete_nav_menu( $menu ) {
|
||||
$menu = wp_get_nav_menu_object( $menu );
|
||||
|
|
@ -181,12 +174,10 @@ function wp_delete_nav_menu( $menu ) {
|
|||
|
||||
$result = wp_delete_term( $menu->term_id, 'nav_menu' );
|
||||
|
||||
if ( $result && !is_wp_error($result) ) {
|
||||
if ( $result && !is_wp_error($result) )
|
||||
do_action( 'wp_delete_nav_menu', $menu->term_id );
|
||||
|
||||
return $result;
|
||||
} else {
|
||||
return $result;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
@ -210,7 +201,9 @@ function wp_update_nav_menu_object( $menu_id = 0, $menu_data = array() ) {
|
|||
if ( is_wp_error( $_menu ) )
|
||||
return $_menu;
|
||||
|
||||
if ( $_menu && isset( $_menu->term_id ) ) {
|
||||
if ( ! $_menu || ! isset( $_menu->term_id ) )
|
||||
return 0;
|
||||
|
||||
$args = array(
|
||||
'description' => ( isset( $menu_data['description'] ) ? $menu_data['description'] : '' ),
|
||||
'name' => ( isset( $menu_data['menu-name'] ) ? $menu_data['menu-name'] : '' ),
|
||||
|
|
@ -227,9 +220,8 @@ function wp_update_nav_menu_object( $menu_id = 0, $menu_data = array() ) {
|
|||
! is_wp_error( $_possible_existing ) &&
|
||||
isset( $_possible_existing->term_id ) &&
|
||||
$_possible_existing->term_id != $menu_id
|
||||
) {
|
||||
)
|
||||
return new WP_Error( 'menu_exists', sprintf( __('The menu name <strong>%s</strong> conflicts with another menu name. Please try another.'), esc_html( $menu_data['menu-name'] ) ) );
|
||||
}
|
||||
|
||||
$update_response = wp_update_term( $menu_id, 'nav_menu', $args );
|
||||
|
||||
|
|
@ -237,9 +229,6 @@ function wp_update_nav_menu_object( $menu_id = 0, $menu_data = array() ) {
|
|||
return $menu_id;
|
||||
else
|
||||
return $update_response;
|
||||
} else {
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
@ -315,20 +304,18 @@ function wp_update_nav_menu_item( $menu_id = 0, $menu_item_db_id = 0, $menu_item
|
|||
$original_parent = (int) $original_object->post_parent;
|
||||
$original_title = $original_object->post_title;
|
||||
|
||||
if ( 'trash' == get_post_status( $args['menu-item-object-id'] ) ) {
|
||||
if ( 'trash' == get_post_status( $args['menu-item-object-id'] ) )
|
||||
return new WP_Error('update_nav_menu_item_failed', sprintf(__('The menu item "%1$s" belongs to something that is in the trash, so it cannot be updated.'), $args['menu-item-title'] ) );
|
||||
}
|
||||
}
|
||||
|
||||
if ( empty( $args['menu-item-title'] ) || $args['menu-item-title'] == $original_title ) {
|
||||
$args['menu-item-title'] = '';
|
||||
|
||||
// hack to get wp to create a post object when too many properties are empty
|
||||
if ( empty( $args['menu-item-description'] ) ) {
|
||||
if ( empty( $args['menu-item-description'] ) )
|
||||
$args['menu-item-description'] = ' ';
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Populate the menu item object
|
||||
$post = array(
|
||||
|
|
@ -362,7 +349,8 @@ function wp_update_nav_menu_item( $menu_id = 0, $menu_item_db_id = 0, $menu_item
|
|||
$args['menu-item-object'] = 'custom';
|
||||
}
|
||||
|
||||
if ( $menu_item_db_id && ! is_wp_error( $menu_item_db_id ) ) {
|
||||
if ( ! $menu_item_db_id || is_wp_error( $menu_item_db_id ) )
|
||||
return $menu_item_db_id;
|
||||
|
||||
$menu_item_db_id = (int) $menu_item_db_id;
|
||||
|
||||
|
|
@ -384,7 +372,6 @@ function wp_update_nav_menu_item( $menu_id = 0, $menu_item_db_id = 0, $menu_item
|
|||
delete_post_meta( $menu_item_db_id, '_menu_item_orphaned' );
|
||||
|
||||
do_action('wp_update_nav_menu_item', $menu_id, $menu_item_db_id, $args );
|
||||
}
|
||||
|
||||
return $menu_item_db_id;
|
||||
}
|
||||
|
|
@ -403,7 +390,6 @@ function wp_get_nav_menus( $args = array() ) {
|
|||
return get_terms( 'nav_menu', $args);
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* Sort menu items by the desired key.
|
||||
*
|
||||
|
|
@ -417,28 +403,22 @@ function wp_get_nav_menus( $args = array() ) {
|
|||
function _sort_nav_menu_items( $a, $b ) {
|
||||
global $_menu_item_sort_prop;
|
||||
|
||||
if ( empty( $_menu_item_sort_prop ) ) {
|
||||
if ( empty( $_menu_item_sort_prop ) )
|
||||
return 0;
|
||||
|
||||
if ( ! isset( $a->$_menu_item_sort_prop ) || ! isset( $b->$_menu_item_sort_prop ) )
|
||||
return 0;
|
||||
}
|
||||
|
||||
if ( isset( $a->$_menu_item_sort_prop ) && isset( $b->$_menu_item_sort_prop ) ) {
|
||||
$_a = (int) $a->$_menu_item_sort_prop;
|
||||
$_b = (int) $b->$_menu_item_sort_prop;
|
||||
|
||||
if ( $a->$_menu_item_sort_prop == $b->$_menu_item_sort_prop ) {
|
||||
if ( $a->$_menu_item_sort_prop == $b->$_menu_item_sort_prop )
|
||||
return 0;
|
||||
} elseif (
|
||||
( $_a == $a->$_menu_item_sort_prop ) &&
|
||||
( $_b == $b->$_menu_item_sort_prop )
|
||||
) {
|
||||
elseif ( $_a == $a->$_menu_item_sort_prop && $_b == $b->$_menu_item_sort_prop )
|
||||
return $_a < $_b ? -1 : 1;
|
||||
} else {
|
||||
else
|
||||
return strcmp( $a->$_menu_item_sort_prop, $b->$_menu_item_sort_prop );
|
||||
}
|
||||
} else {
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns all menu items of a navigation menu.
|
||||
|
|
@ -464,7 +444,8 @@ function wp_get_nav_menu_items( $menu, $args = array() ) {
|
|||
if ( empty( $items ) )
|
||||
return $items;
|
||||
|
||||
$defaults = array( 'order' => 'ASC', 'orderby' => 'menu_order', 'post_type' => 'nav_menu_item', 'post_status' => 'publish', 'output' => ARRAY_A, 'output_key' => 'menu_order', 'nopaging' => true,
|
||||
$defaults = array( 'order' => 'ASC', 'orderby' => 'menu_order', 'post_type' => 'nav_menu_item',
|
||||
'post_status' => 'publish', 'output' => ARRAY_A, 'output_key' => 'menu_order', 'nopaging' => true,
|
||||
'update_post_term_cache' => false );
|
||||
$args = wp_parse_args( $args, $defaults );
|
||||
if ( count( $items ) > 1 )
|
||||
|
|
@ -784,6 +765,5 @@ function _wp_auto_add_pages_to_menu( $new_status, $old_status, $post ) {
|
|||
wp_update_nav_menu_item( $menu_id, 0, $args );
|
||||
}
|
||||
}
|
||||
add_action( 'transition_post_status', '_wp_auto_add_pages_to_menu', 10, 3 );
|
||||
|
||||
?>
|
||||
|
|
|
|||
Loading…
Reference in New Issue