From 290dbc03e0319eb7df07e5bf578f250ea933287a Mon Sep 17 00:00:00 2001 From: ryan Date: Tue, 17 Jun 2008 03:07:42 +0000 Subject: [PATCH] Don't do sizeof() in a loop. Props DD32. see #7147 git-svn-id: http://svn.automattic.com/wordpress/trunk@8111 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/classes.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/wp-includes/classes.php b/wp-includes/classes.php index a454befb9..43918da3c 100644 --- a/wp-includes/classes.php +++ b/wp-includes/classes.php @@ -429,7 +429,8 @@ class Walker { if ( $max_depth == 0 || ($max_depth != 0 && $max_depth > $depth+1 )) { //whether to descend - for ( $i = 0; $i < sizeof( $children_elements ); $i++ ) { + $num_elements = sizeof( $children_elements ); + for ( $i = 0; $i < $num_elements; $i++ ) { $child = $children_elements[$i]; if ( $child->$parent_field == $element->$id_field ) { @@ -442,6 +443,7 @@ class Walker { } array_splice( $children_elements, $i, 1 ); + $num_elements--; $this->display_element( $child, $children_elements, $max_depth, $depth + 1, $args, $output ); $i = -1; }