f62e1997f5
The padding-top of the orange notification set in ext.echo.styles.alert.less was being overriden by the `padding-top: 0` set in UserLinks.less which was intended to only override the padding set in Menu.less. This commit: * Scopes the li styles in Menu.less to apply only to the legacy user menu (found in both legacy and modern vector with the consolidated user links feature off) which appears to be the only menus that needs these rules. * The padding-top previously in UserLinks is no longer needed as a result of the above point. * Adjusts/cleans up the positioning of the orange notification by removing an unneeded margin/padding-top and setting the top to 100% (the previous `calc` statement was unintentionally resulting in 112%). Bug: T287633 Change-Id: Ia7069d291f53d8e0e0e576d7b96b7a8b1a6cb29d |
||
|---|---|---|
| .phan | ||
| .storybook | ||
| dev-scripts | ||
| i18n | ||
| includes | ||
| resources | ||
| screenshots | ||
| skinStyles | ||
| stories | ||
| tests | ||
| .eslintignore | ||
| .eslintrc.json | ||
| .gitignore | ||
| .gitreview | ||
| .nvmrc | ||
| .phpcs.xml | ||
| .stylelintignore | ||
| .stylelintrc.json | ||
| .svgo.config.js | ||
| CODE_OF_CONDUCT.md | ||
| COPYING | ||
| Doxyfile | ||
| README.md | ||
| bundlesize.config.json | ||
| composer.json | ||
| jsdoc.json | ||
| package-lock.json | ||
| package.json | ||
| skin.json | ||
| tsconfig.json | ||
README.md
Vector Skin
Installation
See https://www.mediawiki.org/wiki/Skin:Vector.
Configuration options
See skin.json.
Development
Node version
It is recommended to use nvm to use the version of node defined
in .nvmrc during local development. This ensures consistency amongst development environments.
Coding conventions
We strive for compliance with MediaWiki conventions:
https://www.mediawiki.org/wiki/Manual:Coding_conventions
Additions and deviations from those conventions that are more tailored to this project are noted at:
https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions
URL query parameters
useskinversion: Likeuseskinbut for overriding the Vector skin version user preference and configuration. E.g., http://localhost:8181?useskin=vector&useskinversion=2.
Skin preferences
Vector defines skin-specific user preferences. These are exposed on
Special:Preferences when the VectorShowSkinPreferences configuration is
enabled. The user's preference state for skin preferences is used for skin
previews and any other operation unless specified otherwise.
Version
Vector defines a "version" preference to enable users who prefer the December
2019 version of Vector to continue to do so without any visible changes. This
version is called "Legacy Vector." The related preference defaults are
configurable via the configurations prefixed with VectorDefaultSkinVersion.
Version preference and configuration may be overridden by the useskinversion
URL query parameter.
Pre-commit tests
A pre-commit hook is installed when executing npm install. By default, it runs
npm test which is useful for automatically validating everything that can be
in a reasonable amount of time. If you wish to defer these tests to be executed
by continuous integration only, set the PRE_COMMIT environment variable to 0:
$ export PRE_COMMIT=0
$ git commit
Or more succinctly:
$ PRE_COMMIT=0 git commit
Skipping the pre-commit tests has no impact on Gerrit change identifier hooks.
Hooks
See hooks.txt.