6998c536d4
Since we have feature flagged the new user menu feature, it is imperative we load both sets of styles until the feature has shipped. This allows us to switch seamlessly between the two without worrying about cached HTML being served with updated CSS. To do this, we add a new class to both user menu's distinguishing the legacy version from the modern version. The styles are then scoped to these new selectors. This also fixes some regressions with the legacy user menu in modern Vector when wgVectorConsolidateUserLinks is disabled. Notes: * No caching selector is needed for #pt-userpage given it can only ever be output for logged in users. * ID selectors in general are bad, so scoping to mw-portlet-personal-user-menu-legacy isolates the legacy component allowing it to be rendered alongside the modern UserMenu Bug: T276561 Change-Id: I068c5233bb25a7b141e66a6726b5761841f83eb2
119 lines
3.2 KiB
PHP
119 lines
3.2 KiB
PHP
<?php
|
|
namespace MediaWiki\Skins\Vector\Tests\Integration;
|
|
|
|
use MediaWikiIntegrationTestCase;
|
|
use RequestContext;
|
|
use SkinVector;
|
|
use Title;
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
/**
|
|
* Class VectorTemplateTest
|
|
* @package MediaWiki\Skins\Vector\Tests\Unit
|
|
* @group Vector
|
|
* @group Skins
|
|
*
|
|
* @coversDefaultClass \SkinVector
|
|
*/
|
|
class SkinVectorTest extends MediaWikiIntegrationTestCase {
|
|
|
|
/**
|
|
* @return \VectorTemplate
|
|
*/
|
|
private function provideVectorTemplateObject() {
|
|
$template = new SkinVector( [ 'name' => 'vector' ] );
|
|
return $template;
|
|
}
|
|
|
|
/**
|
|
* @param string $nodeString an HTML of the node we want to verify
|
|
* @param string $tag Tag of the element we want to check
|
|
* @param string $attribute Attribute of the element we want to check
|
|
* @param string $search Value of the attribute we want to verify
|
|
* @return bool
|
|
*/
|
|
private function expectNodeAttribute( $nodeString, $tag, $attribute, $search ) {
|
|
$node = new \DOMDocument();
|
|
$node->loadHTML( $nodeString );
|
|
$element = $node->getElementsByTagName( $tag )->item( 0 );
|
|
if ( !$element ) {
|
|
return false;
|
|
}
|
|
|
|
$values = explode( ' ', $element->getAttribute( $attribute ) );
|
|
return in_array( $search, $values );
|
|
}
|
|
|
|
/**
|
|
* @covers ::getTemplateData
|
|
*/
|
|
public function testGetTemplateData() {
|
|
$title = Title::newFromText( 'SkinVector' );
|
|
$context = RequestContext::getMain();
|
|
$context->setTitle( $title );
|
|
$context->setLanguage( 'fr' );
|
|
$vectorTemplate = $this->provideVectorTemplateObject();
|
|
$this->setTemporaryHook( 'PersonalUrls', [
|
|
static function ( &$personal_urls, &$title, $skin ) {
|
|
$personal_urls = [
|
|
'pt-1' => [ 'text' => 'pt1' ],
|
|
];
|
|
}
|
|
] );
|
|
$this->setTemporaryHook( 'SkinTemplateNavigation', [
|
|
static function ( &$skinTemplate, &$content_navigation ) {
|
|
$content_navigation['actions'] = [
|
|
'action-1' => []
|
|
];
|
|
$content_navigation['namespaces'] = [
|
|
'ns-1' => []
|
|
];
|
|
$content_navigation['variants'] = [
|
|
'variant-1' => []
|
|
];
|
|
$content_navigation['views'] = [];
|
|
}
|
|
] );
|
|
$openVectorTemplate = TestingAccessWrapper::newFromObject( $vectorTemplate );
|
|
|
|
$props = $openVectorTemplate->getTemplateData()['data-portlets'];
|
|
$views = $props['data-views'];
|
|
$namespaces = $props['data-namespaces'];
|
|
|
|
$this->assertSame(
|
|
[
|
|
// Provided by core
|
|
'id' => 'p-views',
|
|
'class' => 'mw-portlet mw-portlet-views emptyPortlet vector-menu vector-menu-tabs',
|
|
'html-tooltip' => '',
|
|
'html-items' => '',
|
|
'html-after-portal' => '',
|
|
'label' => $context->msg( 'views' )->text(),
|
|
'heading-class' => 'vector-menu-heading',
|
|
'is-dropdown' => false,
|
|
],
|
|
$views
|
|
);
|
|
|
|
$variants = $props['data-variants'];
|
|
$actions = $props['data-actions'];
|
|
$this->assertSame(
|
|
'mw-portlet mw-portlet-namespaces vector-menu vector-menu-tabs',
|
|
$namespaces['class']
|
|
);
|
|
$this->assertSame(
|
|
'mw-portlet mw-portlet-variants vector-menu vector-menu-dropdown',
|
|
$variants['class']
|
|
);
|
|
$this->assertSame(
|
|
'mw-portlet mw-portlet-cactions vector-menu vector-menu-dropdown',
|
|
$actions['class']
|
|
);
|
|
$this->assertSame(
|
|
'mw-portlet mw-portlet-personal vector-user-menu-legacy vector-menu',
|
|
$props['data-personal']['class']
|
|
);
|
|
}
|
|
|
|
}
|