Commit Graph

62 Commits

Author SHA1 Message Date
Timo Tijhof 1f26153a5d collapsibleTabs: Clean up and simplify code
* Rename 'rtl' to 'isRTL' and use DOM to compute its value.
* Document code with JSDuck similar to other extensions.
* Remove unused 'prevElement' property. Not used in Vector
  nor anywhere else in Wikimedia Git.
* Make 'boundEvent' property private. Not used anywhere in
  Wikimedia Git outside this file.

* Simplify 'instances' tracking.
  The jQuery object stored in this property wasn't used beyond
  calling each(). Convert to a plain array.
  Preserve and re-use the jQuery object first created
  by collapsibleTabs().

* Simplify calculateTabDistance() by using getElementById() and
  getBoundingClientRect(). Its support includes IE 5.
  The "new" version (since Firefox 3.5 and IE 9) also includes
  'height' and 'width' properties and is supported in all
  browsers supported by the MediaWiki 1.28 startup feature test.

  This helps avoid code in offset() and width(), which is fairly
  expensive in jQuery 1.x.

* moveToCollapsed()
  - Remove redundant jQuery object creation (only caller passes a
    jQuery object already).
  - Remove redundant re-receiving of expContainerSettings inside
    the animate() callback. Already in the main scope.
    Relates to a bunch of patches that work around a problem
    caused by use of remove() instead of detach() in an earlier
    version of the code. Which was only a problem because the
    other settings object was also not used from the main scope.
    (See pre-Gerrit commits 1f93310e and e7900807.)

Change-Id: I48d542580d767df2d17ce4c6668e9e233a0f7902
2016-11-29 02:25:00 +00:00
Paladox 43207bb62d Update three packages
Update grunt-contrib-jshint to 1.0.0

Update grunt-banana-checker to 0.5.0

Update grunt-jscs to 2.8.0

Change-Id: I2875efab17acc9007725f1e79b9353cb8b0ceb3f
2016-03-30 22:36:42 +01:00
Paladox 0f7f31f519 Update grunt-jscs to 2.6.0
Change-Id: I765880ee81a466f302dd677372e32ad0a3ff302e
2016-01-19 14:26:27 +00:00
Paladox 76b668eaf5 Update grunt-jsonlint to 1.0.7 and MW codesniffer to 0.5.1
Change-Id: If8c4cc68156467746a679144039b978fe0247401
2015-12-29 11:33:41 +00:00
Paladox f43716fcfe Update grunt-jscs to 2.5.0
Change-Id: I79bda05766997f4bb73b8948215ed1b41c3e2d49
2015-12-09 22:13:37 +00:00
Paladox a4134557e9 Update packages
Update grunt-jscs to 2.3.0

Update grunt-jsonlint to 1.0.6

Add new jscs-preset-wikimedia package.

Change-Id: Ie175abf1d692dac78afe02b2d70867c1369353b4
2015-11-07 17:45:46 +00:00
Paladox 6aef338da9 Update grunt-jscs to 2.2.0
Change-Id: I9452e2c89030e7d5d391bda9fdc73e09b4392c09
2015-10-26 19:09:11 +00:00
Paladox b0f69b2dc4 Update grunt-banana-checker to 0.4.0
Difference between 0.2.2 and 0.4.0

0.4.0

* Make disallowUnusedTranslations default to false (Ed Sanders)
* Make disallowDuplicateTranslations default to false (Ed Sanders)
* build: Remove use of global grunt-cli (Timo Tijhof)
* build: Add Node.js v0.12 and v4.0 (Timo Tijhof)
* tests: Migrate Travis to container-based infrastructure (James D.
* Forrester)
* readme: Add line break between images and h1 (Timo Tijhof)

0.3.0

* Fail if the target directory doesn't exist (James D. Forrester)
* Allow individual checks to be disabled in config (James D. Forrester)
* Be able to require complete translations, or specific messages in all
* translations (James D. Forrester)
* build: Bump grunt-jscs to latest version (James D. Forrester)
* Enforce disallowBlankTranslations, disallowDuplicateTranslations and
* disallowUnusedTranslations (James D. Forrester)

Change-Id: I68c5c747d2f92fdedd7e4450f618f577f493fb4a
2015-10-22 00:55:15 +01:00
paladox 95ef8f2cc6 Update jscs to 2.1.0
Change-Id: Ibba453510c8e15c3e915d28f7ecf7c296bca7894
2015-10-22 00:38:01 +01:00
Paladox fabd6209fe Update grunt-jsonlint to 1.0.5
Change-Id: Ie5f30e6a95fb0a185f74caf6c89dd1a77a507acd
2015-10-19 21:47:57 +01:00
James D. Forrester 3f3bde51c8 build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue
Change-Id: I768203d6fbdf47bcc845a301a883e84b0c743c2e
2015-09-03 14:14:23 -07:00
Kunal Mehta 1a3fb084ba build: Configure jshint, jsonlint, banan-checker & jscs
Change-Id: Ifab90f787bd2c4d8539698c3828c3486a3559bdb
2015-06-25 23:35:53 +00:00