VectorGOLEM

Commit Graph

Author	SHA1	Message	Date
jdlrobson	87f08dcf5b	[refactor] Drop form-id template property In preparation for using the SkinMustache class and core buildSearchProps method [1], and to reduce the risk of that change, move the ID from the template data to the template itself: [1] https://github.com/wikimedia/mediawiki/blob/master/includes/skins/SkinMustache.php#L93 Change-Id: I8d62ea6b1adf6ef0cbfa20e1876806eba70b169f	2020-06-25 18:21:38 +00:00
jdlrobson	df2895f610	Cleanup: Use consistent naming in SearchBox We have conventions about template variable naming. * Drop camel case * Prefix message keys with `msg-` followed by message key name * Prefix HTML with `html-` Change-Id: I34f04f3d217dc8caa4dcc29e60058951a6555b1e	2020-06-01 20:11:14 +00:00
Stephen Niedzielski	9d427dcb30	[Hygiene] [Mustache] rename SearchComponent to SearchBox For consistency with VectorTabs, rename SearchComponent to only imply component. At least two word names seems like a good target (instead of just "Search") for grepability and standard component style conventions. Bug: T239248 Change-Id: I1e4f7270ba29c2f35f08e92f8a28cd8a2ec8fe87	2019-12-06 17:00:42 -07:00

Author

SHA1

Message

Date

jdlrobson

87f08dcf5b

[refactor] Drop form-id template property

In preparation for using the SkinMustache class and
core buildSearchProps method [1],
and to reduce the risk of that change,
move the ID from the template
data to the template itself:

[1] https://github.com/wikimedia/mediawiki/blob/master/includes/skins/SkinMustache.php#L93

Change-Id: I8d62ea6b1adf6ef0cbfa20e1876806eba70b169f

2020-06-25 18:21:38 +00:00

jdlrobson

df2895f610

Cleanup: Use consistent naming in SearchBox

We have conventions about template variable naming.

* Drop camel case
* Prefix message keys with `msg-` followed by message key name
* Prefix HTML with `html-`

Change-Id: I34f04f3d217dc8caa4dcc29e60058951a6555b1e

2020-06-01 20:11:14 +00:00

Stephen Niedzielski

9d427dcb30

[Hygiene] [Mustache] rename SearchComponent to SearchBox

For consistency with VectorTabs, rename SearchComponent to only imply
component. At least two word names seems like a good target (instead of
just "Search") for grepability and standard component style conventions.

Bug: T239248
Change-Id: I1e4f7270ba29c2f35f08e92f8a28cd8a2ec8fe87

2019-12-06 17:00:42 -07:00

3 Commits