Commit Graph

166 Commits

Author SHA1 Message Date
Bartosz Dziewoński 6b6c6ba762 Remove some unnecessary direction-specific CSS
Both of these survived across many rewrites, I tracked down the
original commits that added them:

* footer.less: Added in 6d5dca5a899d45512c1031c4235f26cc755b933b in
  MediaWiki core (rSVN62030) as a workaround for "weirdness" in IE 7.
  Users of IE 7 experience much worse weirdnesses when viewing pages
  these days.

* tabs.less: Added in 299d1f328c2ad1475c8a1ac19b4fa07fc087d239 in
  MediaWiki core (rSVN53247) under a generic label of "RTL fixes".
  After change 5d0a07bf9d this is
  actually a no-op.

Change-Id: Iac3d2a26438226a3e23e067780c4b2810ac4903f
2017-09-28 13:22:53 +00:00
Bartosz Dziewoński ee0cfe1833 Remove stray unnecessary @noflip
Follow-up to 5d0a07bf9d.
As it happens, it actually doesn't matter whether this
element has 'float: left' or 'float: right', the
rendering is exactly the same. Let's remove the @noflip
for consistency with .vectorTabs, .vectorMenu etc.

Change-Id: I167c5f6cab7fb85344a558b632b38cbca85fa37c
2017-09-28 04:23:07 +02:00
Bartosz Dziewoński e951a09913 Fix reversed nav elements when viewing cached HTML
Follow-up to 5d0a07bf9d.
See T48947#3641618 for a detailed explanation of the
problem this is fixing. Essentially, our CSS has to be
compatible with both new and old HTML to avoid problems
with cached pages on Wikimedia wikis. To do this, we
add a CSS class to the body and make the new CSS only
apply on pages that have this class. This patch should
be reverted when the caches expire.

Bug: T48947
Change-Id: Icf26e6690b59f470765b2634534d18d2df25ee2a
2017-09-28 04:23:01 +02:00
Rammanoj 5d0a07bf9d Vector: Flip horizontal nav elements with CSS
Flip horizontal nav elements with CSS prperties in RTL(right-to-left) mode

Bug: T48947
Change-Id: I30a5837f84bcdeab205760644bfa40b12cefbece
2017-09-26 10:30:11 -05:00
Mukunda Modell e70a1d38b9 Consolidate duplicate CSS properties
I really should not have merged I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
without getting this fixed first.

Bug: T56919
Change-Id: I870591e63b89f05d7e3714081340c76dcf9f55ac
2017-09-22 21:06:28 +00:00
jenkins-bot 765a143a60 Merge "Tabs (Read / View Source / Search) collapsed under more in resolution < 700px" 2017-09-21 20:21:01 +00:00
Rammanoj f74002b727 Tabs (Read / View Source / Search) collapsed under more in resolution < 700px
tabs such as read/view source are collapsed into more in screens
whose resolution is less than 700 px so that they don't wrap to
the next line and cover the content of the page

Bug: T56919
Change-Id: I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
2017-09-21 20:03:39 +00:00
Bartosz Dziewoński 206efa4c96 Make dropdown menus appear above VisualEditor toolbar
Bug: T171840
Change-Id: I36dc747ec2c41816df371aa5e1d4b81dff24a7dd
2017-08-03 01:27:05 +02:00
Volker E 7a42af066b Remove irritating transition on menu tabs
Removing irritating dropdown arrow position transition
on menu tabs. It is the only place we're using this and it seems obscure
and not helpful to the users from UI Standardization point of view.

Bug: T68698
Change-Id: I8d30108b86b47358349de2ea424c0ba7f67ee7e2
2017-07-20 21:20:59 +00:00
golopot 3f19c24696 Fix misaligned menu tabs
Ensure vertical alignment of menu tabs (for example “More” button) 
with link-only tabs by setting:

* `padding-top: 1.25em;` as on `div.vectorTabs span a`
* `line-height: 1.125em;` as on `div.vectorTabs ul li`

Bug: T171142
Change-Id: Ic4ef86589c6c3d442035f3d768cb9036e1ecc237
2017-07-20 14:14:15 +00:00
golopot ffc0837bf3 Remove `position: absolute` from #p-logo element
This was inherited from Monobook (r2881, b52a2a1567).

The #mw-panel (sidebar) was at `top: 160px`.
The #p-logo was at `top: -160px`.
This looks hacky so I set #mw-panel `top: 0`.

Bug: T170053
Change-Id: Ifb99ff36e3a9c530c944df2ea0a6c75759045c1c
2017-07-13 16:28:08 +08:00
Fomafix 56ec1a3c87 Remove <div> inside of the <h3>
The <div> was introduced in aba11a7b but this is not valid in HTML 5.

This change ommits the <div> and attaches the background image to the
existing <span>.

Cached HTML with the <div></div> does not matter for the result.

Bug: T169551
Change-Id: I04f7032b6f6bafe10548fde690f55de66b56f61f
2017-07-12 06:21:51 +02:00
jenkins-bot 40699a9a28 Merge "Remove unused selectors for action menu" 2017-07-11 23:45:36 +00:00
Fomafix 5c363643a7 Remove unused selectors for action menu
This change is a follow-up to aba11a7b1c.
Do not deploy this change until HTML cache from before aba11a7b1c expired.

Change-Id: I631260d58229b1b70e2d4e55f8302f9769de3511
2017-07-11 02:59:14 +00:00
Ed Sanders b85dd78e0f Use same left margin (0.5em/8px) for all sidebar items
Bug: T168598
Change-Id: Ice96ba4b7d0af3312baff69a6bb4c34e6e12c205
2017-06-22 12:08:54 -07:00
jenkins-bot c3f5aea44b Merge "Use <div> instead of <a> for action menu" 2017-06-21 21:50:52 +00:00
Jack Phoenix d575e3878a Optimization: move styles specific to redirect pages out of common.less
HT MatmaRex

Change-Id: I6169692547378379dbc935976ad83cf4f366eeeb
2017-06-15 16:13:42 +03:00
Fomafix aba11a7b1c Use <div> instead of <a> for action menu
This change prevents that a middle click opens a new tab with the URL "#" and
prevents a wired outline around the button when selected of focused in Chrome.

The selector "> a" will be removed in a separate change which must get
deployed not before the HTML cache has expired.

Bug: T44241
Bug: T68388
Change-Id: I7255552d3bdec9e40727721b91630623ae24a08b
2017-06-06 08:02:49 +02:00
Arlo Breault dcd01fc1e2 Separate some shared layout with Parsoid
* This is in service of T116508.  See
   Id41c1d2840f441eddb14ca66ba545ee7b160088e where .mw-body is being
   removed from Parsoid content.

 * This is only possible since T155863

Change-Id: I60e3cb3e838fa19d321c4eac0a6828bcfddb6f3e
2017-04-17 14:14:36 -04:00
Rammanoj 7631b496c0 Proper indentation applied to horizontal links in the vector skin
Bug: T67444
Change-Id: I5dc48995583a0e0bd3d8bee6e698effecc4d3f7f
2017-03-29 17:21:40 +00:00
Ed Sanders d183c39d06 Allow edit sections outside of mw-body-content
Bug: T160269
Change-Id: Ib4830cde634b6ca0c3ceb0ba06831c3b4ccedfbd
2017-03-12 11:14:37 +00:00
jenkins-bot 4ab8dc17bc Merge "Align text and border colors to WikimediaUI color palette" 2017-03-10 22:24:39 +00:00
Ed Sanders 24802a3aaf Move heading, paragraph and editsection styles into mw-body-content
Bug: T155863
Bug: T155774
Change-Id: I4c907bd48d472c970b79a7a234c2079254567a7e
2017-03-07 17:52:23 +00:00
Ed Sanders 44473d2a2b Change mw-body ancestor selector to mw-body-content and add to siteNotice
Bug: T155863
Bug: T159578
Change-Id: I036d4def3f61d4a604c804c5368d74ec74883d2e
2017-03-03 22:32:09 +00:00
Volker E 463d95a356 Align text and border colors to WikimediaUI color palette
Aligning some text and border colors (all greyscale) to WikimediaUI color
palette and also add toolbar `box-shadow` to “More” menu dropdown
following standard pattern.

Bug: T153043
Change-Id: Ic3247ce29059ea7d7f59a99ca742334600d85ce6
2017-03-02 17:23:52 -08:00
Ed Sanders 53cabcfe66 Use new placeholder mixin
Also fix site search to use use the same shade of grey
as is used in OOUI and mw-ui.

Depends-On: I96686bb53cee1a833db8f4d0b691d5e4a1b82885
Change-Id: Ib6437b13760e8c13d06927cb45ef674a5f301e35
2017-02-23 16:37:16 +00:00
James D. Forrester 298af67c06 build: Bump stylelint and make pass
grunt-stylelint              0.6.0  →   0.7.0
 stylelint-config-wikimedia   0.3.0  →   0.4.1

Change-Id: Id87b8df04d415e1f1058a4042a31408236402037
2017-02-17 16:34:04 -08:00
Ed Sanders f7d8d036ac build: stylelint more files
Change-Id: If62fa6ff9810de253b65feb1f7e312d22e33bfa8
2017-01-23 15:04:05 +00:00
pppery 3621078abf Specify height of tabs
This fixes the display of the tabs when `box-sizing: border-box` is
specified in local CSS. Previously, they were shifted upwards and shrunk
slightly.

Bug: T104767
Change-Id: I04333300bd1d29003e609091e0f64a73489f04c6
2016-12-14 15:43:43 -05:00
Bartosz Dziewoński 9452689791 search.less: Use only one background-image for overlaid buttons
Bug: T145928
Change-Id: If701930e469283c969e9a8a16574fa1a96cd502f
2016-09-18 16:09:13 +02:00
Volker E 1f8e54b6a0 Make `role=search` heading and label accessible
Making `role=search` heading and label accessible by using
`.mixin-screen-reader-text` instead of `display: none;`.

Bug: T139427
Change-Id: Ia54fcc2b19854315a2f0c26a1596b32019a42c1b
2016-07-07 14:35:17 +02:00
nirzar 211660e6b0 Allow an alternate, generic header font to be specified for certain languages
Introducing variable `@content-heading-font-family-generic`, that may be
used to specify an alternate font for `h1` and `h2` for languages which
render poorly using the standard heading font stack.
Set it for now on JA, HE and KO languages, based on reported issues.

Bug: T73240
Change-Id: I5217a7947427055f4cb61185d9d7d79848605dd3
2016-07-06 12:30:04 +02:00
Timo Tijhof 600abc4103 Make vectorMenu expand as tabs in IE6
Right now, Vector loads the csshover.htc extension in order to
emulate CSS :hover support in IE6.

This commit makes the vectorMenu expand as basic tabs instead.
Thus allowing us to remove the csshover.htc extension.

Note that the "page action" vector menu (p-cactions) is only created if it
contains items. By default, the only actions in this menu are actions for
logged-in users. For logged-out users, the menu isn't even on the page.

The tabs aren't pretty, but they don't look broken either.

Change-Id: Ibf2332ab0a0d9d7ba3ec03665ad61ca287750ad3
2016-03-01 23:16:34 +00:00
Derk-Jan Hartman 3ca33440f4 .redirectMsg needs to be 0 height
It wasn't because ".mw-body p" introduces a margin, causing an
undesired extra spacing on redirect pages.

Change-Id: I53f63703b086ff6b28c1fb5325ee6693e3322390
2016-01-26 20:12:40 +01:00
This, that and the other 5a10091acc Make "Not logged in" gray text WCAG AA compliant
Follows up 9285a2ae91.

Change-Id: I92157a694d46e198538c1279abd4e37f2abb4bbf
2015-12-10 20:47:13 +11:00
Timo Tijhof 9285a2ae91 Make placeholder in logged-out personal bar greyed out
Follows-up ea335eb55d.

Bug: T112724
Change-Id: Ic943b10c3656a3dad7add9a1f67492f184beeeed
2015-12-09 19:20:01 +00:00
Derk-Jan Hartman 35bfc07b46 Viewport dependant sizing of the search field
Already live on English Wikipedia

Bug: T117316
Change-Id: I11c44a71cab8cb36050313621da54ffa64320ccf
2015-10-31 13:43:08 +01:00
Ori Livneh 2807232513 Use underscore hack to set IE6-only style, rather than `!ie`
An alternate LESS compiler library that I am evaluating
(https://github.com/oyejorge/less.php) barfs on the '!ie' syntax, but tolerates
the underscore hack.

Change-Id: Iaf5c7e0faa0323258967b2ff76e68e9080116559
2015-09-10 14:17:12 -07:00
Ori Livneh 441922e922 Add missing semicolon to import stmt
Change-Id: I8f3cc67d087fd14a8891cd2a17817b7882d72328
2015-09-10 13:58:53 -07:00
Florian 620dec451b More-menu needs to overlap indicators
Indicators potentially can be overlap the area for the menu overlay,
which then overlaps it. Avoid it by raise the z-index for div.menu,
too.

Bug: T89410
Change-Id: Ie505d29a27aba2e8be5d5b13209442ec6daebcd9
2015-07-16 18:40:22 +00:00
Volker E 171fbc1512 Removing obsolete `-moz-inline-block` property
Bug: T103605
Change-Id: I97787abc8683f34db3f2063434578ecfdb019ecb
2015-06-24 21:16:53 +01:00
Erwin Dokter 35ca341ed4 Minor header fixes for Typography Refresh
This fixes top-margin for H1 inside .mw-body-content, and increase
font-size for H3 from 1.17em to 1.2em (bumping to 17px default).

Final patch for this bug.

Bug: T66653
Change-Id: I1e75bc4fc3e04ca6c9238d4ce116136e9bafacd1
2015-05-23 12:07:14 +00:00
Bartosz Dziewoński 16e16eb075 Don't use JavaScript to style first sidebar portlet
We were adding a .first CSS class to the portlet from JavaScript
instead of just using a smarter selector, which caused the incorrectly
styled portlet to visibly flash sometimes.

This was only useful for IE 6 (even IE 7 supports the sibling selector
'+', which we can use here), and we don't serve JavaScript to it
anymore. It would be neater to use ':first-of-type', but that's not as
widely supported.

Bug: T89542
Change-Id: I1904b3899c43bca52a6c996b8ce08c8bdf764aa0
2015-02-15 00:43:55 +00:00
paladox eea9966d5c Add SVG version of bullet-icon and use .list-style-image-svg()
* Adds bullet-image.svg

* Depends on I09319e9188878c in MediaWiki core

Edokter idea.

Bug: T37338
Change-Id: If380fcca663859d1bb688bb621c267b815b3e21a
2015-02-12 23:00:10 +00:00
jenkins-bot 98f9b318ad Merge "Revert "Add svg image of bullet"" 2015-01-19 09:51:56 +00:00
Bartosz Dziewoński 32eaf1b209 Revert "Add svg image of bullet"
Turns out this doesn't actually work well. Who'd have thunk?

This reverts commit a6235ceb88.

Bug: T37338
Change-Id: I3dcb8e8453a110d2b631711057712ac858dc42c1
2015-01-19 09:51:27 +00:00
jenkins-bot 7e84bb9525 Merge "Remove CSS transition on window resize" 2015-01-16 22:04:49 +00:00
Bartosz Dziewoński 4cec8a7058 Remove CSS transition on window resize
They do more harm than good.

We still have the "HD" and "non-HD" styles, just no smooth transitions
between them.

Bug: T85614
Change-Id: I52dd9883eb4e7df00f0613182d4adaa3f28fe5b7
2015-01-15 14:30:02 -08:00
paladox a6235ceb88 Add svg image of bullet
* Adds svg version of bullet.
* It has a hack in css so that png will be targeted at ie 8 or lower.
* There was no way around it since list-style-image carnt be used twice. The hack adds \9 to end of png file.

Edokter suggested to use \9

Note this has been tested

Bug: T37338
Change-Id: I795c31a68c383b8fc4557ee00312a5b1aecd09a3
2015-01-11 17:27:13 +00:00
jenkins-bot 2427cfdb12 Merge "Remove 'margin-left: -1px;' on "More" menu" 2014-12-16 19:09:42 +00:00
Legoktm 6cbbb23cde Revert "Replace desktop watchstar icon with mobile skin one"
Based on the discussion on T56307, this change is controversial
and not necessarily wanted. In summary:

* Green star looks out of place with blue Vector (Edokter, Esanders, Trevor)
* Clashes with WikiLove heart icon (Edokter)
* Flat design doesn't fit with Vector's gradient style (Rillke)
* Green means constructive in MediaWiki UI, however clicking the
  green star removes a page from your watchlist (Krinkle)

This reverts commit 56825d209e.

Change-Id: I46f75a0eb83f9643fc0b51befe02aad4a84efc4e
2014-12-16 18:22:27 +00:00
Bartosz Dziewoński 966c27a9b6 Remove 'margin-left: -1px;' on "More" menu
This rule doesn't seem to be necessary and interferes with width
measurements, causing the tabs to bounce back and forth at specific
screen sizes.

Bug: T74089
Change-Id: I6a05ccf6eea1a4af22d8df3dd4d507cf9ac1b5f3
2014-12-16 17:42:18 +01:00
m4tx 56825d209e Replace desktop watchstar icon with mobile skin one
Also, replaces the old animation with the same as in the mobile skin.

Bug: T56307
Change-Id: Ida98e080dd26b0354884eee2af3269c6228e3a75
2014-12-08 23:04:22 +00:00
Fomafix df10f03a7a Give .mw-body-content its own stacking context (z-index: 0)
This avoids that elements in the content can overlap elements
outside the content area (e.g. software and skin interface components),
such as the page action menu.

Bug: T40848
Change-Id: Ia986434c51d8db738726f3a4e918bce373bd3d6b
2014-12-07 20:26:54 +00:00
jenkins-bot 8437d301e8 Merge "Add support for page status indicators" 2014-10-27 20:23:28 +00:00
Bartosz Dziewoński cb1eb7ab2d common.less: Remove dead code
This does nothing since 7dc4b5861589f2cef472195273c41a86083f69d4 in core.

Change-Id: I879d96fe8d4034b6365c6b6af3d9e3615dd1c506
2014-09-30 14:40:49 +02:00
Bartosz Dziewoński deac602863 Add support for page status indicators
Corresponding patch in core: I2389ff9a5332a2b1d033eb75f0946e5241cfaaf4.

Bug: 23796
Change-Id: I90a8ae15ac8275d084ea5f47b6b2684d5e6c7412
2014-09-30 14:37:35 +02:00
Bartosz Dziewoński c85c4ee1ae Revert "Add svg version of bullet-icon"
The generated CSS is invalid, as you can't have multiple
list-style-images (unlike background-images). Browsers
either ignore the invalid properties with linear-gradient
and use non-embedded PNG fallback (Chrome, Firefox, modern
IE), or accept the properties but ignore everything after
the comma, using the fully transparent gradient (Opera). 

This reverts commit 32e65050a6.

Change-Id: I46abf1502c1e4e3dfe03f0c17c553b9fe7fe007d
2014-09-13 13:10:56 +00:00
paladox 32e65050a6 Add svg version of bullet-icon
* This add support for bullet in svg.

Note: This requires Iffff2bc52e1572e661930242ad15937bc83abace to be
approved

Note: This has been tested by me.

Change-Id: I5196952088e584d3121600e9e829647e8c195bbb
2014-09-12 23:27:55 +00:00
Rob Moen 8d1ca663d6 Make profile icon gender neutral and remove from login link in Vector
See https://trello.com/c/NbPpjduW/565-update-user-icon-in-vector

Bug: 41484
Bug: 45056
Change-Id: I62c9aef54bde85c236bf8b2fb0458b4a3fe0dcf2
2014-09-12 12:29:29 -07:00
jenkins-bot 3b44f27c71 Merge "search.less: Use static width for the search button" 2014-08-29 23:47:55 +00:00
jenkins-bot 3aa4ed74b7 Merge "Use .mw-body instead of div#content" 2014-08-28 17:25:29 +00:00
Fomafix 0dd8769311 search.less: Use static width for the search button
Now the width of the search box can increased without increasing
the width of the search button.

Change-Id: I0a9746c16dce44ff2a458e76a55741fcb1f7af0b
2014-08-28 17:13:22 +00:00
Bartosz Dziewoński 768ba62ad3 Vector: Remove compatibility for old variant menu HTML
Removing backwards-compatibility CSS from an earlier change.

Follow-up to Idf43d77dccff83ad81db776f3262e0ef12d25c92.

Change-Id: I2817c6e9eb52ffc785a04bb9d23b0802a553fd45
2014-08-21 20:29:48 +00:00
Arlo Breault b1c2dd38ba Use .mw-body instead of div#content
* Part of https://gerrit.wikimedia.org/r/#/c/151395/

Change-Id: Iae873906abcd8b2a986e5f728f0ce207256de770
2014-08-13 03:52:51 -07:00
Bartosz Dziewoński d28f09df31 Move Vector skin from core
This is the final step of the process described at
<https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>.

Corresponding core change: Idfc38503.

Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 13:38:34 +02:00