golem/VectorGOLEM
9
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity

Remove unnecessary div wrapper on overflow menu

Browse Source 
Unordered lists can be absolute positioned down to IE 7.
Outdated selector `.vectorMenu ul` remains for a release cycle
until HTML cache is renewed.

Bug: T209558
Change-Id: Id18ca9a8d705572b1f7e17920ef52b80e9aec373
This commit is contained in:
Volker E 2018-11-14 17:18:06 -08:00
parent 8d7fa67747
commit da6d4eb280
2 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
components/tabs.less
View File

@ -162,15 +162,18 @@
} }
.vectorMenu .menu { .vectorMenu .menu {
list-style: none none;
background-color: @body-background-color;
clear: both;
// Match the width of the dropdown "heading" (the tab) // Match the width of the dropdown "heading" (the tab)
min-width: 100%; min-width: 100%;
position: absolute; position: absolute;
top: 2.5em; top: 2.5em;
left: -1px; left: -1px;
background-color: @body-background-color; margin: 0;
border: 1px solid #a2a9b1; border: 1px solid #a2a9b1;
border-top-width: 0; border-top-width: 0;
clear: both; padding: 0;
box-shadow: 0 1px 1px 0 rgba( 0, 0, 0, 0.1 ); box-shadow: 0 1px 1px 0 rgba( 0, 0, 0, 0.1 );
text-align: left; text-align: left;
display: none; display: none;
@ -187,6 +190,7 @@
display: block; display: block;
} }
// FIXME: `.vectorMenu ul` can be removed with purged HTML cache
.vectorMenu ul { .vectorMenu ul {
list-style: none none; list-style: none none;
padding: 0; padding: 0;

32
includes/VectorTemplate.php
View File

@ -357,15 +357,13 @@ class VectorTemplate extends BaseTemplate {
<h3 id="p-variants-label"> <h3 id="p-variants-label">
<span><?php echo htmlspecialchars( $variantLabel ) ?></span> <span><?php echo htmlspecialchars( $variantLabel ) ?></span>
</h3> </h3>
<div class="menu"> <ul class="menu">
<ul> <?php
<?php foreach ( $this->data['variant_urls'] as $key => $item ) {
foreach ( $this->data['variant_urls'] as $key => $item ) { echo $this->makeListItem( $key, $item );
echo $this->makeListItem( $key, $item ); }
} ?>
?> </ul>
</ul>
</div>
</div> </div>
<?php <?php
break; break;
@ -401,15 +399,13 @@ class VectorTemplate extends BaseTemplate {
<h3 id="p-cactions-label"><span><?php <h3 id="p-cactions-label"><span><?php
$this->msg( 'vector-more-actions' ) $this->msg( 'vector-more-actions' )
?></span></h3> ?></span></h3>
<div class="menu"> <ul class="menu"<?php $this->html( 'userlangattributes' ) ?>>
<ul<?php $this->html( 'userlangattributes' ) ?>> <?php
<?php foreach ( $this->data['action_urls'] as $key => $item ) {
foreach ( $this->data['action_urls'] as $key => $item ) { echo $this->makeListItem( $key, $item );
echo $this->makeListItem( $key, $item ); }
} ?>
?> </ul>
</ul>
</div>
</div> </div>
<?php <?php
break; break;