From 9abf12bbfa9e6b7831be96b74359eb497cd9c117 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Tue, 5 Jan 2021 18:01:45 +0000 Subject: [PATCH] Use padding margin-collapse hack instead of overflow Using the overflow hack breaks scrolling logic in OOUI. Bug: T271868 Bug: T270146 Change-Id: I4038164efe54a8fb847781a004af98ec74c92cdb --- resources/skins.vector.styles/layout-default.less | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/resources/skins.vector.styles/layout-default.less b/resources/skins.vector.styles/layout-default.less index 5549d0a..0f081dd 100644 --- a/resources/skins.vector.styles/layout-default.less +++ b/resources/skins.vector.styles/layout-default.less @@ -164,12 +164,10 @@ body { min-height: 100%; margin-left: auto; margin-right: auto; - padding: 0 ( @padding-horizontal-page-container / 2 ); + // Use non-zero padding to disable margin collapse. + // Be careful not to use overflow-y: scroll here (see T270146 and T271868) + padding: 0.05px ( @padding-horizontal-page-container / 2 ); background-color: @background-color-page-container; - // Establish a new block formatting context to prevent header top margin - // collapsing and causing whitespace to appear between the header and - // viewport. - overflow-y: auto; } // Used as a container for absolutely positioned elements.