golem
/
VectorGOLEM
9
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity

Move namespace & view tabs into a VectorTabs.mustache component 

Creates a new VectorTabs.mustache component and uses it to render
the namespace & view tabs.

Bug: T239248
Change-Id: I859e4e95a2a12470f66564db547679c9f0a16727
This commit is contained in:
Jan Drewniak 2019-12-03 14:02:11 +01:00
parent f790133284
commit c12c5f06db
2 changed files with 46 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
includes/VectorTemplate.php
View File

@ -272,13 +272,13 @@ class VectorTemplate extends BaseTemplate {
foreach ( $elements as $name => $element ) {
switch ( $element ) {
case 'NAMESPACES':
$this->renderNamespacesComponent();
$this->renderNamespacesComponent( $templateParser );
break;
case 'VARIANTS':
$this->renderVariantsComponent();
break;
case 'VIEWS':
$this->renderViewsComponent();
$this->renderViewsComponent( $templateParser );
break;
case 'ACTIONS':
$this->renderActionsComponent();
@ -315,23 +315,24 @@ class VectorTemplate extends BaseTemplate {
return parent::makeListItem( $key, $item, $options );
}
private function renderNamespacesComponent() {
?>
<div id="p-namespaces" role="navigation" class="vectorTabs<?php
if ( count( $this->data['namespace_urls'] ) == 0 ) {
echo ' emptyPortlet';
}
?>" aria-labelledby="p-namespaces-label">
<h3 id="p-namespaces-label"><?php $this->msg( 'namespaces' ) ?></h3>
<ul<?php $this->html( 'userlangattributes' ) ?>>
<?php
foreach ( $this->data['namespace_urls'] as $key => $item ) {
echo $this->makeListItem( $key, $item );
}
?>
</ul>
</div>
<?php
/**
* @param TemplateParser $templateParser
*/
private function renderNamespacesComponent( TemplateParser $templateParser ) {
$props = [
'tabs-id' => 'p-namespaces',
'empty-portlet' => ( count( $this->data['namespace_urls'] ) == 0 ) ? 'emptyPortlet' : '',
'label-id' => 'p-namespaces-label',
'msg-label' => $this->getMsg( 'namespaces' )->text(),
'html-userlangattributes' => $this->html( 'userlangattributes' ),
'html-items' => '',
];
foreach ( $this->data['namespace_urls'] as $key => $item ) {
$props[ 'html-items' ] .= $this->makeListItem( $key, $item );
};
echo $templateParser->processTemplate( 'VectorTabs', $props );
}
private function renderVariantsComponent() {
@ -366,25 +367,26 @@ class VectorTemplate extends BaseTemplate {
<?php
}
private function renderViewsComponent() {
?>
<div id="p-views" role="navigation" class="vectorTabs<?php
if ( count( $this->data['view_urls'] ) == 0 ) {
echo ' emptyPortlet';
}
?>" aria-labelledby="p-views-label">
<h3 id="p-views-label"><?php $this->msg( 'views' ) ?></h3>
<ul<?php $this->html( 'userlangattributes' ) ?>>
<?php
foreach ( $this->data['view_urls'] as $key => $item ) {
echo $this->makeListItem( $key, $item, [
'vector-collapsible' => true,
] );
}
?>
</ul>
</div>
<?php
/**
* @param TemplateParser $templateParser
*/
private function renderViewsComponent( TemplateParser $templateParser ) {
$props = [
'tabs-id' => 'p-views',
'empty-portlet' => ( count( $this->data['view_urls'] ) == 0 ) ? 'emptyPortlet' : '',
'label-id' => 'p-views-label',
'msg-label' => $this->getMsg( 'views' )->text(),
'html-userlangattributes' => $this->html( 'userlangattributes' ),
'html-items' => '',
];
foreach ( $this->data['view_urls'] as $key => $item ) {
$props[ 'html-items' ] .= $this->makeListItem( $key, $item, [
'vector-collapsible' => true,
] );
};
echo $templateParser->processTemplate( 'VectorTabs', $props );
}
private function renderActionsComponent() {

6
includes/templates/VectorTabs.mustache Normal file
View File

@ -0,0 +1,6 @@
<div id="{{tabs-id}}" role="navigation" class="vectorTabs {{empty-portlet}}" aria-labelledby="{{label-id}}">
<h3 id="{{label-id}}">{{msg-label}}</h3>
<ul {{{html-userlangattributes}}}>
{{{html-items}}}
</ul>
</div>