Merge "Use the SkinMustache template variable for the main page link"

This commit is contained in:
jenkins-bot 2020-11-17 19:14:01 +00:00 committed by Gerrit Code Review
commit b1bbcd298f
2 changed files with 2 additions and 5 deletions

View File

@ -115,7 +115,6 @@ class SkinVector extends SkinMustache {
// It should be followed by the name of the hook in hyphenated lowercase.
//
// Conditionally used values must use null to indicate absence (not false or '').
$mainPageHref = Skin::makeMainPageUrl();
$parentData = parent::getTemplateData();
@ -131,8 +130,6 @@ class SkinVector extends SkinMustache {
'input-location' => $this->getSearchBoxInputLocation(),
'main-page-href' => $mainPageHref,
'data-sidebar' => $this->getTemplateDataSidebar(),
'sidebar-visible' => $this->isSidebarVisible(),
], $this->getMenuProps() );

View File

@ -1,10 +1,10 @@
{{!
LogoDefinition logo
string main-page-href link to the main page
string link-mainpage link to the main page (from SkinMustache in core)
string msg-sitesubtitle the contents of the sitesubtitle message key
}}
{{#data-logos}}
<a href="{{main-page-href}}" class="mw-logo">
<a href="{{link-mainpage}}" class="mw-logo">
{{#icon}}
{{! alt is provided for valid HTML but given aria-hidden not needed. }}
<img class="mw-logo-icon" src="{{.}}" alt=""