golem
/
VectorGOLEM
9
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity

Make max-width the default for modern Vector 

Drop max width feature flag.
Max-width will continue to not apply on special pages.

This saves us development effort by not needing to worry about
the case where the flag is not enabled. This flag is not false
in any production wikis.

Change-Id: I7ace4046e6b93ce63dd804da32e576a709485bfb
This commit is contained in:
jdlrobson 2020-09-03 10:35:35 -07:00 committed by Jdlrobson
parent a8cfbe5e84
commit 905ad68bc2
3 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
includes/Constants.php
View File

@ -69,11 +69,6 @@ final class Constants {
public const CONFIG_KEY_DEFAULT_SIDEBAR_VISIBLE_FOR_ANONYMOUS_USER =
'VectorDefaultSidebarVisibleForAnonymousUser';
/**
* @var string
*/
public const CONFIG_KEY_LAYOUT_MAX_WIDTH = 'VectorLayoutMaxWidth';
/**
* @var string
*/

4
includes/Hooks.php
View File

@ -263,9 +263,7 @@ class Hooks {
return;
}
if ( self::getConfig( Constants::CONFIG_KEY_LAYOUT_MAX_WIDTH ) ) {
$bodyAttrs['class'] .= ' skin-vector-max-width';
}
$bodyAttrs['class'] .= ' skin-vector-max-width';
// As of 2020/08/12, the following CSS classes are referred to by the following deployed
// extensions:

4
skin.json
View File

@ -195,10 +195,6 @@
"VectorDefaultSidebarVisibleForAnonymousUser": {
"value": false
},
"VectorLayoutMaxWidth": {
"value": false,
"description": "@var boolean Enables the max-width layout for the latest version of Vector. This is intended to be a very short-lived feature flag whose sole purpose is to derisk the deployment of T246420. It should be removed (and made the default) as quickly as possible."
},
"VectorDisableSidebarPersistence": {
"value": false,
"description": "@var boolean Temporary feature flag that disables saving the sidebar expanded/collapsed state as a user-preference (triggered via clicking the main menu icon). This is intended as a temporary kill-switch in the event that the DB is overloaded with writes to the user_options table."