From 83e63d3e9932f0452f300f9939b1287866f84240 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Thu, 22 Jul 2021 12:25:32 -0700 Subject: [PATCH] Sidebar hover background should be consistent with mw-ui-icon Remove override now it's a default. Addresses Alex's feedback item 1 in T191021#7231088 Bug: T191021 Change-Id: I2702ffb9cbee2dfc841b3f03638fdfd24a128493 --- resources/common/variables.less | 3 --- resources/skins.vector.styles/components/Sidebar.less | 2 -- resources/skins.vector.styles/components/UserLinks.less | 6 ++++-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/resources/common/variables.less b/resources/common/variables.less index 1942641..937e37f 100644 --- a/resources/common/variables.less +++ b/resources/common/variables.less @@ -15,9 +15,6 @@ @color-link-new: #a55858; @color-link-selected: @color-base; -// See oojs/ui/src/themes/wikimediaui/common.less. -@background-color-frameless--hover: rgba( 0, 24, 73, 7/255 ); // equivalent to @wmui-color-base90 on white - @outline-color-base--focus: @color-primary; // diff --git a/resources/skins.vector.styles/components/Sidebar.less b/resources/skins.vector.styles/components/Sidebar.less index 02bd1be..777dc13 100644 --- a/resources/skins.vector.styles/components/Sidebar.less +++ b/resources/skins.vector.styles/components/Sidebar.less @@ -29,8 +29,6 @@ } &:hover { - background-color: @background-color-frameless--hover; - &:before { opacity: 1; } diff --git a/resources/skins.vector.styles/components/UserLinks.less b/resources/skins.vector.styles/components/UserLinks.less index 8988b51..34b5e25 100644 --- a/resources/skins.vector.styles/components/UserLinks.less +++ b/resources/skins.vector.styles/components/UserLinks.less @@ -47,9 +47,11 @@ } .vector-menu-checkbox { + // FIXME: This variable is currently not available in mediawiki core, but defined in the icons specification. + @icon-background-color--selected: rgba( 0, 0, 0, 0.03 ); + // The mw-ui-icon hover effect does not work on the checkbox hack so must be applied explicitly. &:hover + h3 { - background-color: @colorGray14; - border-radius: @border-radius-base; + background-color: @icon-background-color--selected; } }