From 35b2f65914c817681879c33449bf2f520f1f4a47 Mon Sep 17 00:00:00 2001 From: Volker E Date: Thu, 11 Jun 2020 17:24:17 -0700 Subject: [PATCH] [less] Extract cross-browser normalization rules into new 'normalize.less' Change-Id: I23da024b47020212173380315acd37210b924327 --- resources/skins.vector.styles/common/normalize.less | 12 ++++++++++++ resources/skins.vector.styles/layout.less | 7 ------- resources/skins.vector.styles/legacy/layout.less | 7 ------- resources/skins.vector.styles/skin-legacy.less | 1 + resources/skins.vector.styles/skin.less | 1 + 5 files changed, 14 insertions(+), 14 deletions(-) create mode 100644 resources/skins.vector.styles/common/normalize.less diff --git a/resources/skins.vector.styles/common/normalize.less b/resources/skins.vector.styles/common/normalize.less new file mode 100644 index 0000000..cdd5331 --- /dev/null +++ b/resources/skins.vector.styles/common/normalize.less @@ -0,0 +1,12 @@ +/* + * Normalize styles across rendering engines. + * Ideally, these rules should live in core and be shared across skins. + * + */ + +html, +body { + height: 100%; + margin: 0; + padding: 0; +} diff --git a/resources/skins.vector.styles/layout.less b/resources/skins.vector.styles/layout.less index 2886011..2a6b154 100644 --- a/resources/skins.vector.styles/layout.less +++ b/resources/skins.vector.styles/layout.less @@ -22,13 +22,6 @@ 2 * @padding-vertical-header; @width-grid-column-one: 11em; -html, -body { - height: 100%; - margin: 0; - padding: 0; -} - body { // General background/foreground color definition as one exception to the rule. background-color: @background-color-base; diff --git a/resources/skins.vector.styles/legacy/layout.less b/resources/skins.vector.styles/legacy/layout.less index 94717d4..f97d9c9 100644 --- a/resources/skins.vector.styles/legacy/layout.less +++ b/resources/skins.vector.styles/legacy/layout.less @@ -4,13 +4,6 @@ @import 'mediawiki.mixins.less'; @import '../../../variables.less'; -html, -body { - height: 100%; - margin: 0; - padding: 0; -} - body { background-color: @background-color-secondary; overflow-y: scroll; diff --git a/resources/skins.vector.styles/skin-legacy.less b/resources/skins.vector.styles/skin-legacy.less index 885a451..4b6ea60 100644 --- a/resources/skins.vector.styles/skin-legacy.less +++ b/resources/skins.vector.styles/skin-legacy.less @@ -4,6 +4,7 @@ @import 'mediawiki.mixins.less'; @media screen { + @import 'common/normalize.less'; @import 'legacy/layout.less'; @import 'common/content.less'; @import 'common/typography.less'; diff --git a/resources/skins.vector.styles/skin.less b/resources/skins.vector.styles/skin.less index 78690c6..aaea558 100644 --- a/resources/skins.vector.styles/skin.less +++ b/resources/skins.vector.styles/skin.less @@ -4,6 +4,7 @@ @import 'mediawiki.mixins.less'; @media screen { + @import 'common/normalize.less'; @import 'layout.less'; @import 'common/content.less'; @import 'common/typography.less';