[Hygiene] [Mustache] improve template parameters and docs

Add typing expectations to search box template parameters. Add context
expectations to search box and tabs templates.

Bug: T239248
Change-Id: I4ff1920f5489b68ef73a219ceeceb1f5511fc9e8
This commit is contained in:
Stephen Niedzielski 2019-12-06 16:37:39 -07:00
parent e0b29624d1
commit 60148a1a92
3 changed files with 22 additions and 4 deletions

View File

@ -457,8 +457,8 @@ class VectorTemplate extends BaseTemplate {
*/
private function renderSearchComponent( TemplateParser $templateParser ) {
$props = [
'searchHeaderAttrs' => $this->data[ 'userlangattributes' ] ?? '',
'searchAction' => $this->data[ 'wgScript' ] ?? '',
'searchHeaderAttrsHTML' => $this->data[ 'userlangattributes' ] ?? '',
'searchActionURL' => $this->data[ 'wgScript' ] ?? '',
'searchDivID' => $this->config->get( 'VectorUseSimpleSearch' ) ? 'simpleSearch' : '',
'searchInputHTML' => $this->makeSearchInput( [ 'id' => 'searchInput' ] ),
'titleHTML' => Html::hidden( 'title', $this->data[ 'searchtitle' ] ?? null ),

View File

@ -1,8 +1,18 @@
{{!
string|null searchHeaderAttrsHTML
string|null searchInputLabel
string searchActionURL
string searchDivID
string|null searchInputHTML
string|null titleHTML
string|null fallbackSearchButtonHTML
string|null searchButtonHTML
}}
<div id="p-search" role="search">
<h3 {{{searchHeaderAttrs}}}>
<h3 {{{searchHeaderAttrsHTML}}}>
<label for="searchInput">{{searchInputLabel}}</label>
</h3>
<form action="{{searchAction}}" id="searchform">
<form action="{{searchActionURL}}" id="searchform">
<div id="{{searchDivID}}">
{{{searchInputHTML}}}
{{{titleHTML}}}

View File

@ -1,3 +1,11 @@
{{!
string tabs-id
string|null empty-portlet
string label-id
string|null msg-label
string|null html-userlangattributes
string|null html-items
}}
<div id="{{tabs-id}}" role="navigation" class="vectorTabs {{empty-portlet}}" aria-labelledby="{{label-id}}">
<h3 id="{{label-id}}">{{msg-label}}</h3>
<ul {{{html-userlangattributes}}}>