From 7446c28f795b0cf214ac215086299c35622dc911 Mon Sep 17 00:00:00 2001 From: Volker E Date: Tue, 1 Oct 2019 17:11:37 -0700 Subject: [PATCH] Re-order `background*` properties to unify across files Orienting on https://www.mediawiki.org/wiki/Topic:Tv3wddg7n9nz8ft8 Change-Id: I4504600fcc0c54f684eddde9c66cbc6b4d419846 --- components/navigation.less | 10 +++++----- components/tabs.less | 8 ++++---- components/watchstar.less | 6 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/components/navigation.less b/components/navigation.less index 4a852bc..1a553c3 100644 --- a/components/navigation.less +++ b/components/navigation.less @@ -15,8 +15,8 @@ /* Head */ #mw-page-base { - height: 5em; background-position: bottom left; + height: 5em; .vertical-gradient( @background-color-base, @background-color-secondary, 50%, 100% ); } @@ -57,11 +57,11 @@ height: 160px; a { + background-position: center center; + background-repeat: no-repeat; display: block; width: 10em; height: 160px; - background-repeat: no-repeat; - background-position: center center; text-decoration: none; } } @@ -90,12 +90,12 @@ } .body { - margin-left: @margin-left-nav-main-body; - padding-top: 0; background-image: url( images/portal-separator.png ); // Support: IE 8 & 9, Fx 3.6-15, Safari 5.1-6, Chrome 10-25 background-image: linear-gradient( to right, transparent 0, #c8ccd1 35%, #c8ccd1 70%, transparent 100% ); // Standard (Firefox 16+, IE 10+, Safari 6.1+, Chrome 26+) background-repeat: no-repeat; background-size: 100% @border-width-base; + margin-left: @margin-left-nav-main-body; + padding-top: 0; ul { list-style: none none; diff --git a/components/tabs.less b/components/tabs.less index 4d7ee7c..ffdc5bd 100644 --- a/components/tabs.less +++ b/components/tabs.less @@ -113,14 +113,14 @@ &:after { content: ''; + .background-image-svg( 'images/arrow-down.svg', 'images/arrow-down.png' ); + background-position: 100% 50%; + background-repeat: no-repeat; position: absolute; top: 1.25em; right: 0; bottom: 0; left: 0; - .background-image-svg('images/arrow-down.svg', 'images/arrow-down.png'); - background-position: 100% 50%; - background-repeat: no-repeat; // Modify the color of the image from the default #222 to approx. #444 to match the text. opacity: 0.85; } @@ -137,8 +137,8 @@ } .menu { - list-style: none none; background-color: @background-color-base; + list-style: none none; clear: both; // Match the width of the dropdown "heading" (the tab) min-width: 100%; diff --git a/components/watchstar.less b/components/watchstar.less index 49d4c25..af40f42 100644 --- a/components/watchstar.less +++ b/components/watchstar.less @@ -6,6 +6,8 @@ .vectorTabs { // `#ca-unwatch` & `#ca-watch` both carry `.mw-watchlink` as well. .mw-watchlink.icon a { + background-position: 5px 60%; + background-repeat: no-repeat; margin: 0; padding: 0; display: block; @@ -15,8 +17,6 @@ padding-top: 2.5em / 0.8125; height: 0; overflow: hidden; - background-position: 5px 60%; - background-repeat: no-repeat; } #ca-unwatch.icon a { @@ -41,12 +41,12 @@ #ca-unwatch.icon .loading, #ca-watch.icon .loading { background-image: url( images/watch-icon-loading.svg ); + background-position: 50% 60%; .rotation( 700ms ); /* Suppress the hilarious rotating focus outline on Firefox */ outline: 0; cursor: default; pointer-events: none; - background-position: 50% 60%; -webkit-transform-origin: 50% 57%; transform-origin: 50% 57%; }