golem
/
VectorGOLEM
9
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity

Fix icon button spacing, make it consistent with margin defined in core 

Since a margin was added to adjacent sibling spans of icons (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/736919), Vector icon buttons have had too much spacing. This patch removes the extra spacing defined in Vector CSS and the accidental whitespace that was included in the ULS buttons..

Change-Id: I308d1941c5f82cb144c2a9d233fbf44c730413a7
This commit is contained in:
bwang 2021-11-18 12:50:04 -06:00 committed by Bernard Wang
parent 4cbfdcb2f7
commit 54639c4af3
3 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
includes/templates/Button.mustache
View File

@ -4,7 +4,6 @@
{{#tabindex}}tabindex="{{.}}"{{/tabindex}}
{{#event}}data-event-name="{{.}}"{{/event}}
class="mw-ui-button{{#is-quiet}} mw-ui-quiet{{/is-quiet}}{{#icon}} mw-ui-icon mw-ui-icon-element mw-ui-icon-{{.}}{{/icon}} {{class}}">
{{{html-vector-button-icon}}}
<span>{{label}}</span>
{{{html-vector-button-icon}}}<span>{{label}}</span>
{{#href}}</a>{{/href}}
{{^href}}</button>{{/href}}

3
includes/templates/Menu.mustache
View File

@ -13,8 +13,7 @@
class="{{#checkbox-class}}{{.}} {{/checkbox-class}}vector-menu-checkbox" aria-labelledby="{{id}}-label" />
{{/is-dropdown}}
<h3 id="{{id}}-label" aria-label="{{aria-label}}"{{#heading-class}} class="{{.}}"{{/heading-class}}{{^is-legacy}} aria-hidden="true"{{/is-legacy}}>
{{{html-vector-heading-icon}}}
<span>{{label}}</span>
{{{html-vector-heading-icon}}}<span>{{label}}</span>
{{#is-dropdown}}
<span class="vector-menu-checkbox-expanded">{{msg-vector-menu-checkbox-expanded}}</span>
<span class="vector-menu-checkbox-collapsed">{{msg-vector-menu-checkbox-collapsed}}</span>

4
resources/skins.vector.styles/components/UserLinks.less
View File

@ -25,10 +25,6 @@
a {
color: @color-base;
text-decoration: none;
.mw-ui-icon {
margin-right: 4px;
}
}
// Below tablet threshold, all menu items except the notification icons will collapse into the user menu