From 380d6d678907f2be5a40d7967a8452c8c2c951a8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= <matma.rex@gmail.com>
Date: Sat, 17 Oct 2020 00:27:43 +0200
Subject: [PATCH] Set strictUnits to true for LESS, and fix units in the code

Bug: T265650
Change-Id: I8f7522f84df31fdfc856901566c7d1fc78e12c66
---
 .storybook/webpack.config.js | 3 ++-
 variables.less               | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/.storybook/webpack.config.js b/.storybook/webpack.config.js
index 829742f..0acb91f 100644
--- a/.storybook/webpack.config.js
+++ b/.storybook/webpack.config.js
@@ -24,7 +24,7 @@ module.exports = {
 		},
 		{
 			test: /\.(gif|png|jpe?g|svg)$/i,
-			loader: 'file-loader', 
+			loader: 'file-loader',
 			options: {
 				paths: [
 					path.resolve( __dirname, './resolve-imports' )
@@ -42,6 +42,7 @@ module.exports = {
 				loader: 'less-loader',
 				options: {
 					relativeUrls: false,
+					strictUnits: true,
 					paths: [
 					 	path.resolve( __dirname, 'resolve-imports' )
 					]
diff --git a/variables.less b/variables.less
index 644864c..4599796 100644
--- a/variables.less
+++ b/variables.less
@@ -95,8 +95,8 @@
 @margin-start-portal-body: @margin-start-nav-main-body;
 
 // Navigation: Personal tools
-@background-position-nav-personal-icon: left ( 4 / @font-size-browser / @font-size-nav-personal );
-@background-size-nav-personal-icon: 14 / @font-size-browser / @font-size-nav-personal;
+@background-position-nav-personal-icon: left unit( 4 / @font-size-browser / @font-size-nav-personal, em );
+@background-size-nav-personal-icon: unit( 14 / @font-size-browser / @font-size-nav-personal, em );
 @top-personal-tools: 6px;
 @font-size-nav-personal: 0.75em;
 // Using `unit()` without second parameter to achieve a unitless output for `line-height`.
@@ -106,7 +106,7 @@
 @font-size-tabs: unit( 13 / @font-size-browser, em ); // Equals `0.8125em`.
 
 // Search
-@width-search-button: 24 / @font-size-browser / @font-size-search-input;
+@width-search-button: unit( 24 / @font-size-browser / @font-size-search-input, em );
 @font-size-search-input: unit( 13 / @font-size-browser, em ); // Equals `0.8125em`.
 
 // Z-indices