golem
/
VectorGOLEM
9
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity

[Refactor] Simplify searchbox layout rules 

Follow up to I340b9e7e91960713c0ebb4d3d26e2ae2d5628f37

The layout styles reference internal CSS classes within
Vector components that may change at any time.

For legacy layout, I leave the styles the same (they have a FIXME)
As Aron noted on code review the impact such a change
could have on user styles. For modern however I simplify the styles
as follows:
* The top margin on the form is promoted to the main element - this has
the same end result.
* Likewise the width dimensions are moved from child elements to
the parent


Bug: T249363
Change-Id: If923a5dddaac6217462e75d476e07d923ee1743f
This commit is contained in:
jdlrobson 2020-07-07 12:11:43 -07:00 committed by Jdlrobson
parent ba8ec2f842
commit 018f30c615
1 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
resources/skins.vector.styles/layout.less
View File

@ -77,21 +77,7 @@ body {
/* Searchbox */
#p-search {
float: left;
margin-right: 0.5em;
margin-left: 0.5em;
// FIXME: This selector requires knowledge of the internals of the search component
// and should not be used here.
form {
margin: 0.5em 0 0;
}
}
// Defined as `div`.
// Provide extra element for gadgets due to `form` already carrying an `id`.
// FIXME: This selector requires knowledge of the internals of the search component
// and should not be used here.
#simpleSearch {
margin: 0.5em 0.5em 0 0.5em;
min-width: 5em;
// Support: IE 8, Firefox 18-, Chrome 19-, Safari 5.1-, Opera 19-, Android 4.4.4-.
width: 13.2em;