golem
/
VectorGOLEM
9
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
VectorGOLEM/resources/skins.vector.js/index.js

11 lines
216 B
JavaScript
Raw Normal View History

[dev] [JS] Move JavaScript to package modules Move all Vector JavaScript to ResourceLoader `packageFiles`[0] which are much more compatible with modern development practices: - The entrypoint is the first `packageFiles` entry (unless specified otherwise). All other JavaScript must be explicitly executed. - Remove a level of indentation due to IIFEs from every JavaScript file. Regretfully, ESLint does not support modules except in ES6+ so the otherwise useful `no-implicit-globals` rule must be disable. The change comes with a comment so we always remember. - IDEs and other tooling understand Node.js-like `module.exports` / `require()`. This change seemed the most sensible way to start developing new JavaScript in Vector needed by the collapsible sidebar. [0]: https://www.mediawiki.org/wiki/ResourceLoader/Package_modules Change-Id: I287e604d5b1055aa97b5f987c24872755757ea1a
2020-04-10 15:24:13 +00:00
var
[dev][Legacy][JS] Split Legacy mode JavaScript into new ResourceLoader module The collapsible sidebar adds a new JavaScript dependency and behavior to Latest mode only. There are a number of ways of to make the deviation but we think now is the time to start splitting by module. This patch adds a new ResourceLoader module, skins.vector.legacy.js, and moves the existing JavaScript into it. The old module, skins.vector.js, has been given a currently matching index.js entry point that references the collapsible tabs' files by reaching across directories. It's not quite ideal as usually ResourceLoader modules and directory structures strive for 1:1 correspondence but this patch makes the bold assertions that it's better than a file copy, better than a new "skins.vector.common.js" ResourceLoader module, more compatible than a symlink, and the existing jQuery tabs implementation will eventually be replaced in Latest mode. A "Legacy" module was added instead of a "Latest" with the assumption that active development should generally be considered "latest" and Legacy an intentional distinction. Bug: T246419 Change-Id: I9980403f1ee5897c27ac0331f0b51a5bcbdff778
2020-05-11 21:29:56 +00:00
collapsibleTabs = require( '../skins.vector.legacy.js/collapsibleTabs.js' ),
vector = require( '../skins.vector.legacy.js/vector.js' );
[dev] [JS] Move JavaScript to package modules Move all Vector JavaScript to ResourceLoader `packageFiles`[0] which are much more compatible with modern development practices: - The entrypoint is the first `packageFiles` entry (unless specified otherwise). All other JavaScript must be explicitly executed. - Remove a level of indentation due to IIFEs from every JavaScript file. Regretfully, ESLint does not support modules except in ES6+ so the otherwise useful `no-implicit-globals` rule must be disable. The change comes with a comment so we always remember. - IDEs and other tooling understand Node.js-like `module.exports` / `require()`. This change seemed the most sensible way to start developing new JavaScript in Vector needed by the collapsible sidebar. [0]: https://www.mediawiki.org/wiki/ResourceLoader/Package_modules Change-Id: I287e604d5b1055aa97b5f987c24872755757ea1a
2020-04-10 15:24:13 +00:00
function main() {
collapsibleTabs.init();
$( vector.init );
}
main();