golem
/
VectorGOLEM
9
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
VectorGOLEM/resources/skins.vector.icons/chevronHorizontal-rtl.svg

7 lines
255 B
XML
Raw Normal View History

[feature] add menu button to toggle panel visibility Add a menu button that toggles the panel's (also referred to as a sidebar) collapse state. When the screen is wide enough, animate the transition. The menu icon from OOUI is copied into Vector to avoid two ResourceLoaders modules (collapseHorizontal icon isn't ready for inclusion in the OOUI icon pack and ResourceLoaderOOUIIconPackModule doesn't support images). Additional polish and collaboration is needed but this patch fulfills the scope of its referenced task. Bug: T246419 Depends-On: I8e153c0ab927f9d880a68fb9efb0bf37b91d26b2 Change-Id: Ic9d54de7e19ef8d5dfd703d95a45b78c0aaf791a
2020-03-30 20:07:35 +00:00
<?xml version="1.0" encoding="UTF-8"?>
<svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 20 20">
<title>
[fix][RTL] flip menu collapse button icon Fix the icon button directionality in right-to-left languages. Previously, the button was hardcoded to support left-to-right only. - Replace the skin.vector.icons' `.mw-ui-icon-wikimedia-{name}:before` `selector` in skin.json with a placeholder, `{name}`. I don't think this selector should be needed but it seems to be erroneous not have one. I believe this issue of wanting a null selector was encountered in Minerva or MobileFrontend but am unable to locate the past discourse. - Add check and unchecked menu button selectors to skin.json that set the appropriate background image. This shards some of the styles out of Less and into ResourceLoader-land but it's worthwhile. - Revise the name of horizontal collapse icon to describe its form not function, "collapseHorizontal" to "chevronHorizontal". This has been an established convention that was missed a couple patches back. - Add a flipped chevronHorizontal for RTL. I used Inkscape to do the flip and tried to match the style of the original by hand. Feel free to edit further. - Drop the now unnecessary icon flipping JavaScript and initial Mustache class. This enables a real CSS-only solution for the icons. Bug: T246419 Change-Id: I60f65b3c595bf18d309b667d9a0b066691b90c97
2020-06-02 03:09:42 +00:00
chevron
[feature] add menu button to toggle panel visibility Add a menu button that toggles the panel's (also referred to as a sidebar) collapse state. When the screen is wide enough, animate the transition. The menu icon from OOUI is copied into Vector to avoid two ResourceLoaders modules (collapseHorizontal icon isn't ready for inclusion in the OOUI icon pack and ResourceLoaderOOUIIconPackModule doesn't support images). Additional polish and collaboration is needed but this patch fulfills the scope of its referenced task. Bug: T246419 Depends-On: I8e153c0ab927f9d880a68fb9efb0bf37b91d26b2 Change-Id: Ic9d54de7e19ef8d5dfd703d95a45b78c0aaf791a
2020-03-30 20:07:35 +00:00
</title>
[fix][RTL] flip menu collapse button icon Fix the icon button directionality in right-to-left languages. Previously, the button was hardcoded to support left-to-right only. - Replace the skin.vector.icons' `.mw-ui-icon-wikimedia-{name}:before` `selector` in skin.json with a placeholder, `{name}`. I don't think this selector should be needed but it seems to be erroneous not have one. I believe this issue of wanting a null selector was encountered in Minerva or MobileFrontend but am unable to locate the past discourse. - Add check and unchecked menu button selectors to skin.json that set the appropriate background image. This shards some of the styles out of Less and into ResourceLoader-land but it's worthwhile. - Revise the name of horizontal collapse icon to describe its form not function, "collapseHorizontal" to "chevronHorizontal". This has been an established convention that was missed a couple patches back. - Add a flipped chevronHorizontal for RTL. I used Inkscape to do the flip and tried to match the style of the original by hand. Feel free to edit further. - Drop the now unnecessary icon flipping JavaScript and initial Mustache class. This enables a real CSS-only solution for the icons. Bug: T246419 Change-Id: I60f65b3c595bf18d309b667d9a0b066691b90c97
2020-06-02 03:09:42 +00:00
<path d="M11 2 9.7 3.3 16.3 10 9.7 16.7 11 18 19 10ZM2.5 2 1 3.3 7.8 10 1.1 16.7 2.5 18l8-8z"/>
[feature] add menu button to toggle panel visibility Add a menu button that toggles the panel's (also referred to as a sidebar) collapse state. When the screen is wide enough, animate the transition. The menu icon from OOUI is copied into Vector to avoid two ResourceLoaders modules (collapseHorizontal icon isn't ready for inclusion in the OOUI icon pack and ResourceLoaderOOUIIconPackModule doesn't support images). Additional polish and collaboration is needed but this patch fulfills the scope of its referenced task. Bug: T246419 Depends-On: I8e153c0ab927f9d880a68fb9efb0bf37b91d26b2 Change-Id: Ic9d54de7e19ef8d5dfd703d95a45b78c0aaf791a
2020-03-30 20:07:35 +00:00
</svg>