golem
/
VectorGOLEM
9
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
VectorGOLEM/README.md

22 lines
444 B
Markdown
Raw Normal View History

Add print logo Logo cannot be displayed as a background image because it won't be visible in print unless the user prints backgrounds too. A sample configuration looks like this: $wgVectorPrintLogo = [ 'url' => 'https://en.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-en.svg', 'width' => 174, 'height' => 27 ]; The solution presented in the patch has a downside of not being able to scale images down if their dimensions are bigger than the dimensions specified in the config variable. For example, if we want to go with an SVG image, then IE8 won't be able to render it. Alternatively, if we want to go with a PNG image, its dimensions need to match the exact dimensoins in the config variable, otherwise the image will show up larger or smaller depending on its dimensions. A more complicated approach of scaling images using `transform: scale` hasn't been used because we wanted to keep the configuration simple while supporting the majority of our users. With the current change, we can reuse the existing configuration options from Minerva, for exmaple. It would look something like this: $wgVectorPrintLogo = [ 'url' => $wgMFCustomLogos['copyright'], 'width' => $wgMFCustomLogos['copyright-width'], 'height' => $wgMFCustomLogos['copyright-height'] ]; Bug: T169826 Change-Id: If8f9f8d95fd3c955ece37d6c8ab6995596189667
2017-07-19 19:27:55 +00:00
Vector Skin
========================
Add Coding Conventions Section to Vector README Although the convention of where to put conventions remains somewhat contentious, the team's desired conventions for Desktop Improvments have so far been, for the most part, general and could be useful for any project our team owns (e.g. MobileFrontend, Minerva, etc). Therefore, I added/made revisions to the https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions wiki page as this seems the be the single source of truth of our team specific conventions that span across repos. This commit just links to these changes which follows the same pattern as Minerva and MobileFrontend. Additional Changes: * Added installation section similar to Minerva Skin Bug: T239269 Change-Id: I41c71fba1228086f1830d8bb0808227b62ebf5cd
2020-02-05 05:32:22 +00:00
Installation
------------
Add print logo Logo cannot be displayed as a background image because it won't be visible in print unless the user prints backgrounds too. A sample configuration looks like this: $wgVectorPrintLogo = [ 'url' => 'https://en.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-en.svg', 'width' => 174, 'height' => 27 ]; The solution presented in the patch has a downside of not being able to scale images down if their dimensions are bigger than the dimensions specified in the config variable. For example, if we want to go with an SVG image, then IE8 won't be able to render it. Alternatively, if we want to go with a PNG image, its dimensions need to match the exact dimensoins in the config variable, otherwise the image will show up larger or smaller depending on its dimensions. A more complicated approach of scaling images using `transform: scale` hasn't been used because we wanted to keep the configuration simple while supporting the majority of our users. With the current change, we can reuse the existing configuration options from Minerva, for exmaple. It would look something like this: $wgVectorPrintLogo = [ 'url' => $wgMFCustomLogos['copyright'], 'width' => $wgMFCustomLogos['copyright-width'], 'height' => $wgMFCustomLogos['copyright-height'] ]; Bug: T169826 Change-Id: If8f9f8d95fd3c955ece37d6c8ab6995596189667
2017-07-19 19:27:55 +00:00
Add Coding Conventions Section to Vector README Although the convention of where to put conventions remains somewhat contentious, the team's desired conventions for Desktop Improvments have so far been, for the most part, general and could be useful for any project our team owns (e.g. MobileFrontend, Minerva, etc). Therefore, I added/made revisions to the https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions wiki page as this seems the be the single source of truth of our team specific conventions that span across repos. This commit just links to these changes which follows the same pattern as Minerva and MobileFrontend. Additional Changes: * Added installation section similar to Minerva Skin Bug: T239269 Change-Id: I41c71fba1228086f1830d8bb0808227b62ebf5cd
2020-02-05 05:32:22 +00:00
See <https://www.mediawiki.org/wiki/Skin:Vector>
Development
-----------
### Coding conventions
We strive for compliance with MediaWiki conventions:
<https://www.mediawiki.org/wiki/Manual:Coding_conventions>
Additions and deviations from those conventions that are more tailored to this
project are noted at:
<https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions>